This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[scene_host] Cleanup scene_host closures #9061
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanderso
reviewed
May 22, 2019
arbreng
changed the title
zanderso
reviewed
Jun 4, 2019
zanderso
reviewed
Jun 4, 2019
chinmaygarde
approved these changes
Jun 4, 2019
Fix null closure warnings, and a possible race condition where the handle for the view_holder_token is destroyed on the gpu thread. The handle's destructor enters the isolate, so it must be destroyed on the UI thread. FL-257 #done FL-269 #done
zanderso
approved these changes
Jun 4, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 4, 2019
This was referenced Jun 4, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 5, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 5, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Jun 5, 2019
flutter/engine@86aa014...bf15bd0 git log 86aa014..bf15bd0 --no-merges --oneline bf15bd0 Add the key event source, vendorId, and productId from Android (flutter/engine#9186) d4c7c30 Roll src/third_party/skia a4bb02063672..346f82c1c3e0 (6 commits) (flutter/engine#9188) 7746e2e Compile the physical_shape_layer_unittests.cc TU. (flutter/engine#9187) 12f48f7 Allow for whitelisted flags to be passed to the Dart VM (flutter/engine#9148) b304dab [scene_host] Cleanup scene_host closures (flutter/engine#9061) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff ([email protected]), and stop the roller if necessary.
huqiuser
pushed a commit
to huqiuser/engine
that referenced
this pull request
Jun 12, 2019
Fix null closure warnings, and a possible race condition where the handle for the view_holder_token is destroyed on the gpu thread. The handle's destructor enters the isolate, so it must be destroyed on the UI thread. FL-257 #done FL-269 #done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.