This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Add mode to load AOT snapshots as a native lib #8979
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
jason-simmons
approved these changes
May 17, 2019
Contributor
|
LGTM |
matthew-carroll
approved these changes
May 20, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 20, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
May 20, 2019
flutter/engine@3a50919...20f5000 git log 3a50919..20f5000 --no-merges --oneline 20f5000 Add mode to load AOT snapshots as a native lib (flutter/engine#8979) ec347cf Roll src/third_party/dart ed169c4bb0..82c8c78739 (17 commits) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff ([email protected]), and stop the roller if necessary.
huqiuser
pushed a commit
to huqiuser/engine
that referenced
this pull request
Jun 12, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables a new mode in which we look at the snapshot from the
lib/directory instead ofassets. This is required so that an app bundle.aabcan contain AOT snapshots for arm and arm64 and users will only download the snapshots needed for the user's device ABI.Tested=Manually.
As discussed, we need to add tests to the embedder, but there is some pending work here.
Related issue: flutter/flutter#31922
\cc @dnfield