This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Use Android text selection shifting API to delete #8956
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GaryQian
changed the title
jason-simmons
approved these changes
May 14, 2019
Member
|
DynamicLayout.Builder requires API level 28. Use the old DynamicLayout constructor and suppress the deprecation warning. |
Contributor
Author
|
Landing on red LUCI engine build, as tree is in a known passing state after reverts (#8969) |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 15, 2019
This was referenced May 15, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 15, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
May 15, 2019
flutter/engine@849fa42...2080117 git log 849fa42..2080117 --no-merges --oneline 2080117 Roll src/third_party/skia 3f79f07a14eb..348880c3f67f (3 commits) (flutter/engine#8971) 4559951 Roll src/third_party/skia c8a84d2b7ff9..3f79f07a14eb (1 commits) (flutter/engine#8968) f5fa03b Use Android text selection shifting API to handle keyboard backspace (flutter/engine#8956) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff ([email protected]), and stop the roller if necessary.
huqiuser
pushed a commit
to huqiuser/engine
that referenced
this pull request
Jun 12, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we were subtracting a hard coded 1 index from the selection.
Here, we make use of Android's capability of distinguishing grapheme clusters to properly shift over by one glyph.
This fixes Chinese keyboards not being able to delete emojis.
Fixes flutter/flutter#23496