This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Copy the Dart Runner from //topaz into the engine. #8949
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
I was having trouble reconciling the different modes with the way engine builds its artifacts. The GN rule in this patch just builds the runner. I still need to tinker with it some. |
jason-simmons
approved these changes
May 13, 2019
zanderso
approved these changes
May 13, 2019
| } | ||
|
|
||
| executable("dart") { | ||
| output_name = "dt_rush" |
Member
Author
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 13, 2019
This was referenced May 13, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 14, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 14, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
May 14, 2019
flutter/engine@c83ec26...5ac2d02 git log c83ec26..5ac2d02 --no-merges --oneline 5ac2d02 Avoid disabling sources assignment filters are these have been removed. (flutter/engine#8954) 51486a5 New Plugin API PR2: Introduces ActivityAware, ActivityControlSurface, and ActivityPluginBinding. (flutter/engine#8943) b3b817a Add a minimal set of symbols to the dynamic symbol table for Linux executables (flutter/engine#8937) 96ffc89 Copy the Dart Runner from //topaz into the engine. (flutter/engine#8949) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff ([email protected]), and stop the roller if necessary.
huqiuser
pushed a commit
to huqiuser/engine
that referenced
this pull request
Jun 12, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.