Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@matthew-carroll
Copy link
Contributor

New Plugin API PR2: Introduces ActivityAware, ActivityControlSurface, and ActivityPluginBinding.

Locally, I ported the CameraPlugin, PathProviderPlugin, and VideoPlugin to this new API and everything seems to be working.

Copy link
Contributor

@mklim mklim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matthew-carroll matthew-carroll merged commit 51486a5 into flutter:master May 14, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 14, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 14, 2019
engine-flutter-autoroll added a commit to flutter/flutter that referenced this pull request May 14, 2019
flutter/engine@c83ec26...5ac2d02

git log c83ec26..5ac2d02 --no-merges --oneline
5ac2d02 Avoid disabling sources assignment filters are these have been removed. (flutter/engine#8954)
51486a5 New Plugin API PR2: Introduces ActivityAware, ActivityControlSurface, and ActivityPluginBinding. (flutter/engine#8943)
b3b817a Add a minimal set of symbols to the dynamic symbol table for Linux executables (flutter/engine#8937)
96ffc89 Copy the Dart Runner from //topaz into the engine. (flutter/engine#8949)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff ([email protected]), and stop
the roller if necessary.
huqiuser pushed a commit to huqiuser/engine that referenced this pull request Jun 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants