This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Fix TimePoint on Windows #8910
Merged
Fix TimePoint on Windows #8910
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses overflow issues with timer multiplication by using std::chrono instead of QueryPerformanceCounter. The Windows implementatino of std::chrono uses QPC, so this should have no impact on performance or clock resolution. Fixes flutter#32121
Contributor
Author
|
I'm deliberately separating changing the Windows implementation from unifying the implementations, so that if for some unlikely reason unifying causes issues on iOS or Android, a revert won't regress Windows. |
chinmaygarde
approved these changes
May 9, 2019
Member
chinmaygarde
left a comment
chinmaygarde
left a comment
There was a problem hiding this comment.
Sounds good about fixing the Windows issue in isolation. Can you also patch the other platforms to use this in a subsequent patch?
Contributor
Author
|
Yes, will do. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 9, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 9, 2019
This was referenced May 9, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 9, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 9, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 9, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 9, 2019
This was referenced May 9, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 9, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
May 9, 2019
flutter/engine@3ef5007...644db5a git log 3ef5007..644db5a --no-merges --oneline 644db5a Standardize TimePoint implementaion on std::chrono (flutter/engine#8913) 1c8e31b Make sure Window.dpr still has a setter (flutter/engine#8912) ad02f3c Roll src/third_party/dart 678f4bb926..a0290f823c (1 commits) ccfc02a Roll src/third_party/skia dfda5f57bf25..dbded16fadde (1 commits) (flutter/engine#8918) f901126 Roll src/third_party/skia b9330017c070..dfda5f57bf25 (2 commits) (flutter/engine#8917) c12b917 Roll src/third_party/dart ef0c812b0d..678f4bb926 (11 commits) ee45100 Roll src/third_party/skia 15c91422339a..b9330017c070 (11 commits) (flutter/engine#8915) 812616a Fix TimePoint on Windows (flutter/engine#8910) 30885db Roll src/third_party/dart f7bf890ff7..ef0c812b0d (13 commits) 78adbf7 Add web sdk implementation. (flutter/engine#8891) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff ([email protected]), and stop the roller if necessary.
huqiuser
pushed a commit
to huqiuser/engine
that referenced
this pull request
Jun 12, 2019
Addresses overflow issues with timer multiplication by using std::chrono instead of QueryPerformanceCounter. The Windows implementation of std::chrono uses QPC, so this should have no impact on performance or clock resolution. Fixes flutter#32121
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses overflow issues with timer multiplication by using std::chrono
instead of QueryPerformanceCounter. The Windows implementatino of
std::chrono uses QPC, so this should have no impact on performance or
clock resolution.
Fixes #32121