This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Change Vertices.indices to use a Uint16 list to more accurately reflect Skia's API #8657
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinmaygarde
approved these changes
Apr 19, 2019
| if (indices.data()) { | ||
| std::copy(indices.data(), indices.data() + indices.num_elements(), | ||
| builder.indices()); | ||
| } |
Member
There was a problem hiding this comment.
Return false if the data is not present?
Member
Author
There was a problem hiding this comment.
indices is an optional argument
Member
|
The licenses need patching. |
…ct Skia's API Also throw if SkVertices::Builder reports an invalid configuration. Fixes flutter/flutter#31270
jason-simmons
force-pushed
the
bug_31270
branch
from
3004069 to
e1f6eb8
Compare
Member
|
Is this good to go? |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 22, 2019
…ly reflect Skia's API (flutter/engine#8657)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 23, 2019
…ly reflect Skia's API (flutter/engine#8657)
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Apr 23, 2019
flutter/engine@934772d...0523870 git log 934772d..0523870 --no-merges --oneline 0523870 Add tests from framework (flutter/engine#8692) ed1f3fd Change Vertices.indices to use a Uint16 list to more accurately reflect Skia's API (flutter/engine#8657) 4f2fd84 Revert Rect/RRect 64 bit (flutter/engine#8690) 6dc5dca Revert "Remove unused Settings::ToString. (#8642)" (flutter/engine#8689) 9fa7336 fix toString (flutter/engine#8688) c123152 Make Rect and RRect use 64 bit doubles, and make them const-able (flutter/engine#8565) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff ([email protected]), and stop the roller if necessary.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also throw if SkVertices::Builder reports an invalid configuration.
Fixes flutter/flutter#31270