Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Revert "Change Rect internal representation from Float32List to Float64List (#8524)" #8545

Merged
bkonyi merged 1 commit into from
Apr 11, 2019
Merged

Revert "Change Rect internal representation from Float32List to Float64List (#8524)" #8545

bkonyi merged 1 commit into from
Apr 11, 2019

Conversation

@bkonyi
Copy link
Contributor

@bkonyi bkonyi commented Apr 11, 2019

This reverts commit 0b36d3e.

cc/ @HansMuller

Blocking engine roll due to failures similar to the following (full logs here):

04:04 +3164 ~31 -6: /tmp/flutter sdk/packages/flutter/test/material/scaffold_test.dart: Scaffold and extreme window padding                                                                            
══╡ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK ╞════════════════════════════════════════════════════
The following TestFailure object was thrown running a test:
  Expected: Rect:<Rect.fromLTRB(36.0, 255.0, 113.0, 332.0)>
  Actual: Rect:<Rect.fromLTRB(36.0, 255.0, 113.0, 332.0)>

When the exception was thrown, this was the stack:
#4      main.<anonymous closure> (file:///tmp/flutter%20sdk/packages/flutter/test/material/scaffold_test.dart:765:5)
<asynchronous suspension>
#5      testWidgets.<anonymous closure>.<anonymous closure> (package:flutter_test/src/widget_tester.dart:108:25)
<asynchronous suspension>
#6      TestWidgetsFlutterBinding._runTestBody (package:flutter_test/src/binding.dart:589:19)
<asynchronous suspension>
#9      TestWidgetsFlutterBinding._runTest (package:flutter_test/src/binding.dart:573:14)
#10     AutomatedTestWidgetsFlutterBinding.runTest.<anonymous closure> (package:flutter_test/src/binding.dart:920:24)
#16     AutomatedTestWidgetsFlutterBinding.runTest (package:flutter_test/src/binding.dart:917:15)
#17     testWidgets.<anonymous closure> (package:flutter_test/src/widget_tester.dart:106:22)
#18     Declarer.test.<anonymous closure>.<anonymous closure>.<anonymous closure> (package:test_api/src/backend/declarer.dart:168:27)
<asynchronous suspension>
#19     Invoker.waitForOutstandingCallbacks.<anonymous closure> (package:test_api/src/backend/invoker.dart:250:15)
<asynchronous suspension>
#24     Invoker.waitForOutstandingCallbacks (package:test_api/src/backend/invoker.dart:247:5)
#25     Declarer.test.<anonymous closure>.<anonymous closure> (package:test_api/src/backend/declarer.dart:166:33)
#30     Declarer.test.<anonymous closure> (package:test_api/src/backend/declarer.dart:165:13)
<asynchronous suspension>
#31     Invoker._onRun.<anonymous closure>.<anonymous closure>.<anonymous closure>.<anonymous closure> (package:test_api/src/backend/invoker.dart:400:25)
<asynchronous suspension>
#45     _Timer._runTimers (dart:isolate-patch/timer_impl.dart:382:19)
#46     _Timer._handleMessage (dart:isolate-patch/timer_impl.dart:416:5)
#47     _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:171:12)
(elided 28 frames from class _FakeAsync, package dart:async, package dart:async-patch, and package
stack_trace)

This was caught by the test expectation on the following line:
  file:///tmp/flutter%20sdk/packages/flutter/test/material/scaffold_test.dart line 765

The test description was:
Scaffold and extreme window padding
════════════════════════════════════════════════════════════════════════════════════════════════════

@dnfield
Copy link
Contributor

dnfield commented Apr 11, 2019

LGTM. Can you file a bug for this?

@bkonyi bkonyi mentioned this pull request Apr 11, 2019
Closed
@bkonyi
Copy link
Contributor Author

bkonyi commented Apr 11, 2019

Issue filed as flutter/flutter#30920

@bkonyi bkonyi merged commit ae4df6f into master Apr 11, 2019
@bkonyi bkonyi deleted the revert_0b36d3e2f0235f25dc5b5657bd2e594fe7414aee branch April 11, 2019 16:22
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 11, 2019
@engine-flutter-autoroll
ae4df6f Revert "Change Rect internal representation from Float32List …
b50a019 
…to Float64List (flutter#8524)" (flutter/engine#8545)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 11, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 11, 2019
@engine-flutter-autoroll
ae4df6f Revert "Change Rect internal representation from Float32List …
f056f8c 
…to Float64List (flutter#8524)" (flutter/engine#8545)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 11, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 11, 2019
@engine-flutter-autoroll
ae4df6f Revert "Change Rect internal representation from Float32List …
4953591 
…to Float64List (flutter#8524)" (flutter/engine#8545)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 11, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 11, 2019
@engine-flutter-autoroll
ae4df6f Revert "Change Rect internal representation from Float32List …
88df3d2 
…to Float64List (flutter#8524)" (flutter/engine#8545)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 11, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 11, 2019
@engine-flutter-autoroll
ae4df6f Revert "Change Rect internal representation from Float32List …
ae746d2 
…to Float64List (flutter#8524)" (flutter/engine#8545)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 11, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 11, 2019
@engine-flutter-autoroll
ae4df6f Revert "Change Rect internal representation from Float32List …
cc5966f 
…to Float64List (flutter#8524)" (flutter/engine#8545)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 11, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 12, 2019
@engine-flutter-autoroll
ae4df6f Revert "Change Rect internal representation from Float32List …
9b35141 
…to Float64List (flutter#8524)" (flutter/engine#8545)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 12, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 12, 2019
@engine-flutter-autoroll
ae4df6f Revert "Change Rect internal representation from Float32List …
b0b3f8d 
…to Float64List (flutter#8524)" (flutter/engine#8545)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 12, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 12, 2019
@engine-flutter-autoroll
ae4df6f Revert "Change Rect internal representation from Float32List …
d6a928f 
…to Float64List (flutter#8524)" (flutter/engine#8545)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 12, 2019
Merged
engine-flutter-autoroll added a commit to flutter/flutter that referenced this pull request Apr 12, 2019
@engine-flutter-autoroll
Roll engine 72986c3..f804c29 (23 commits) (#30948)
404f66d 
flutter/engine@72986c3...f804c29

git log 72986c3..f804c29 --no-merges --oneline
f804c29 Roll src/third_party/skia 3b60397fd35d..f74fff660084 (3 commits) (flutter/engine#8556)
1b448e5 Roll Dart 15b11b018364ce032eae50d78fc8a52b541e2bce...a8f3a5dae6203d1064726a5953cf06a7d484249c (flutter/engine#8555)
99259ae Roll src/third_party/skia 36477b49c2ef..3b60397fd35d (6 commits) (flutter/engine#8554)
f37220d Roll src/third_party/skia c33e6dcc700b..36477b49c2ef (8 commits) (flutter/engine#8552)
d84d204 Android Embedding PR30: Make FlutterView focusable so that the keyboard can interact with it. (flutter/engine#8551)
a344015 [fuchsia] Add flutter:: to scene_host.cc (flutter/engine#8549)
711d843 Roll src/third_party/skia 76e626d9bb55..c33e6dcc700b (4 commits) (flutter/engine#8547)
82e6d68 Eliminate unused write to local (flutter/engine#8541)
f53e477 Correct nullability for FlutterStandardReader (flutter/engine#8537)
c00364a [font_collection] Add missing semicolon (flutter/engine#8546)
ae4df6f Revert &#34;Change Rect internal representation from Float32List to Float64List (#8524)&#34; (flutter/engine#8545)
ffdddb0 Roll src/third_party/skia 6d60534e95d8..76e626d9bb55 (1 commits) (flutter/engine#8544)
5ac728e Roll src/third_party/skia 4d657d5e894a..6d60534e95d8 (3 commits) (flutter/engine#8543)
ee462ff Roll src/third_party/skia 99d792276740..4d657d5e894a (1 commits) (flutter/engine#8542)
18816c5 Roll src/third_party/skia 42280f8961fa..99d792276740 (8 commits) (flutter/engine#8539)
892591d Android Embedding PR28: Report app is active to Flutter in FlutterFragment.onResume() instead of onPostResume() forwarded from Activity. (flutter/engine#8536)
330c6c1 Use code cache dir for engine cache on API &gt;= 21 (#14704). (flutter/engine#8534)
c10ae2b Add an option to build the GLFW shell on macOS (flutter/engine#8531)
29aa5fc Roll src/third_party/skia b5c685991faa..42280f8961fa (32 commits) (flutter/engine#8535)
0a2869e Added support for authentication codes for the VM service (flutter/engine#8527)
36d2135 Redo a fix for cull rect calculation on TransformLayers with a perspective transform (flutter/engine#8528)
0b36d3e Change Rect internal representation from Float32List to Float64List (flutter/engine#8524)
b1ae0cc Roll src/third_party/skia 10bf7020aa15..b5c685991faa (3 commits) (flutter/engine#8526)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff ([email protected]), and stop
the roller if necessary.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 13, 2019
@engine-flutter-autoroll
ae4df6f Revert "Change Rect internal representation from Float32List …
b70009c 
…to Float64List (flutter#8524)" (flutter/engine#8545)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 13, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bkonyi @dnfield @googlebot