Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@liyuqian
Copy link
Contributor

@liyuqian liyuqian commented Apr 6, 2019

The dart revision 1ad11fa
(rolled in #8459) is causing
engine-to-framework roll failure for the following two reasons:

  1. analyze error: marked @mustCallSuper but does not invoke the overridden method
  2. flutter build aot failure for examples/hello_world in build_tests-macos

The 1. is likely due to
dart-lang/sdk@1ad11fa
and it easy to fix in the framework.

However, the 2. is likely due to
dart-lang/sdk@dbfd00f
which I'm not sure how to fix.

TBR: bkonyi

The dart revision 1ad11fa
(rolled in flutter#8459) is causing
engine-to-framework roll failure for the following two reasons:

1. analyze error: marked @mustCallSuper but does not invoke the overridden method
2. `flutter build aot` failure for examples/hello_world in build_tests-macos

The 1. is likely due to
dart-lang/sdk@1ad11fa
and it easy to fix in the framework.

However, the 2. is likely due to
dart-lang/sdk@dbfd00f
which I'm not sure how to fix.

TBR: bkonyi
@liyuqian liyuqian requested a review from bkonyi April 6, 2019 21:17
@liyuqian liyuqian merged commit 0c393d6 into flutter:master Apr 6, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 6, 2019
engine-flutter-autoroll added a commit to flutter/flutter that referenced this pull request Apr 6, 2019
flutter/engine@6bc33b5...0c393d6

git log 6bc33b5..0c393d6 --no-merges --oneline
0c393d6 Roll dart back to 907c514c8937cf76e (flutter/engine#8473)
fea42a2 Roll src/third_party/dart 9e1adc54a7..389ccc9000 (10 commits)
d6cf2bd Roll src/third_party/dart da4ccd0855..9e1adc54a7 (3 commits)
0c2a2c1 Initialize OpacityLayer's matrix to identity (flutter/engine#8467)
7fd4caf Roll src/third_party/dart 1ad11facec..da4ccd0855 (6 commits)
d3fbaea Android Embedding PR25: Prevent black rectangle when launching FlutterActivity (flutter/engine#8460)
99da038 Document the leak_vm flag. (flutter/engine#8462)
ce7c21c Log the correct function on error in the embedder. (flutter/engine#8461)
e10d464 Improve path metrics tests and docs (flutter/engine#7851)
424045c Enable shutting down all root isolates in a VM. (flutter/engine#8457)
816e3dc Roll src/third_party/dart 907c514c89..1ad11facec (7 commits)
45dc353 Roll src/third_party/skia 0e35ce27e0e9..053b2939938c (10 commits) (flutter/engine#8458)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff ([email protected]), and stop
the roller if necessary.
@liyuqian liyuqian deleted the roll_back_dart branch April 7, 2019 18:32
RBogie pushed a commit to RBogie/flutter-engine that referenced this pull request Apr 8, 2019
The dart revision 1ad11fa
(rolled in flutter#8459) is causing
engine-to-framework roll failure for the following two reasons:

1. analyze error: marked @mustCallSuper but does not invoke the overridden method
2. `flutter build aot` failure for examples/hello_world in build_tests-macos

The 1. is likely due to
dart-lang/sdk@1ad11fa
and it easy to fix in the framework.

However, the 2. is likely due to
dart-lang/sdk@dbfd00f
which I'm not sure how to fix.

TBR: bkonyi
RBogie added a commit to RBogie/flutter-engine that referenced this pull request Apr 8, 2019
RBogie added a commit to RBogie/flutter-engine that referenced this pull request Apr 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants