This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Initialize OpacityLayer's matrix to identity #8467
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liyuqian
requested review from
GaryQian,
cbracken,
chinmaygarde and
jason-simmons
GaryQian
approved these changes
Apr 6, 2019
chinmaygarde
reviewed
Apr 6, 2019
flow/layers/opacity_layer.cc
Outdated
|
|
||
| // Be careful: SkMatrix's default constructor doesn't initialize the matrix to | ||
| // identity. Hence we have to explicitly call SkMatrix::MakeTrans(0, 0). | ||
| SkMatrix identity = SkMatrix::MakeTrans(0, 0); |
Member
There was a problem hiding this comment.
SkMatrix::setIdentity() is more idiomatic.
Contributor
Author
There was a problem hiding this comment.
Ok. I was trying to save one line since setIndentity requires two lines:
SkMatrix identity;
identity.setIdentity();
Will change to setIdentity() shortly.
chinmaygarde
approved these changes
Apr 6, 2019
Member
chinmaygarde
left a comment
chinmaygarde
left a comment
There was a problem hiding this comment.
LGTM after using one of the more idiomatic ways of setting a matrix to identity.
flow/layers/opacity_layer.cc
Outdated
|
|
||
| // Be careful: SkMatrix's default constructor doesn't initialize the matrix to | ||
| // identity. Hence we have to explicitly call SkMatrix::MakeTrans(0, 0). | ||
| SkMatrix identity = SkMatrix::MakeTrans(0, 0); |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 6, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 6, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 6, 2019
liyuqian
added a commit
to liyuqian/flutter
that referenced
this pull request
Apr 6, 2019
flutter/engine@6bc33b5...fea42a2 git log 6bc33b5..fea42a2 --no-merges --oneline fea42a2 Roll src/third_party/dart 9e1adc54a7..389ccc9000 (10 commits) d6cf2bd Roll src/third_party/dart da4ccd0855..9e1adc54a7 (3 commits) 0c2a2c1 Initialize OpacityLayer&flutter#39;s matrix to identity (flutter/engine#8467) 7fd4caf Roll src/third_party/dart 1ad11facec..da4ccd0855 (6 commits) d3fbaea Android Embedding PR25: Prevent black rectangle when launching FlutterActivity (flutter/engine#8460) 99da038 Document the leak_vm flag. (flutter/engine#8462) ce7c21c Log the correct function on error in the embedder. (flutter/engine#8461) e10d464 Improve path metrics tests and docs (flutter/engine#7851) 424045c Enable shutting down all root isolates in a VM. (flutter/engine#8457) 816e3dc Roll src/third_party/dart 907c514c89..1ad11facec (7 commits) 45dc353 Roll src/third_party/skia 0e35ce27e0e9..053b2939938c (10 commits) (flutter/engine#8458) This roll also includes manual fix for @mustCallSuper update: call the super method whenever possible, and suppress warnings in tests.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 6, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Apr 6, 2019
flutter/engine@6bc33b5...0c393d6 git log 6bc33b5..0c393d6 --no-merges --oneline 0c393d6 Roll dart back to 907c514c8937cf76e (flutter/engine#8473) fea42a2 Roll src/third_party/dart 9e1adc54a7..389ccc9000 (10 commits) d6cf2bd Roll src/third_party/dart da4ccd0855..9e1adc54a7 (3 commits) 0c2a2c1 Initialize OpacityLayer's matrix to identity (flutter/engine#8467) 7fd4caf Roll src/third_party/dart 1ad11facec..da4ccd0855 (6 commits) d3fbaea Android Embedding PR25: Prevent black rectangle when launching FlutterActivity (flutter/engine#8460) 99da038 Document the leak_vm flag. (flutter/engine#8462) ce7c21c Log the correct function on error in the embedder. (flutter/engine#8461) e10d464 Improve path metrics tests and docs (flutter/engine#7851) 424045c Enable shutting down all root isolates in a VM. (flutter/engine#8457) 816e3dc Roll src/third_party/dart 907c514c89..1ad11facec (7 commits) 45dc353 Roll src/third_party/skia 0e35ce27e0e9..053b2939938c (10 commits) (flutter/engine#8458) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff ([email protected]), and stop the roller if necessary.
RBogie
pushed a commit
to RBogie/flutter-engine
that referenced
this pull request
Apr 8, 2019
Should have flutter/flutter#30586 fixed once the engine rolls.
RBogie
added a commit
to RBogie/flutter-engine
that referenced
this pull request
Apr 8, 2019
This reverts commit eb42b89.
RBogie
added a commit
to RBogie/flutter-engine
that referenced
this pull request
Apr 8, 2019
This reverts commit eb42b89.
Contributor
|
test? |
Contributor
Author
|
I still haven't finished the test in my local branch. It seems that our |
chingjun
pushed a commit
to chingjun/engine
that referenced
this pull request
Apr 11, 2019
Should have flutter/flutter#30586 fixed once the engine rolls.
chingjun
added a commit
that referenced
this pull request
Apr 11, 2019
Should have flutter/flutter#30586 fixed once the engine rolls.
chingjun
added a commit
to chingjun/flutter
that referenced
this pull request
Apr 11, 2019
Apply hotfix from flutter/engine#8548 flutter/engine@4737fc5cd Initialize OpacityLayer's matrix to identity (flutter/engine#8467) (flutter/engine#8548)
Hixie
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 12, 2019
Apply hotfix from flutter/engine#8548 flutter/engine@4737fc5cd Initialize OpacityLayer's matrix to identity (flutter/engine#8467) (flutter/engine#8548)
liyuqian
added a commit
to liyuqian/engine
that referenced
this pull request
Apr 15, 2019
To catch issues like flutter/flutter#30586 We'll also upload a test in the framework that will trigger this DCHECK if flutter#8467 were reverted.
liyuqian
added a commit
to liyuqian/engine
that referenced
this pull request
Apr 15, 2019
To catch issues like flutter/flutter#30586 We'll also upload a test in the framework that will trigger this DCHECK if flutter#8467 were reverted.
Contributor
Author
|
@Hixie : please see the test in flutter/flutter#31097 |
liyuqian
added a commit
that referenced
this pull request
Apr 17, 2019
To catch issues like flutter/flutter#30586 flutter/flutter#31097 will trigger this CHECK if #8467 were reverted and the transform_ were not initialized in this PR.
9 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#30586
Will try to add a test to framework to catch this. From my local test, SkASSERT should trigger during debug build for a
TextFieldwidget inside anOpacitywidget.