This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Remove use of DART_CHECK_VALID. #8417
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinmaygarde
reviewed
Apr 3, 2019
Member
chinmaygarde
left a comment
chinmaygarde
left a comment
There was a problem hiding this comment.
I am not sure about the error handling by propagation in case of isolate creation or library initialization. Is my understanding off about the error handling to be employed here?
| Dart_LookupLibrary(ToDart("dart:io")), dart::bin::LookupIONative, | ||
| dart::bin::LookupIONativeSymbol); | ||
| if (Dart_IsError(result)) { | ||
| Dart_PropagateError(result); |
Member
There was a problem hiding this comment.
Isn't this called from the isolate create callback. The error handling contract there is to return nullptr from the callback as the isolate handle. In that case, I think this function should return a bool or something to indicate failure and have the create callback return null.
Contributor
Author
There was a problem hiding this comment.
Right, this code is still incorrect, but it will unblock the next Dart roll.
chinmaygarde
approved these changes
Apr 3, 2019
Member
chinmaygarde
left a comment
chinmaygarde
left a comment
There was a problem hiding this comment.
lgtm to unblock the roll. Feel free to assign a bug to me to track these down.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 4, 2019
This was referenced Apr 4, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 4, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 4, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Apr 4, 2019
flutter/engine@309d078...ad9d241 git log 309d078..ad9d241 --no-merges --oneline ad9d241 Roll src/third_party/skia dde12a25bb5e..f346df396a23 (1 commits) (flutter/engine#8438) 0ed237c Roll src/third_party/skia b6d04556c34d..dde12a25bb5e (4 commits) (flutter/engine#8437) 445ab42 Roll src/third_party/dart 11a3dd7332..600b2831ef (9 commits) 49d0dc6 Roll src/third_party/skia 5c5de2146309..b6d04556c34d (1 commits) (flutter/engine#8434) 4ff18fb Roll src/third_party/dart f6768b6fb3..11a3dd7332 (56 commits) 7b83198 Roll src/third_party/skia 2273c900ea28..5c5de2146309 (5 commits) (flutter/engine#8432) 800ea0a Revert "Enable shutting down all root isolates in a VM. (#8402)" (flutter/engine#8431) b59c443 Enable shutting down all root isolates in a VM. (flutter/engine#8402) 9acdf18 Make AccessibilityViewEmbedder final (flutter/engine#8429) 804d54d Eliminate unused displayBounds parameter (flutter/engine#8427) d4c815f Roll buildroot (flutter/engine#8425) 20190d7 Roll src/third_party/skia fbe240669394..2273c900ea28 (13 commits) (flutter/engine#8428) 7e38b0a Revert "Revert "Separate the data required to bootstrap the VM into its own class. (#8397)" (#8406)" (flutter/engine#8414) d8bb9d7 Roll src/third_party/skia 176da0bb8a10..fbe240669394 (9 commits) (flutter/engine#8424) 64fc583 Remove use of DART_CHECK_VALID. (flutter/engine#8417) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff ([email protected]), and stop the roller if necessary.
RBogie
pushed a commit
to RBogie/flutter-engine
that referenced
this pull request
Apr 8, 2019
RBogie
added a commit
to RBogie/flutter-engine
that referenced
this pull request
Apr 8, 2019
This reverts commit 1c7e671.
RBogie
added a commit
to RBogie/flutter-engine
that referenced
this pull request
Apr 8, 2019
This reverts commit 1c7e671.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: flutter/flutter#30407