This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Separate the data required to bootstrap the VM into its own class. #8397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When attempting to shutdown and subsequently restart the VM, having the VM own this data introduces lifecycle issues due to circular references.
Member
Author
|
Landing. Engine bots were broken but have been patched in https://github.com/flutter/infra/pull/29. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 1, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Apr 2, 2019
flutter/engine@6c1b0b8...c991647 git log 6c1b0b8..c991647 --no-merges --oneline c991647 Separate the data required to bootstrap the VM into its own class. (flutter/engine#8397) 8c9aca4 Roll src/third_party/skia de206c75c2c8..b27667a15a15 (14 commits) (flutter/engine#8399) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff ([email protected]), and stop the roller if necessary.
chinmaygarde
added a commit
to chinmaygarde/flutter_engine
that referenced
this pull request
Apr 2, 2019
…ts own class. (flutter#8397)" (flutter#8406)" This reverts commit f7b4903.
chinmaygarde
added a commit
that referenced
this pull request
Apr 3, 2019
RBogie
pushed a commit
to RBogie/flutter-engine
that referenced
this pull request
Apr 8, 2019
…lutter#8397) When attempting to shutdown and subsequently restart the VM, having the VM own this data introduces lifecycle issues due to circular references.
RBogie
pushed a commit
to RBogie/flutter-engine
that referenced
this pull request
Apr 8, 2019
…lass. (flutter#8397)" (flutter#8406) This reverts commit c991647.
RBogie
pushed a commit
to RBogie/flutter-engine
that referenced
this pull request
Apr 8, 2019
…ts own class. (flutter#8397)" (flutter#8406)" (flutter#8414) This reverts commit f7b4903.
RBogie
added a commit
to RBogie/flutter-engine
that referenced
this pull request
Apr 8, 2019
…M into its own class. (flutter#8397)" (flutter#8406)" (flutter#8414)" This reverts commit 138e8c4.
RBogie
added a commit
to RBogie/flutter-engine
that referenced
this pull request
Apr 8, 2019
…ts own class. (flutter#8397)" (flutter#8406)" This reverts commit 0a37328.
RBogie
added a commit
to RBogie/flutter-engine
that referenced
this pull request
Apr 8, 2019
…lass. (flutter#8397)" This reverts commit 2c8c7a6.
RBogie
added a commit
to RBogie/flutter-engine
that referenced
this pull request
Apr 8, 2019
…M into its own class. (flutter#8397)" (flutter#8406)" (flutter#8414)" This reverts commit 138e8c4.
RBogie
added a commit
to RBogie/flutter-engine
that referenced
this pull request
Apr 8, 2019
…ts own class. (flutter#8397)" (flutter#8406)" This reverts commit 0a37328.
RBogie
added a commit
to RBogie/flutter-engine
that referenced
this pull request
Apr 8, 2019
…lass. (flutter#8397)" This reverts commit 2c8c7a6.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When attempting to shutdown and subsequently restart the VM, having the
VM own this data introduces lifecycle issues due to circular references.
This is an effort to land #7905 in a more
incremental and reviewable fashion. That patch has been abandoned.