This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Do not pass short-lived buffers as labels to Dart_TimelineEvent #8166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dart no longer makes a copy of the label string when recording events. See flutter#8152
chinmaygarde
approved these changes
Mar 14, 2019
Member
chinmaygarde
left a comment
chinmaygarde
left a comment
There was a problem hiding this comment.
Adding an allocator specific check so we catch these in the engine unittests.
chinmaygarde
added a commit
to chinmaygarde/flutter_engine
that referenced
this pull request
Mar 14, 2019
…imeline are not heap allocated. Verfied that the tests fail on issues like flutter#8166. Unfortunately, there is no x-platform way to perform this check but this should gate incorrect traces being added to the engine.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 14, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 14, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 14, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 14, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 14, 2019
This was referenced Mar 14, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 15, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 15, 2019
RBogie
pushed a commit
to RBogie/flutter-engine
that referenced
this pull request
Apr 8, 2019
…ter#8166) Dart no longer makes a copy of the label string when recording events. See flutter#8152
RBogie
pushed a commit
to RBogie/flutter-engine
that referenced
this pull request
Apr 8, 2019
…timeline are not heap allocated. (flutter#8168) Verified that the tests fail on issues like flutter#8166. Unfortunately, there is no x-platform way to perform this check but this should gate incorrect traces being added to the engine.
RBogie
added a commit
to RBogie/flutter-engine
that referenced
this pull request
Apr 8, 2019
…nt (flutter#8166)" This reverts commit 26e3122.
RBogie
added a commit
to RBogie/flutter-engine
that referenced
this pull request
Apr 8, 2019
…nt (flutter#8166)" This reverts commit 26e3122.
RobertSun123
pushed a commit
to RobertSun123/engine
that referenced
this pull request
May 8, 2024
…timeline are not heap allocated. (#8168) Verified that the tests fail on issues like flutter/engine#8166. Unfortunately, there is no x-platform way to perform this check but this should gate incorrect traces being added to the engine.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dart no longer makes a copy of the label string when recording events.
See #8152