This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Roll src/third_party/dart 1bd36d694d..674fd0e060 (48 commits) #8152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I think the changelist for this PR is actually: That is based on the change of dart_rev: |
Member
|
dart-lang/sdk@9faca2fa68 seems to be the culprit of out of memory errors on flutter gallery benchmark: |
Contributor
|
@chinmaygarde Could the engine be dynamically allocating a trace label? |
Member
|
@GaryQian dart-lang/sdk@9faca2fa68 is also responsible for the timeouts in devicelab tests seen during the recent engine roll Flutter's scoped trace begin/end wrappers are passing a buffer from a std::string into Dart_TimelineEvent: This will be unsafe if Dart_TimelineEvent is no longer making a copy of the label. |
jason-simmons
added a commit
to jason-simmons/flutter_engine
that referenced
this pull request
Mar 14, 2019
Dart no longer makes a copy of the label string when recording events. See flutter#8152
jason-simmons
added a commit
that referenced
this pull request
Mar 14, 2019
Dart no longer makes a copy of the label string when recording events. See #8152
RBogie
pushed a commit
to RBogie/flutter-engine
that referenced
this pull request
Apr 8, 2019
674fd0e [vm runtime] Dynamically disable dual mapping of code on some platforms 0bd674c [VM-Runtime] set environment when creating detached process 578fdb0 Call becomeMap/becomeSet() in AstCloner. 382cd59 Update completion target tests for new map syntax 1db6647 Revert "Copy abi dills in create_sdk build rule" a39833d Reland "Reland "[VM runtime] Dual mapping of executable pages."" 49a0502 Copy abi dills in create_sdk build rule 23eb57c Revert "[vm/ffi] Support Windows 64 bit" 22c2c7f Sort declarations in build_mode.dart e2b5559 [infra] Use gclient.py to apply patches to bypass update_depot_tools f4b524c [vm] Extract reading of parameter covariance attributes 16e40ce Generate a diagnostic when a set or map literal is ambiguous b89d083 [infra] Only move coredump files on shards 7f812de [vm/ffi] Support Windows 64 bit 469da72 [vm] Put covariance attributes into Field flags 0908749 update hasFix lookup table bb7b5fc add missing fix tests 48a5c38 assist to convert to absolute imports b3927f6 [gardening] Mark tests that crash as crashing 2d6ddf2 Remove unnecessary override from PartialResolverVisitor ba3b9b3 Sort static_type_analyzer_test.dart 1edc6d4 [infra] Fix approve_results not erroring properly if tryjobs lack results. 1a196d4 [VM/AOT] Execute catch-entry moves in parallel (our AOT doesn't generate non-cyclic moves) 6a2aa92 Support pragma annotations through ir constants d3d0770 [VM/FrontendServer] Add 3head patch to frontend server after breaking API changes 016e317 Default parameters, more metadata, import dart:core. 853d388 [VM/AOT] Fixes incorrect deserialization of catch entry moves 3cf7d6a [tests] Changing expected cast errors to type errors for collections tests b87c44d Generate diagnostic for non-bool conditions in if elements 74395d9 Comment out test_import_short_absolute that fails on Windows. 7c15448 [vm] Decouple flow graph building of implicit getters and setters from kernel reading 57f4da3 [vm, gc] The mutator's TLAB and the interpreter's lookup cache must be visited even if the mutator is unscheduled. 15842d4 Build more import scopes, support for enums. f2029f5 Fix type inference of map/set literals when the context is a type parameter. 11b9481 [vm/frontend] Fix frontend_server_test on Windows. bfb30bf Fix a bug in the ConstantVerifier so that conditional elements are lazily verified ed1f956 Fix the abi dills download script 8f03ae0 [infra] Add --list-configurations option to test.dart. 9faca2f [vm] Document lifetime requirements of arguments to Dart_TimelineEvent. 295ea59 [vm] Give functions compiled through Dart_LoadCompilationTrace a non-zero usage counter. def0b21 [infra] Fix test.dart saying untested configurations don't exist. abd1854 Fix recording of map/literal context type. a8b3461 New summaries work snapshot. 9e7627b Re-land "Eliminate uses of old AST node types from pkg/analyzer/lib/src/summary" 210361a Move IgnoreInfo out of the task model code base 440b4cd Insert implicit casts when setting interface targets 567d552 [infra] Add versionchecker and debianpackage to test matrix 576c4c7 [CFE] Always clone subexpressions of unevaluated constants.
RBogie
pushed a commit
to RBogie/flutter-engine
that referenced
this pull request
Apr 8, 2019
…ter#8166) Dart no longer makes a copy of the label string when recording events. See flutter#8152
RobertSun123
pushed a commit
to RobertSun123/engine
that referenced
this pull request
May 8, 2024
Dart no longer makes a copy of the label string when recording events. See flutter/engine#8152
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
674fd0e [vm runtime] Dynamically disable dual mapping of code on some platforms
0bd674c [VM-Runtime] set environment when creating detached process
578fdb0 Call becomeMap/becomeSet() in AstCloner.
382cd59 Update completion target tests for new map syntax
1db6647 Revert "Copy abi dills in create_sdk build rule"
a39833d Reland "Reland "[VM runtime] Dual mapping of executable pages.""
49a0502 Copy abi dills in create_sdk build rule
23eb57c Revert "[vm/ffi] Support Windows 64 bit"
22c2c7f Sort declarations in build_mode.dart
e2b5559 [infra] Use gclient.py to apply patches to bypass update_depot_tools
f4b524c [vm] Extract reading of parameter covariance attributes
16e40ce Generate a diagnostic when a set or map literal is ambiguous
b89d083 [infra] Only move coredump files on shards
7f812de [vm/ffi] Support Windows 64 bit
469da72 [vm] Put covariance attributes into Field flags
0908749 update hasFix lookup table
bb7b5fc add missing fix tests
48a5c38 assist to convert to absolute imports
b3927f6 [gardening] Mark tests that crash as crashing
2d6ddf2 Remove unnecessary override from PartialResolverVisitor
ba3b9b3 Sort static_type_analyzer_test.dart
1edc6d4 [infra] Fix approve_results not erroring properly if tryjobs lack results.
1a196d4 [VM/AOT] Execute catch-entry moves in parallel (our AOT doesn't generate non-cyclic moves)
6a2aa92 Support pragma annotations through ir constants
d3d0770 [VM/FrontendServer] Add 3head patch to frontend server after breaking API changes
016e317 Default parameters, more metadata, import dart:core.
853d388 [VM/AOT] Fixes incorrect deserialization of catch entry moves
3cf7d6a [tests] Changing expected cast errors to type errors for collections tests
b87c44d Generate diagnostic for non-bool conditions in if elements
74395d9 Comment out test_import_short_absolute that fails on Windows.
7c15448 [vm] Decouple flow graph building of implicit getters and setters from kernel reading
57f4da3 [vm, gc] The mutator's TLAB and the interpreter's lookup cache must be visited even if the mutator is unscheduled.
15842d4 Build more import scopes, support for enums.
f2029f5 Fix type inference of map/set literals when the context is a type parameter.
11b9481 [vm/frontend] Fix frontend_server_test on Windows.
bfb30bf Fix a bug in the ConstantVerifier so that conditional elements are lazily verified
ed1f956 Fix the abi dills download script
8f03ae0 [infra] Add --list-configurations option to test.dart.
9faca2f [vm] Document lifetime requirements of arguments to Dart_TimelineEvent.
295ea59 [vm] Give functions compiled through Dart_LoadCompilationTrace a non-zero usage counter.
def0b21 [infra] Fix test.dart saying untested configurations don't exist.
abd1854 Fix recording of map/literal context type.
a8b3461 New summaries work snapshot.
9e7627b Re-land "Eliminate uses of old AST node types from pkg/analyzer/lib/src/summary"
210361a Move IgnoreInfo out of the task model code base
440b4cd Insert implicit casts when setting interface targets
567d552 [infra] Add versionchecker and debianpackage to test matrix
576c4c7 [CFE] Always clone subexpressions of unevaluated constants.