Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@chinmaygarde
Copy link
Member

Reverts #8094. This is breaking Windows.

…strument the raster cache. (#8094)"

This reverts commit 2a0d354.
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chinmaygarde
Copy link
Member Author

Landing on red because this fixes the red on Windows.

@chinmaygarde chinmaygarde merged commit bc90132 into master Mar 11, 2019
@chinmaygarde chinmaygarde deleted the revert-8094-counters branch March 11, 2019 22:09
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 12, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 12, 2019
engine-flutter-autoroll added a commit to flutter/flutter that referenced this pull request Mar 12, 2019
flutter/engine@56d8634...5ccee95

git log 56d8634..5ccee95 --no-merges --oneline
5ccee95 Roll src/third_party/skia e9c1ce89c005..c6d8781c4036 (29 commits) (flutter/engine#8123)
20165b3 Integrated AndroidTouchProcessor within the old FlutterView (flutter/engine#8095)
bc90132 Revert "Add support for trace counters with variable arguments and instrument the raster cache. (#8094)" (flutter/engine#8122)
2a0d354 Add support for trace counters with variable arguments and instrument the raster cache. (flutter/engine#8094)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff ([email protected]), and stop
the roller if necessary.
chinmaygarde added a commit to chinmaygarde/flutter_engine that referenced this pull request Mar 12, 2019
…s and instrument the raster cache. (flutter#8094)" (flutter#8122)"

This reverts commit bc90132.
RBogie pushed a commit to RBogie/flutter-engine that referenced this pull request Apr 8, 2019
RBogie added a commit to RBogie/flutter-engine that referenced this pull request Apr 8, 2019
…s and instrument the raster cache. (flutter#8094)" (flutter#8122)"

This reverts commit 63f7f26.
RBogie added a commit to RBogie/flutter-engine that referenced this pull request Apr 8, 2019
…s and instrument the raster cache. (flutter#8094)" (flutter#8122)"

This reverts commit 63f7f26.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants