Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@jonahwilliams
Copy link
Contributor

@jonahwilliams jonahwilliams commented Mar 10, 2019

Adds a new structure for libraries.json and flutter web sdk to support sharing source files with currently shipped dart-sdk, and serving projects via dartdevc by including a dartdevc sdk with dart:ui included.

@jonahwilliams jonahwilliams marked this pull request as ready for review March 17, 2019 22:59
@jonahwilliams jonahwilliams changed the title Compile dartdevc kernel sdk including stub ui Support dartdevc, dart2js with shared source files, dartdevc sdk Mar 17, 2019
Copy link
Contributor

@yjbanov yjbanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jonahwilliams jonahwilliams merged commit 048d70b into flutter:master Mar 18, 2019
@jonahwilliams jonahwilliams deleted the web_sdk branch March 18, 2019 18:58
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 18, 2019
engine-flutter-autoroll added a commit to flutter/flutter that referenced this pull request Mar 18, 2019
flutter/engine@e75f6de...048d70b

git log e75f6de..048d70b --no-merges --oneline
048d70b Support dartdevc, dart2js with shared source files, dartdevc sdk (flutter/engine#8105)
e0782de Roll src/third_party/skia 576b2a5596bc..2c043c288169 (2 commits) (flutter/engine#8200)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff ([email protected]), and stop
the roller if necessary.
liyuqian added a commit to liyuqian/flutter that referenced this pull request Mar 18, 2019
Need this manual roll because of golden changes.

flutter/engine@5088735e5 Clip to clip_rect instead of paint bounds (flutter/engine#8183)
flutter/engine@8818a6c41 Roll src/third_party/skia 2c043c288169..4a522b7e916c (3 commits) (flutter/engine#8201)
flutter/engine@048d70bc0 Support dartdevc, dart2js with shared source files, dartdevc sdk (flutter/engine#8105)
flutter/engine@e0782dec7 Roll src/third_party/skia 576b2a5596bc..2c043c288169 (2 commits) (flutter/engine#8200)
liyuqian added a commit to flutter/flutter that referenced this pull request Mar 19, 2019
Need this manual roll because of golden changes.

flutter/engine@5088735e5 Clip to clip_rect instead of paint bounds (flutter/engine#8183)
flutter/engine@8818a6c41 Roll src/third_party/skia 2c043c288169..4a522b7e916c (3 commits) (flutter/engine#8201)
flutter/engine@048d70bc0 Support dartdevc, dart2js with shared source files, dartdevc sdk (flutter/engine#8105)
flutter/engine@e0782dec7 Roll src/third_party/skia 576b2a5596bc..2c043c288169 (2 commits) (flutter/engine#8200)
RBogie pushed a commit to RBogie/flutter-engine that referenced this pull request Apr 8, 2019
RBogie added a commit to RBogie/flutter-engine that referenced this pull request Apr 8, 2019
RBogie added a commit to RBogie/flutter-engine that referenced this pull request Apr 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants