This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Move android_sdk_downloader so I can more easily deprecate it #8084
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jason-simmons
approved these changes
Mar 8, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 8, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Mar 9, 2019
flutter/engine@6031407...87edd94 git log 6031407..87edd94 --no-merges --oneline 87edd94 Add read-only persistent cache (flutter/engine#8049) 4c94049 Move android_sdk_downloader so I can more easily deprecate it (flutter/engine#8084) 7cbd9d8 Roll src/third_party/skia 3d1b941f3a7d..bea1f94f341e (7 commits) (flutter/engine#8083) 260669c Fix deleting text when the last character is some special characters on IOS (flutter/engine#7982) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff ([email protected]), and stop the roller if necessary.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The plan is to start using CIPD packages for this stuff, which gclient/depot_tools more natively supports (and will allow us to keep using versions of the NDK even if it's pulled from the Android repo).
I'd like to break that up into an NDK piece (Which is more critical) and an SDK piece.
Having the tool in the engine repo will allow me to iterate on that more easily. I'll open a separate PR to remove it from buildroot.
/cc @cbracken @jason-simmons @chinmaygarde