This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Fix text.dart height docs #8079
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/ui/text.dart
Outdated
| /// | ||
| /// * `fontFamily`: The name of the font to use when painting the text (e.g., | ||
| /// Roboto). | ||
| /// * `fontFamily`: The fallback name of the font to use when painting the text |
Member
There was a problem hiding this comment.
is "fallback" necessary here?
Contributor
Author
There was a problem hiding this comment.
This is not used unless the there is no textstyle attached to the span.
Member
There was a problem hiding this comment.
I wonder if it might be clearer to state this as: The name of the font to apply when painting the text, in the absence of a ``textStyle`` being attached to the span.
Contributor
Author
There was a problem hiding this comment.
That sounds great!
jamesderlin
reviewed
Mar 7, 2019
Contributor
jamesderlin
left a comment
jamesderlin
left a comment
There was a problem hiding this comment.
Did you want to do anything about the "multiple of the font size" thing that there was a complaint about?
Contributor
Author
|
Ahh good point, might as well change it with this patch. It will probably still need to be changed in an equivalent framework side patch also. |
mdebbar
reviewed
Mar 8, 2019
Contributor
mdebbar
left a comment
mdebbar
left a comment
There was a problem hiding this comment.
There are 2 more mentions of lineHeight on line 813 and 817 (I can't add a comment on those lines). Do they need to be updated too?
Contributor
Author
|
The same changes should be mirrored in stub_ui also. |
mdebbar
approved these changes
Mar 12, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 13, 2019
willlarche
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 13, 2019
* 59715b7 Disable build_ios task due to lack of credits. (flutter/engine#8150) * 9f50dae Look up ICU symbols based on the path to libflutter.so as a fallback (flutter/engine#8139) * 8b1a299 [Skia] Rollback Skia to 29d5dec9a0783a033b921dc483fb98d565d684f6 (flutter/engine#8151) * 8be2aca Roll src/third_party/dart 1bd36d694d..674fd0e060 (48 commits) #8152 * 2e42703 Revert "Disable build_ios task due to lack of credits. (#8150)" (flutter/engine#8153) * 2daebeb Fix text.dart height docs (flutter/engine#8079) * b1b388f Encode scroll motion events in the Android touch processor (flutter/engine#8149)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 14, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 14, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 14, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 14, 2019
This was referenced Mar 14, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 14, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 14, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 14, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 14, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 14, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 14, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 15, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 15, 2019
RBogie
pushed a commit
to RBogie/flutter-engine
that referenced
this pull request
Apr 8, 2019
RBogie
added a commit
to RBogie/flutter-engine
that referenced
this pull request
Apr 8, 2019
This reverts commit 69c83ce.
RBogie
added a commit
to RBogie/flutter-engine
that referenced
this pull request
Apr 8, 2019
This reverts commit 69c83ce.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docs did not properly reflect the renaming of lineHeight- > height and the introduction of strut.