This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Fix caret being at left edge when newline pressed on centered text #7875
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Adding tests... |
jason-simmons
approved these changes
Feb 19, 2019
Member
|
One of the tests looks like it's failing on Cirrus |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 20, 2019
dnfield
added a commit
to flutter/flutter
that referenced
this pull request
Feb 20, 2019
flutter/engine@6d7eb5218 Revert "Android embedding refactor pr3 add remaining systemchannels (flutter/engine#7874)" (flutter/engine#7886) flutter/engine@dad6ec01c Correct onAccessibilityFeaturesChanged docs (flutter/engine#7883) flutter/engine@fc1a68ea1 Roll src/third_party/skia e0a6a048bc4a..7738736f9622 (4 commits) (flutter/engine#7884) flutter/engine@a150cc125 Fix minor typos in accessibility action docs (flutter/engine#7882) flutter/engine@bf1654450 Roll src/third_party/skia 249a25730521..e0a6a048bc4a (2 commits) (flutter/engine#7881) flutter/engine@d60ef0c36 Roll src/third_party/skia ce62dec02293..249a25730521 (15 commits) (flutter/engine#7879) flutter/engine@1263d28ab Fix caret being at left edge when newline pressed on centered text (flutter/engine#7875)
dnfield
added a commit
to flutter/flutter
that referenced
this pull request
Feb 20, 2019
flutter/engine@6d7eb5218 Revert "Android embedding refactor pr3 add remaining systemchannels (flutter/engine#7874)" (flutter/engine#7886) flutter/engine@dad6ec01c Correct onAccessibilityFeaturesChanged docs (flutter/engine#7883) flutter/engine@fc1a68ea1 Roll src/third_party/skia e0a6a048bc4a..7738736f9622 (4 commits) (flutter/engine#7884) flutter/engine@a150cc125 Fix minor typos in accessibility action docs (flutter/engine#7882) flutter/engine@bf1654450 Roll src/third_party/skia 249a25730521..e0a6a048bc4a (2 commits) (flutter/engine#7881) flutter/engine@d60ef0c36 Roll src/third_party/skia ce62dec02293..249a25730521 (15 commits) (flutter/engine#7879) flutter/engine@1263d28ab Fix caret being at left edge when newline pressed on centered text (flutter/engine#7875)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#27867