This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Create stubbed dart:ui implementation, dart2js libraries file, copy rule #7694
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
February 4, 2019 16:32
yjbanov
approved these changes
Feb 6, 2019
Contributor
|
I have not reviewed the stub code in detail as it is a straight copy of
|
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 6, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Feb 6, 2019
flutter/engine@cc27caf...3c118b6 git log cc27caf..3c118b6 --no-merges --oneline 3c118b6 Disable wuff on Windows (flutter/engine#7713) ebd18a2 Roll src/third_party/skia 37b7d41d01cb..455c74797b46 (8 commits) (flutter/engine#7712) 00e0640 Roll src/third_party/skia 3abdd7a90e45..37b7d41d01cb (2 commits) (flutter/engine#7711) 47e4e15 Roll src/third_party/dart c26bf54391..631c550ff9 (1 commits) 631c550ff9 Extract and migrate ExitDetector and its tests. c6376e5 Roll src/third_party/skia fac1e367f428..3abdd7a90e45 (1 commits) (flutter/engine#7709) 9b33323 Roll src/third_party/skia b26b8998fa9c..fac1e367f428 (6 commits) (flutter/engine#7707) 83d8529 Roll src/third_party/dart 5823be65af..c26bf54391 (29 commits) c26bf54391 Add InheritanceManager2 APIs to access inherited interface/class maps. e83b309354 [vm] Remove single-stepping from PRODUCT 0a2de9238b Extract importLibraryElement() implementation, make it less pessimistic. ae72248770 Encapsulate dartfix name/description of each fix ceb7b89df1 Remove a fix that has now been replaced by an assist 336969538c [vm/bytecode] Revise representation of types, constants and calls in bytecode b5eb7d463e Extract and migrate ErrorReporter tests. db9e3f21c9 remove InconsistentAnalysisException guard code from dartfix 9afb65d7f1 [vm] Fixes for recursive class loading d6caaeeebb [vm] Have Dart_TimelineEvent respect SUPPORT_TIMELINE instead of PRODUCT. d236dca9d9 Add 'offset' to 'getSuggestionDetails'. 3395550962 Provisional nullability migration API in analysis_server. 0637a860f0 Revert "Create new template for breaking changes" 2d6afa04cb Create new template for breaking changes 102f3074d5 Enhance assist to convert invocation of LinkedHashMap to a map literal 3c1ffd23ba remove unneeded override 8d5b5bba41 Allow for non-function types in alias builders. 824598b17d Rename files related to type aliases d7d195283a Add missing type arguments 6efbd07145 Rename FunctionTypeAliasBuilder to TypeAliasBuilder f45d103d67 Finish implementing IsTypeParameterSubtypeOf 7213306aad [VM/Compiler] Do not use unboxed doubles if target CPU does not support VFP 52bd3d9159 Complain about use of deprecated members 0828d2c786 [Fasta] Implement exact types for Set literals 4b28312282 [vm] Remove reference to vm/flag_list.h in runtime/bin/main.cc. c6556dc1a3 [package:js] draft proposal to improve JS interop, see #35084 798123ddb7 add lint associations b59d5a2be9 [vm] Relax assertion about duplicated direct implementors 1f638607c2 Rework the ConstraintVariable.or constructor. 75d7f24 Roll src/third_party/skia 0ec8ec27b81c..b26b8998fa9c (11 commits) (flutter/engine#7705) affa62a Create stubbed dart:ui implementation, dart2js libraries file, copy rule (flutter/engine#7694) 68d9ac4 Revert "Lower the threshold to raster cache pictures (#7687)" (flutter/engine#7701) 3dbc375 Update snapshot build rules to generate .o files instead of .S files on Windows (flutter/engine#7702) 351f5a3 Use the Wuffs GIF decoder (flutter/engine#7658) 0b014c4 Roll src/third_party/skia 5f5e1d57a4ce..0ec8ec27b81c (6 commits) (flutter/engine#7703) 2f87713 Revert "Disable the persistent cache (#6835)" (flutter/engine#7689) 2c25936 Roll src/third_party/skia 2462ca36c800..5f5e1d57a4ce (7 commits) (flutter/engine#7699) ac003c4 Roll src/third_party/skia 0783aca7ba31..2462ca36c800 (2 commits) (flutter/engine#7698) e26eab8 Roll src/third_party/skia bb60677d5244..0783aca7ba31 (1 commits) (flutter/engine#7697) ad52541 Roll src/third_party/skia 2d35a1c87553..bb60677d5244 (1 commits) (flutter/engine#7696) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff ([email protected]), and stop the roller if necessary.
kangwang1988
pushed a commit
to XianyuTech/flutter
that referenced
this pull request
Feb 12, 2019
flutter/engine@cc27caf...3c118b6 git log cc27caf..3c118b6 --no-merges --oneline 3c118b6 Disable wuff on Windows (flutter/engine#7713) ebd18a2 Roll src/third_party/skia 37b7d41d01cb..455c74797b46 (8 commits) (flutter/engine#7712) 00e0640 Roll src/third_party/skia 3abdd7a90e45..37b7d41d01cb (2 commits) (flutter/engine#7711) 47e4e15 Roll src/third_party/dart c26bf54391..631c550ff9 (1 commits) 631c550ff9 Extract and migrate ExitDetector and its tests. c6376e5 Roll src/third_party/skia fac1e367f428..3abdd7a90e45 (1 commits) (flutter/engine#7709) 9b33323 Roll src/third_party/skia b26b8998fa9c..fac1e367f428 (6 commits) (flutter/engine#7707) 83d8529 Roll src/third_party/dart 5823be65af..c26bf54391 (29 commits) c26bf54391 Add InheritanceManager2 APIs to access inherited interface/class maps. e83b309354 [vm] Remove single-stepping from PRODUCT 0a2de9238b Extract importLibraryElement() implementation, make it less pessimistic. ae72248770 Encapsulate dartfix name/description of each fix ceb7b89df1 Remove a fix that has now been replaced by an assist 336969538c [vm/bytecode] Revise representation of types, constants and calls in bytecode b5eb7d463e Extract and migrate ErrorReporter tests. db9e3f21c9 remove InconsistentAnalysisException guard code from dartfix 9afb65d7f1 [vm] Fixes for recursive class loading d6caaeeebb [vm] Have Dart_TimelineEvent respect SUPPORT_TIMELINE instead of PRODUCT. d236dca9d9 Add &flutter#39;offset&flutter#39; to &flutter#39;getSuggestionDetails&flutter#39;. 3395550962 Provisional nullability migration API in analysis_server. 0637a860f0 Revert &flutter#34;Create new template for breaking changes&flutter#34; 2d6afa04cb Create new template for breaking changes 102f3074d5 Enhance assist to convert invocation of LinkedHashMap to a map literal 3c1ffd23ba remove unneeded override 8d5b5bba41 Allow for non-function types in alias builders. 824598b17d Rename files related to type aliases d7d195283a Add missing type arguments 6efbd07145 Rename FunctionTypeAliasBuilder to TypeAliasBuilder f45d103d67 Finish implementing IsTypeParameterSubtypeOf 7213306aad [VM/Compiler] Do not use unboxed doubles if target CPU does not support VFP 52bd3d9159 Complain about use of deprecated members 0828d2c786 [Fasta] Implement exact types for Set literals 4b28312282 [vm] Remove reference to vm/flag_list.h in runtime/bin/main.cc. c6556dc1a3 [package:js] draft proposal to improve JS interop, see flutter#35084 798123ddb7 add lint associations b59d5a2be9 [vm] Relax assertion about duplicated direct implementors 1f638607c2 Rework the ConstraintVariable.or constructor. 75d7f24 Roll src/third_party/skia 0ec8ec27b81c..b26b8998fa9c (11 commits) (flutter/engine#7705) affa62a Create stubbed dart:ui implementation, dart2js libraries file, copy rule (flutter/engine#7694) 68d9ac4 Revert &flutter#34;Lower the threshold to raster cache pictures (flutter#7687)&flutter#34; (flutter/engine#7701) 3dbc375 Update snapshot build rules to generate .o files instead of .S files on Windows (flutter/engine#7702) 351f5a3 Use the Wuffs GIF decoder (flutter/engine#7658) 0b014c4 Roll src/third_party/skia 5f5e1d57a4ce..0ec8ec27b81c (6 commits) (flutter/engine#7703) 2f87713 Revert &flutter#34;Disable the persistent cache (flutter#6835)&flutter#34; (flutter/engine#7689) 2c25936 Roll src/third_party/skia 2462ca36c800..5f5e1d57a4ce (7 commits) (flutter/engine#7699) ac003c4 Roll src/third_party/skia 0783aca7ba31..2462ca36c800 (2 commits) (flutter/engine#7698) e26eab8 Roll src/third_party/skia bb60677d5244..0783aca7ba31 (1 commits) (flutter/engine#7697) ad52541 Roll src/third_party/skia 2d35a1c87553..bb60677d5244 (1 commits) (flutter/engine#7696) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff ([email protected]), and stop the roller if necessary.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates an implementation of dart:ui which does not reference
nativeor nativewrapper classes that can be compiled via dart2js.Adds a libraries file for dart2js --libraries-spec argument, and a gn rule to copy them to the flutter_patched_sdk directory.
The stub library might bitrot, but it is only necessary as a stopgap to develop tooling.