This repository was archived by the owner on Feb 25, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6k
Configure the embedder for AOT in "profile" and "release" runtime modes. #7533
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jason-simmons
approved these changes
Jan 18, 2019
cbracken
approved these changes
Jan 18, 2019
Member
cbracken
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 18, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 18, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 19, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 19, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 19, 2019
dnfield
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 19, 2019
* d470fc6 Roll src/third_party/skia 31972f889641..57263c2e0ccd (3 commits) (flutter/engine#7529) * 11aa5e6 Roll src/third_party/dart da09945643..ac1bf656c4 (22 commits) (flutter/engine#7527) * a0b4d6b Configure the embedder in AOT in "profile" and "release" runtime modes. (flutter/engine#7533) * 2cf1181 Roll src/third_party/dart ac1bf656c4..2e5453ddb4 (42 commits) 2e5453ddb4 [ VM ] Updated licenses to match other licenses in project 3d71abcada Prepare to publish a new version of the analyzer_plugin package with an updated dependency on analyzer ebf319b64b Clean up some lingering references to type propogation be47aad327 [VM/Compiler/AOT] Bare instructions 9: Improve write barrier on ARM/ARM64/X64 10f63f806d [gardening] Mark io/stdout_stderr_non_blocking_test flaky on x64 8b214f4d72 Restore type parser from reify project 65dde13f1b Don't check formatting of Front-End test cases 53217e6eb1 [kernel] Add ability to (de)serialize DirectMethodInvocation 5048889c54 [kernel] Add ability to (de)serialize StaticInvocation 7ea2dfad20 [kernel] Add ability to (de)serialize DirectPropertySet 50c06c55ba [kernel] Add ability to (de)serialize DirectPropertyGet 793fbc0d4a [kernel] Add ability to (de)serialize StaticSet 581af6eb56 [co19] DEPS and status file updated b0017d758c Refer to correct locations in SDK (and other dill files) da6938a5b2 After some more `git cl uploads`, this fixes a bunch of little problems in the spec that we have noted over time. c9a55b437a [Kernel] Remove the dedicated fromEnvironment constants 1a0367a373 Create test which demonstrates issues 35558 and 35559 6205d7e82c [kernel] Add ability to (de)serialize StaticGet e529988474 [kernel] Rename ScopedReference to ScopedUse f437fa02c2 [kernel] Nest *Environment into *State for (de)serialization 0dea413d94 Tests for reachability, fix for try/finally. e3302cdb8f Follow-up to storing problems in the ast dd04c374b8 [vm,dart:io] On Linux, Android, and Fuchsia the getsockopt parameter is incorrect. e64428a839 Revert "[vm] Cleanup Dart_Get/Set/HasStickyError API and use isolate's sticky error only as a backup for thread's sticky error" 324718fadd [vm] Revert "Restore TLABs." 5a607755b2 [ VM / dart:io ] Fixed issue where writing to a socket after it has been closed would raise SIGPIPE and crash the process. 6b5e8603d5 Reland "[vm/compiler] AOT inline heuristics improvements" 06a1e6e9e3 [vm] Enable timeline on Fuchsia even in product mode. 2faab1d4c0 Update AstBuilder to build spread collection AST structures b10f179608 [vm] Cleanup Dart_Get/Set/HasStickyError API and use isolate's sticky error only as a backup for thread's sticky error 5b1daaac6c Exposes a thin layer over getsockopt/setsockopt for supported platforms. c701e76506 [vm/compiler] handle non-nullable null situation better b692a6d183 Improvements for flow analysis. fc62cf0373 [infra] Fix co19 git URL in DEPS e7bd3edc9f [vm] Assert callback state for all Dart_Set*ReturnValue, take 2. ddce2824fa Add more spread collection fasta test cases 6639cbd6c3 Add AstBuilder spread-collections and control-flow-collections flags 1020a22290 [dart2js] Do more native method inlining f353719b08 Ignore unnecessary_cast hint. 3513f872ce Extract DartFileEditBuilder.importLibrary() into separate file. 46080dd886 Update DEPS to check out co19 tests from dart.googlesource.com ca2db2ad53 [VM/Compiler/AOT] Bare instructions 8: Improve AOT code by using pc-relative calls * d5d6bd2 Fix suspicious typo "painted" to "paint" (flutter/engine#7530) * d89f3b0 Roll src/third_party/skia 57263c2e0ccd..5c7a3ac0e214 (15 commits) (flutter/engine#7536) * 75cfebd Roll buildroot and update method of getting android SDK and support libs (flutter/engine#7284) * 898b4f8 Allow embedders to specify AOT snapshot buffers. (flutter/engine#7538)
kangwang1988
pushed a commit
to XianyuTech/flutter
that referenced
this pull request
Feb 12, 2019
* d470fc6 Roll src/third_party/skia 31972f889641..57263c2e0ccd (3 commits) (flutter/engine#7529) * 11aa5e6 Roll src/third_party/dart da09945643..ac1bf656c4 (22 commits) (flutter/engine#7527) * a0b4d6b Configure the embedder in AOT in "profile" and "release" runtime modes. (flutter/engine#7533) * 2cf1181 Roll src/third_party/dart ac1bf656c4..2e5453ddb4 (42 commits) 2e5453ddb4 [ VM ] Updated licenses to match other licenses in project 3d71abcada Prepare to publish a new version of the analyzer_plugin package with an updated dependency on analyzer ebf319b64b Clean up some lingering references to type propogation be47aad327 [VM/Compiler/AOT] Bare instructions 9: Improve write barrier on ARM/ARM64/X64 10f63f806d [gardening] Mark io/stdout_stderr_non_blocking_test flaky on x64 8b214f4d72 Restore type parser from reify project 65dde13f1b Don't check formatting of Front-End test cases 53217e6eb1 [kernel] Add ability to (de)serialize DirectMethodInvocation 5048889c54 [kernel] Add ability to (de)serialize StaticInvocation 7ea2dfad20 [kernel] Add ability to (de)serialize DirectPropertySet 50c06c55ba [kernel] Add ability to (de)serialize DirectPropertyGet 793fbc0d4a [kernel] Add ability to (de)serialize StaticSet 581af6eb56 [co19] DEPS and status file updated b0017d758c Refer to correct locations in SDK (and other dill files) da6938a5b2 After some more `git cl uploads`, this fixes a bunch of little problems in the spec that we have noted over time. c9a55b437a [Kernel] Remove the dedicated fromEnvironment constants 1a0367a373 Create test which demonstrates issues 35558 and 35559 6205d7e82c [kernel] Add ability to (de)serialize StaticGet e529988474 [kernel] Rename ScopedReference to ScopedUse f437fa02c2 [kernel] Nest *Environment into *State for (de)serialization 0dea413d94 Tests for reachability, fix for try/finally. e3302cdb8f Follow-up to storing problems in the ast dd04c374b8 [vm,dart:io] On Linux, Android, and Fuchsia the getsockopt parameter is incorrect. e64428a839 Revert "[vm] Cleanup Dart_Get/Set/HasStickyError API and use isolate's sticky error only as a backup for thread's sticky error" 324718fadd [vm] Revert "Restore TLABs." 5a607755b2 [ VM / dart:io ] Fixed issue where writing to a socket after it has been closed would raise SIGPIPE and crash the process. 6b5e8603d5 Reland "[vm/compiler] AOT inline heuristics improvements" 06a1e6e9e3 [vm] Enable timeline on Fuchsia even in product mode. 2faab1d4c0 Update AstBuilder to build spread collection AST structures b10f179608 [vm] Cleanup Dart_Get/Set/HasStickyError API and use isolate's sticky error only as a backup for thread's sticky error 5b1daaac6c Exposes a thin layer over getsockopt/setsockopt for supported platforms. c701e76506 [vm/compiler] handle non-nullable null situation better b692a6d183 Improvements for flow analysis. fc62cf0373 [infra] Fix co19 git URL in DEPS e7bd3edc9f [vm] Assert callback state for all Dart_Set*ReturnValue, take 2. ddce2824fa Add more spread collection fasta test cases 6639cbd6c3 Add AstBuilder spread-collections and control-flow-collections flags 1020a22290 [dart2js] Do more native method inlining f353719b08 Ignore unnecessary_cast hint. 3513f872ce Extract DartFileEditBuilder.importLibrary() into separate file. 46080dd886 Update DEPS to check out co19 tests from dart.googlesource.com ca2db2ad53 [VM/Compiler/AOT] Bare instructions 8: Improve AOT code by using pc-relative calls * d5d6bd2 Fix suspicious typo "painted" to "paint" (flutter/engine#7530) * d89f3b0 Roll src/third_party/skia 57263c2e0ccd..5c7a3ac0e214 (15 commits) (flutter/engine#7536) * 75cfebd Roll buildroot and update method of getting android SDK and support libs (flutter/engine#7284) * 898b4f8 Allow embedders to specify AOT snapshot buffers. (flutter/engine#7538)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.