This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Support custom kernel blob path in embedder API #7515
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinmaygarde
approved these changes
Jan 17, 2019
Member
chinmaygarde
left a comment
chinmaygarde
left a comment
There was a problem hiding this comment.
Nit about the documentation of the default. LGTM otherwise.
Adds support to the embedder API for the user to specify an arbitrarily-named kernel blob path within the asset path. Updates the test_fixtures rule to support a custom kernel output file name.
chinmaygarde
suggested changes
Jan 17, 2019
Member
chinmaygarde
left a comment
chinmaygarde
left a comment
There was a problem hiding this comment.
On second thought, maybe we should make the embedders give us a mapping. The engine only cares about the blob, not how embedders package the same in their applications.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support to the embedder API for the user to specify an
arbitrarily-named kernel blob path within the asset path.
Updates the test_fixtures rule to support a custom kernel output file
name.