Wrap the user entrypoint function in a zone with native exception callback. #7512

chinmaygarde · 2019-01-16T23:22:29Z

This is similar to how we recommend users attach uncaught exception handlers in their code for reporting purposes. The same limitations as that approach apply here as well.

…lback.

chinmaygarde · 2019-01-16T23:23:02Z

xref FL-154

rmacnak-google · 2019-01-16T23:40:19Z

lib/ui/hooks.dart

+// ignore: unused_element
+void _runMainZoned(Function startMainIsolateFunction, Function userMainFunction) {
+  startMainIsolateFunction((){
+    runZoned<Future<void>>(() async {


Does this closure need to be async?
runZoned(() { ... ?

I dont think so.

rmacnak-google

lgtm

rmacnak-google · 2019-01-16T23:51:05Z

runtime/dart_isolate.cc

+    FML_LOG(ERROR) << "Could not resolve main entrypoint trampolines.";
    return false;
  }



You could invoke runMainZoned directly instead of closurizing first. Instead of

Dart_Invoke(Dart_GetField(dart:ui, "_runMainZoned"), a, b)

do

Dart_Invoke(dart:ui, "_runMainZoned", a, b)

I was attempting to use the tonic wrappers for this.

This caused breakage: note that @pragma('vm:entry-point') does not permit closurization of the static methods - it only permits invocation. Thus AOT compiler retained _runMainZoned but not get:_runMainZoned which is necessary for closurization. This subsequently crashes in AOT mode because runtime can't create get:_runMainZoned dynamically.

I am going to revert this PR for now to unbreak the engine.

I have also bumped priority of dart-lang/sdk#35369 - which should catch this sort of issues in the JIT mode as well, not just in AOT mode.

/cc @sjindel-google

…tion callback. (flutter/engine#7512)

flutter/engine@3c0aa91...25559ed git log 3c0aa91..25559ed --no-merges --oneline 25559ed Wrap the user entrypoint function in a zone with native exception callback. (flutter/engine#7512) 1b0d09b Roll src/third_party/dart f701e11756..700254996f (5 commits) 700254996f [ Observatory / Dartium ] Updated observatory documentation and tests to remove references to Dartium. 78abb98ee7 [vm/bytecode] Fix AST removal for package-split kernel files with bytecode 0075b58bb8 CHANGELOG entry for DEPRECATED_MEMBER_USE split a5f102a7d1 Analyzer: first pass at reporting unchecked nullable value usage. a10ddca1b1 [ VM / Service ] Allow for `profile_period` flag to be set via the service protocol e7ade51 Remove unused headers (flutter/engine#7511) 369b4db Roll src/third_party/skia 1374c85fbf53..081e6f375497 (6 commits) (flutter/engine#7510) 366d44e Roll src/third_party/dart 9b5eabdaca..f701e11756 (10 commits) f701e11756 [ VM / Debugger ] Fix issue where a 'Step' command issued when there's no stack caused a crash. c5bfccc6fb Make downloading the LSP spec a flag and commit the version parsed locally dbeec3bbf3 Fix formatting in generated LSP file header bfe15d87d8 Fix LSP exceptions serializing ResponseErrors with Uris 7984dc4fcc Prepare to publish analyzer version 0.34.2. 4b1b2f9176 Switch LSP formatter to not fetch resolved ASTs that aren't used 5ce5d697da Implement LSP code folding b47524d5b0 Ensure all unhandled exceptions are recorded on the server 8ba2de2344 Sort context for conflicting inherited members 215f6620e7 [Kernel] Signal errors on static fields in constant contexts 1e93a8e Deprecate FlutterProjectArgs.main_path, packages_path (flutter/engine#7497) b058920 Edit the bundleid so that it conform to UIT specifications. (flutter/engine#7503) 32c9ae6 Roll src/third_party/skia 2c379d8e27e6..1374c85fbf53 (4 commits) (flutter/engine#7508) 96d10b1 Roll src/third_party/dart 492df72739..9b5eabdaca (8 commits) 9b5eabdaca Fix crash in color support a533753bec Remove --fast-startup flag support from testing scripts and status files 5f10aed19c [Kernel] Don't print static fields in instance constants bdb51e2837 Improve input path handling and remove extra schemas. 0604110806 Reduce expectations on thrown exception 966e007b63 Pass CallStructure on dynamic and static use in ResolutionWorldBuilder 3e7801294e Remove unneeded code in OrderedTypeSet 8a91948c03 [Kernel] Properly signal compilation errors for constants 7709840 Roll src/third_party/skia a8694cc150a1..2c379d8e27e6 (1 commits) (flutter/engine#7506) 046ddc6 Roll src/third_party/skia 47b7cd9a6baf..a8694cc150a1 (1 commits) (flutter/engine#7504) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff ([email protected]), and stop the roller if necessary.

@pragma

…tion callback. (flutter#7512)" This reverts commit 25559ed. Reason for revert: broken in AOT mode. @pragma('vm:entry-point') placed on a function only instructs the compiler to retain the function itself, but does not tell compiler to generate and retain tear-off for this function. In this PR _runMainZoned was marked as an entry-point but C++ code was trying to tear it off and use a closure, instead of invoking it directly, which is not supported.

…tion callback. (flutter/engine#7512)

@pragma

…tion callback. (#7512)" (#7522) This reverts commit 25559ed. Reason for revert: broken in AOT mode. @pragma('vm:entry-point') placed on a function only instructs the compiler to retain the function itself, but does not tell compiler to generate and retain tear-off for this function. In this PR _runMainZoned was marked as an entry-point but C++ code was trying to tear it off and use a closure, instead of invoking it directly, which is not supported.

…tion callback. (flutter/engine#7512)

d470fc6 Roll src/third_party/skia 31972f889641..57263c2e0ccd (3 commits) (flutter/engine#7529) 4acfced Ensure the ResourceContext is not ripped out from under dart (flutter/engine#7528) 270e9a7 Roll src/third_party/skia a4e46804946c..31972f889641 (8 commits) (flutter/engine#7526) e984372 Roll src/third_party/skia 33b4b4908b7a..a4e46804946c (1 commits) (flutter/engine#7524) 4c135c2 Revert "Wrap the user entrypoint function in a zone with native exception callback. (flutter/engine#7512)" (flutter/engine#7522) 0a080a1 Roll src/third_party/dart 700254996f..da09945643 (14 commits) da09945643 Update dartfix pubspec before publishing b81c1b2095 Parse spread collections in map literals 1b0d93366d Add list literal spread collection fasta test cases 6c2ea4936a Clean up several deprecation hints 07f95e7761 Revert "[vm] Enable timeline on Fuchsia even in product mode." 9cdce03e16 [dart2js] Improve null receiver guard removal near JS code c3599a9d8c Revert "[vm, isolate] Fix length truncation in message snapshots." 95e10c336f Revert "[vm] Assert callback state for all Dart_Set*ReturnValue." 3f7b371f2c [vm] Enable timeline on Fuchsia even in product mode. 4b22195ea1 [vm, isolate] Fix length truncation in message snapshots. a353b1172a [vm, compiler] Remove TAG_IC_DATA, which has since been subsumed by RebindRule. ca12afec50 [vm] Assert callback state for all Dart_Set*ReturnValue. 2028006a25 [Observatory] Updated Dart icon to new colour scheme 84273b9f36 Improvements for flow analysis. fff5377 Roll src/third_party/skia 25b9f192ed8c..33b4b4908b7a (1 commits) (flutter/engine#7520) a58cc39 Roll src/third_party/skia 1ce80fb351a2..25b9f192ed8c (5 commits) (flutter/engine#7517) 52e0e9d Roll src/third_party/skia 081e6f375497..1ce80fb351a2 (12 commits) (flutter/engine#7514) 25559ed Wrap the user entrypoint function in a zone with native exception callback. (flutter/engine#7512) 1b0d09b Roll src/third_party/dart f701e11756..700254996f (5 commits) 700254996f [ Observatory / Dartium ] Updated observatory documentation and tests to remove references to Dartium. 78abb98ee7 [vm/bytecode] Fix AST removal for package-split kernel files with bytecode 0075b58bb8 CHANGELOG entry for DEPRECATED_MEMBER_USE split a5f102a7d1 Analyzer: first pass at reporting unchecked nullable value usage. a10ddca1b1 [ VM / Service ] Allow for `profile_period` flag to be set via the service protocol e7ade51 Remove unused headers (flutter/engine#7511) 369b4db Roll src/third_party/skia 1374c85fbf53..081e6f375497 (6 commits) (flutter/engine#7510) 366d44e Roll src/third_party/dart 9b5eabdaca..f701e11756 (10 commits) f701e11756 [ VM / Debugger ] Fix issue where a 'Step' command issued when there's no stack caused a crash. c5bfccc6fb Make downloading the LSP spec a flag and commit the version parsed locally dbeec3bbf3 Fix formatting in generated LSP file header bfe15d87d8 Fix LSP exceptions serializing ResponseErrors with Uris 7984dc4fcc Prepare to publish analyzer version 0.34.2. 4b1b2f9176 Switch LSP formatter to not fetch resolved ASTs that aren't used 5ce5d697da Implement LSP code folding b47524d5b0 Ensure all unhandled exceptions are recorded on the server 8ba2de2344 Sort context for conflicting inherited members 215f6620e7 [Kernel] Signal errors on static fields in constant contexts

* Roll engine to d470fc6 d470fc6 Roll src/third_party/skia 31972f889641..57263c2e0ccd (3 commits) (flutter/engine#7529) 4acfced Ensure the ResourceContext is not ripped out from under dart (flutter/engine#7528) 270e9a7 Roll src/third_party/skia a4e46804946c..31972f889641 (8 commits) (flutter/engine#7526) e984372 Roll src/third_party/skia 33b4b4908b7a..a4e46804946c (1 commits) (flutter/engine#7524) 4c135c2 Revert "Wrap the user entrypoint function in a zone with native exception callback. (flutter/engine#7512)" (flutter/engine#7522) 0a080a1 Roll src/third_party/dart 700254996f..da09945643 (14 commits) da09945643 Update dartfix pubspec before publishing b81c1b2095 Parse spread collections in map literals 1b0d93366d Add list literal spread collection fasta test cases 6c2ea4936a Clean up several deprecation hints 07f95e7761 Revert "[vm] Enable timeline on Fuchsia even in product mode." 9cdce03e16 [dart2js] Improve null receiver guard removal near JS code c3599a9d8c Revert "[vm, isolate] Fix length truncation in message snapshots." 95e10c336f Revert "[vm] Assert callback state for all Dart_Set*ReturnValue." 3f7b371f2c [vm] Enable timeline on Fuchsia even in product mode. 4b22195ea1 [vm, isolate] Fix length truncation in message snapshots. a353b1172a [vm, compiler] Remove TAG_IC_DATA, which has since been subsumed by RebindRule. ca12afec50 [vm] Assert callback state for all Dart_Set*ReturnValue. 2028006a25 [Observatory] Updated Dart icon to new colour scheme 84273b9f36 Improvements for flow analysis. fff5377 Roll src/third_party/skia 25b9f192ed8c..33b4b4908b7a (1 commits) (flutter/engine#7520) a58cc39 Roll src/third_party/skia 1ce80fb351a2..25b9f192ed8c (5 commits) (flutter/engine#7517) 52e0e9d Roll src/third_party/skia 081e6f375497..1ce80fb351a2 (12 commits) (flutter/engine#7514) 25559ed Wrap the user entrypoint function in a zone with native exception callback. (flutter/engine#7512) 1b0d09b Roll src/third_party/dart f701e11756..700254996f (5 commits) 700254996f [ Observatory / Dartium ] Updated observatory documentation and tests to remove references to Dartium. 78abb98ee7 [vm/bytecode] Fix AST removal for package-split kernel files with bytecode 0075b58bb8 CHANGELOG entry for DEPRECATED_MEMBER_USE split a5f102a7d1 Analyzer: first pass at reporting unchecked nullable value usage. a10ddca1b1 [ VM / Service ] Allow for `profile_period` flag to be set via the service protocol e7ade51 Remove unused headers (flutter/engine#7511) 369b4db Roll src/third_party/skia 1374c85fbf53..081e6f375497 (6 commits) (flutter/engine#7510) 366d44e Roll src/third_party/dart 9b5eabdaca..f701e11756 (10 commits) f701e11756 [ VM / Debugger ] Fix issue where a 'Step' command issued when there's no stack caused a crash. c5bfccc6fb Make downloading the LSP spec a flag and commit the version parsed locally dbeec3bbf3 Fix formatting in generated LSP file header bfe15d87d8 Fix LSP exceptions serializing ResponseErrors with Uris 7984dc4fcc Prepare to publish analyzer version 0.34.2. 4b1b2f9176 Switch LSP formatter to not fetch resolved ASTs that aren't used 5ce5d697da Implement LSP code folding b47524d5b0 Ensure all unhandled exceptions are recorded on the server 8ba2de2344 Sort context for conflicting inherited members 215f6620e7 [Kernel] Signal errors on static fields in constant contexts

…tion callback. (flutter/engine#7512)

…ption callback. (flutter#7512)" This reverts commit 4c135c2 and applies relevant fixes.

…ption callback. (#7512)" (#7551) This reverts commit 4c135c2 and applies relevant fixes.

flutter/engine@3c0aa91...25559ed git log 3c0aa91..25559ed --no-merges --oneline 25559ed Wrap the user entrypoint function in a zone with native exception callback. (flutter/engine#7512) 1b0d09b Roll src/third_party/dart f701e11756..700254996f (5 commits) 700254996f [ Observatory / Dartium ] Updated observatory documentation and tests to remove references to Dartium. 78abb98ee7 [vm/bytecode] Fix AST removal for package-split kernel files with bytecode 0075b58bb8 CHANGELOG entry for DEPRECATED_MEMBER_USE split a5f102a7d1 Analyzer: first pass at reporting unchecked nullable value usage. a10ddca1b1 [ VM / Service ] Allow for `profile_period` flag to be set via the service protocol e7ade51 Remove unused headers (flutter/engine#7511) 369b4db Roll src/third_party/skia 1374c85fbf53..081e6f375497 (6 commits) (flutter/engine#7510) 366d44e Roll src/third_party/dart 9b5eabdaca..f701e11756 (10 commits) f701e11756 [ VM / Debugger ] Fix issue where a &flutter#39;Step&flutter#39; command issued when there&flutter#39;s no stack caused a crash. c5bfccc6fb Make downloading the LSP spec a flag and commit the version parsed locally dbeec3bbf3 Fix formatting in generated LSP file header bfe15d87d8 Fix LSP exceptions serializing ResponseErrors with Uris 7984dc4fcc Prepare to publish analyzer version 0.34.2. 4b1b2f9176 Switch LSP formatter to not fetch resolved ASTs that aren&flutter#39;t used 5ce5d697da Implement LSP code folding b47524d5b0 Ensure all unhandled exceptions are recorded on the server 8ba2de2344 Sort context for conflicting inherited members 215f6620e7 [Kernel] Signal errors on static fields in constant contexts 1e93a8e Deprecate FlutterProjectArgs.main_path, packages_path (flutter/engine#7497) b058920 Edit the bundleid so that it conform to UIT specifications. (flutter/engine#7503) 32c9ae6 Roll src/third_party/skia 2c379d8e27e6..1374c85fbf53 (4 commits) (flutter/engine#7508) 96d10b1 Roll src/third_party/dart 492df72739..9b5eabdaca (8 commits) 9b5eabdaca Fix crash in color support a533753bec Remove --fast-startup flag support from testing scripts and status files 5f10aed19c [Kernel] Don&flutter#39;t print static fields in instance constants bdb51e2837 Improve input path handling and remove extra schemas. 0604110806 Reduce expectations on thrown exception 966e007b63 Pass CallStructure on dynamic and static use in ResolutionWorldBuilder 3e7801294e Remove unneeded code in OrderedTypeSet 8a91948c03 [Kernel] Properly signal compilation errors for constants 7709840 Roll src/third_party/skia a8694cc150a1..2c379d8e27e6 (1 commits) (flutter/engine#7506) 046ddc6 Roll src/third_party/skia 47b7cd9a6baf..a8694cc150a1 (1 commits) (flutter/engine#7504) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff ([email protected]), and stop the roller if necessary.

* Roll engine to d470fc6 d470fc6 Roll src/third_party/skia 31972f889641..57263c2e0ccd (3 commits) (flutter/engine#7529) 4acfced Ensure the ResourceContext is not ripped out from under dart (flutter/engine#7528) 270e9a7 Roll src/third_party/skia a4e46804946c..31972f889641 (8 commits) (flutter/engine#7526) e984372 Roll src/third_party/skia 33b4b4908b7a..a4e46804946c (1 commits) (flutter/engine#7524) 4c135c2 Revert "Wrap the user entrypoint function in a zone with native exception callback. (flutter/engine#7512)" (flutter/engine#7522) 0a080a1 Roll src/third_party/dart 700254996f..da09945643 (14 commits) da09945643 Update dartfix pubspec before publishing b81c1b2095 Parse spread collections in map literals 1b0d93366d Add list literal spread collection fasta test cases 6c2ea4936a Clean up several deprecation hints 07f95e7761 Revert "[vm] Enable timeline on Fuchsia even in product mode." 9cdce03e16 [dart2js] Improve null receiver guard removal near JS code c3599a9d8c Revert "[vm, isolate] Fix length truncation in message snapshots." 95e10c336f Revert "[vm] Assert callback state for all Dart_Set*ReturnValue." 3f7b371f2c [vm] Enable timeline on Fuchsia even in product mode. 4b22195ea1 [vm, isolate] Fix length truncation in message snapshots. a353b1172a [vm, compiler] Remove TAG_IC_DATA, which has since been subsumed by RebindRule. ca12afec50 [vm] Assert callback state for all Dart_Set*ReturnValue. 2028006a25 [Observatory] Updated Dart icon to new colour scheme 84273b9f36 Improvements for flow analysis. fff5377 Roll src/third_party/skia 25b9f192ed8c..33b4b4908b7a (1 commits) (flutter/engine#7520) a58cc39 Roll src/third_party/skia 1ce80fb351a2..25b9f192ed8c (5 commits) (flutter/engine#7517) 52e0e9d Roll src/third_party/skia 081e6f375497..1ce80fb351a2 (12 commits) (flutter/engine#7514) 25559ed Wrap the user entrypoint function in a zone with native exception callback. (flutter/engine#7512) 1b0d09b Roll src/third_party/dart f701e11756..700254996f (5 commits) 700254996f [ Observatory / Dartium ] Updated observatory documentation and tests to remove references to Dartium. 78abb98ee7 [vm/bytecode] Fix AST removal for package-split kernel files with bytecode 0075b58bb8 CHANGELOG entry for DEPRECATED_MEMBER_USE split a5f102a7d1 Analyzer: first pass at reporting unchecked nullable value usage. a10ddca1b1 [ VM / Service ] Allow for `profile_period` flag to be set via the service protocol e7ade51 Remove unused headers (flutter/engine#7511) 369b4db Roll src/third_party/skia 1374c85fbf53..081e6f375497 (6 commits) (flutter/engine#7510) 366d44e Roll src/third_party/dart 9b5eabdaca..f701e11756 (10 commits) f701e11756 [ VM / Debugger ] Fix issue where a 'Step' command issued when there's no stack caused a crash. c5bfccc6fb Make downloading the LSP spec a flag and commit the version parsed locally dbeec3bbf3 Fix formatting in generated LSP file header bfe15d87d8 Fix LSP exceptions serializing ResponseErrors with Uris 7984dc4fcc Prepare to publish analyzer version 0.34.2. 4b1b2f9176 Switch LSP formatter to not fetch resolved ASTs that aren't used 5ce5d697da Implement LSP code folding b47524d5b0 Ensure all unhandled exceptions are recorded on the server 8ba2de2344 Sort context for conflicting inherited members 215f6620e7 [Kernel] Signal errors on static fields in constant contexts

Wrap the user entrypoint function in a zone with native exception cal…

1282d2c

…lback.

googlebot added the cla: yes label Jan 16, 2019

chinmaygarde requested review from a-siva, cbracken, jason-simmons and rmacnak-google January 16, 2019 23:22

rmacnak-google reviewed Jan 16, 2019

View reviewed changes

chinmaygarde added 3 commits January 16, 2019 15:41

Path the RunFromLibrary path.

2bbb74d

Dont make the trampoline async.

2af199c

Add documentations to the settings object.

de9a393

rmacnak-google approved these changes Jan 16, 2019

View reviewed changes

Fix Lint error

4291383

chinmaygarde merged commit 25559ed into flutter:master Jan 17, 2019

chinmaygarde deleted the runtests branch January 17, 2019 00:08

engine-flutter-autoroll mentioned this pull request Jan 17, 2019

Roll engine 3c0aa918de87..25559ed07796 (11 commits) flutter/flutter#26683

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 17, 2019

25559ed Wrap the user entrypoint function in a zone with native excep…

77180cc

…tion callback. (flutter/engine#7512)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 17, 2019

25559ed Wrap the user entrypoint function in a zone with native excep…

abc6b43

…tion callback. (flutter/engine#7512)

engine-flutter-autoroll mentioned this pull request Jan 17, 2019

Roll engine 1e93a8eb39d7..fff537777083 (8 commits) flutter/flutter#26699

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 17, 2019

25559ed Wrap the user entrypoint function in a zone with native excep…

426bd32

…tion callback. (flutter/engine#7512)

engine-flutter-autoroll mentioned this pull request Jan 17, 2019

Roll engine 1e93a8eb39d7..0a080a1e0460 (9 commits) flutter/flutter#26701

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 17, 2019

25559ed Wrap the user entrypoint function in a zone with native excep…

d7691ac

…tion callback. (flutter/engine#7512)

engine-flutter-autoroll mentioned this pull request Jan 17, 2019

Roll engine 1e93a8eb39d7..4c135c298a81 (10 commits) flutter/flutter#26707

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 17, 2019

25559ed Wrap the user entrypoint function in a zone with native excep…

f03c8c0

…tion callback. (flutter/engine#7512)

engine-flutter-autoroll mentioned this pull request Jan 17, 2019

Roll engine 1e93a8eb39d7..e98437248f02 (11 commits) flutter/flutter#26710

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 17, 2019

25559ed Wrap the user entrypoint function in a zone with native excep…

cbcdf25

…tion callback. (flutter/engine#7512)

engine-flutter-autoroll mentioned this pull request Jan 17, 2019

Roll engine 1e93a8eb39d7..270e9a78a685 (12 commits) flutter/flutter#26719

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 17, 2019

25559ed Wrap the user entrypoint function in a zone with native excep…

c1c99f0

…tion callback. (flutter/engine#7512)

engine-flutter-autoroll mentioned this pull request Jan 17, 2019

Roll engine 1e93a8eb39d7..4acfced383b6 (13 commits) flutter/flutter#26726

Closed

dnfield mentioned this pull request Jan 17, 2019

Roll engine to d470fc65ea1cb91ae66706b320d82c4536a4da8b flutter/flutter#26727

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 18, 2019

25559ed Wrap the user entrypoint function in a zone with native excep…

0bb9dc4

…tion callback. (flutter/engine#7512)

engine-flutter-autoroll mentioned this pull request Jan 18, 2019

Roll engine 1e93a8eb39d7..d470fc65ea1c (14 commits) flutter/flutter#26731

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 18, 2019

25559ed Wrap the user entrypoint function in a zone with native excep…

f7b0f8b

…tion callback. (flutter/engine#7512)

engine-flutter-autoroll mentioned this pull request Jan 18, 2019

Roll engine 1e93a8eb39d7..d470fc65ea1c (14 commits) flutter/flutter#26732

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 18, 2019

25559ed Wrap the user entrypoint function in a zone with native excep…

573d231

…tion callback. (flutter/engine#7512)

engine-flutter-autoroll mentioned this pull request Jan 18, 2019

Roll engine 1e93a8eb39d7..d470fc65ea1c (14 commits) flutter/flutter#26733

Closed

chinmaygarde added a commit to chinmaygarde/flutter_engine that referenced this pull request Jan 23, 2019

Re-land "Wrap the user entrypoint function in a zone with native exce…

5258cd7

…ption callback. (flutter#7512)" This reverts commit 4c135c2 and applies relevant fixes.

chinmaygarde added a commit to chinmaygarde/flutter_engine that referenced this pull request Jan 24, 2019

Re-land "Wrap the user entrypoint function in a zone with native exce…

a5e438d

…ption callback. (flutter#7512)" This reverts commit 4c135c2 and applies relevant fixes.

chinmaygarde added a commit to chinmaygarde/flutter_engine that referenced this pull request Jan 24, 2019

Re-land "Wrap the user entrypoint function in a zone with native exce…

17ce5ed

…ption callback. (flutter#7512)" This reverts commit 4c135c2 and applies relevant fixes.

chinmaygarde added a commit that referenced this pull request Jan 24, 2019

Re-land "Wrap the user entrypoint function in a zone with native exce…

23b7e29

…ption callback. (#7512)" (#7551) This reverts commit 4c135c2 and applies relevant fixes.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Wrap the user entrypoint function in a zone with native exception callback. #7512

Wrap the user entrypoint function in a zone with native exception callback. #7512

Uh oh!

chinmaygarde commented Jan 16, 2019

Uh oh!

chinmaygarde commented Jan 16, 2019

Uh oh!

rmacnak-google Jan 16, 2019

Uh oh!

chinmaygarde Jan 16, 2019

Uh oh!

chinmaygarde Jan 16, 2019

Uh oh!

rmacnak-google left a comment

Uh oh!

rmacnak-google Jan 16, 2019

Uh oh!

chinmaygarde Jan 16, 2019

Uh oh!

mraleph Jan 17, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Wrap the user entrypoint function in a zone with native exception callback. #7512

Wrap the user entrypoint function in a zone with native exception callback. #7512

Uh oh!

Conversation

chinmaygarde commented Jan 16, 2019

Uh oh!

chinmaygarde commented Jan 16, 2019

Uh oh!

rmacnak-google Jan 16, 2019

Choose a reason for hiding this comment

Uh oh!

chinmaygarde Jan 16, 2019

Choose a reason for hiding this comment

Uh oh!

chinmaygarde Jan 16, 2019

Choose a reason for hiding this comment

Uh oh!

rmacnak-google left a comment

Choose a reason for hiding this comment

Uh oh!

rmacnak-google Jan 16, 2019

Choose a reason for hiding this comment

Uh oh!

chinmaygarde Jan 16, 2019

Choose a reason for hiding this comment

Uh oh!

mraleph Jan 17, 2019

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants