Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@cbracken
Copy link
Member

As of Dart 2, running from Dart source is no longer supported. Dart
code should now be compiled to kernel form and will be loaded by from
kernel.blob in the assets directory. We retain the struct member for ABI
stability.

As of Dart 2, running from Dart source is no longer supported.  Dart
code should now be compiled to kernel form and will be loaded by from
kernel.blob in the assets directory. We retain the struct member for ABI
stability.
@cbracken cbracken changed the title Deprecate FlutterProjectArgs.main_path Deprecate FlutterProjectArgs.main_path, packages_path Jan 16, 2019
This is no longer required with the advent of Dart 2, since kernel blobs
are self-contained.
@cbracken cbracken merged commit 1e93a8e into flutter:master Jan 16, 2019
@cbracken cbracken deleted the deprecate-main_path branch January 16, 2019 20:47
stuartmorgan-g added a commit to stuartmorgan-g/flutter-desktop-embedding that referenced this pull request Jan 16, 2019
- Eliminate the distinction between source mode and snapshot mode;
  source mode hasn't worked since the switch to Dart2, and the relevant
  engine arguments are deprecated in
  flutter/engine#7497
- Hide the need for the first argument to be the executable from clients
  of the library; this is an implementation detail of the engine API,
  and not something that each client application should need to handle
  given that the expected use case is to provide a constructed argument
  array, rather than pass through argc/argv directly.
  (As part of this change, removes the macOS code to strip Xcode-added
  arguments, for the same reason.)

This is a breaking change; clients will need to update the call to the
primary entry point, including removing the dummy first argument they
were likely providing in the arguments array.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 16, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 16, 2019
stuartmorgan-g pushed a commit to google/flutter-desktop-embedding that referenced this pull request Jan 17, 2019
- Eliminates the distinction between source mode and snapshot mode;
  source mode hasn't worked since the switch to Dart2, and the relevant
  engine arguments are deprecated in
  flutter/engine#7497
- Hides the need for the first argument to be the executable from clients
  of the library; this is an implementation detail of the engine API,
  and not something that each client application should need to handle
  given that the expected use case is to provide a constructed argument
  array, rather than pass through argc/argv directly.
  (As part of this change, removes the macOS code to strip Xcode-added
  arguments, for the same reason.)

This is a breaking change; clients will need to update the call to the
primary entry point, including removing the dummy first argument they
were likely providing in the arguments array.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 17, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 17, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 17, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 17, 2019
engine-flutter-autoroll added a commit to flutter/flutter that referenced this pull request Jan 17, 2019
flutter/engine@3c0aa91...25559ed

git log 3c0aa91..25559ed --no-merges --oneline
25559ed Wrap the user entrypoint function in a zone with native exception callback. (flutter/engine#7512)
1b0d09b Roll src/third_party/dart f701e11756..700254996f (5 commits) 700254996f [ Observatory / Dartium ] Updated observatory documentation and tests to remove references to Dartium. 78abb98ee7 [vm/bytecode] Fix AST removal for package-split kernel files with bytecode 0075b58bb8 CHANGELOG entry for DEPRECATED_MEMBER_USE split a5f102a7d1 Analyzer: first pass at reporting unchecked nullable value usage. a10ddca1b1 [ VM / Service ] Allow for `profile_period` flag to be set via the service protocol
e7ade51 Remove unused headers (flutter/engine#7511)
369b4db Roll src/third_party/skia 1374c85fbf53..081e6f375497 (6 commits) (flutter/engine#7510)
366d44e Roll src/third_party/dart 9b5eabdaca..f701e11756 (10 commits) f701e11756 [ VM / Debugger ] Fix issue where a 'Step' command issued when there's no stack caused a crash. c5bfccc6fb Make downloading the LSP spec a flag and commit the version parsed locally dbeec3bbf3 Fix formatting in generated LSP file header bfe15d87d8 Fix LSP exceptions serializing ResponseErrors with Uris 7984dc4fcc Prepare to publish analyzer version 0.34.2. 4b1b2f9176 Switch LSP formatter to not fetch resolved ASTs that aren't used 5ce5d697da Implement LSP code folding b47524d5b0 Ensure all unhandled exceptions are recorded on the server 8ba2de2344 Sort context for conflicting inherited members 215f6620e7 [Kernel] Signal errors on static fields in constant contexts
1e93a8e Deprecate FlutterProjectArgs.main_path, packages_path (flutter/engine#7497)
b058920 Edit the bundleid so that it conform to UIT specifications. (flutter/engine#7503)
32c9ae6 Roll src/third_party/skia 2c379d8e27e6..1374c85fbf53 (4 commits) (flutter/engine#7508)
96d10b1 Roll src/third_party/dart 492df72739..9b5eabdaca (8 commits) 9b5eabdaca Fix crash in color support a533753bec Remove --fast-startup flag support from testing scripts and status files 5f10aed19c [Kernel] Don't print static fields in instance constants bdb51e2837 Improve input path handling and remove extra schemas. 0604110806 Reduce expectations on thrown exception 966e007b63 Pass CallStructure on dynamic and static use in ResolutionWorldBuilder 3e7801294e Remove unneeded code in OrderedTypeSet 8a91948c03 [Kernel] Properly signal compilation errors for constants
7709840 Roll src/third_party/skia a8694cc150a1..2c379d8e27e6 (1 commits) (flutter/engine#7506)
046ddc6 Roll src/third_party/skia 47b7cd9a6baf..a8694cc150a1 (1 commits) (flutter/engine#7504)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff ([email protected]), and stop
the roller if necessary.
kangwang1988 pushed a commit to XianyuTech/flutter that referenced this pull request Feb 12, 2019
flutter/engine@3c0aa91...25559ed

git log 3c0aa91..25559ed --no-merges --oneline
25559ed Wrap the user entrypoint function in a zone with native exception callback. (flutter/engine#7512)
1b0d09b Roll src/third_party/dart f701e11756..700254996f (5 commits) 700254996f [ Observatory / Dartium ] Updated observatory documentation and tests to remove references to Dartium. 78abb98ee7 [vm/bytecode] Fix AST removal for package-split kernel files with bytecode 0075b58bb8 CHANGELOG entry for DEPRECATED_MEMBER_USE split a5f102a7d1 Analyzer: first pass at reporting unchecked nullable value usage. a10ddca1b1 [ VM / Service ] Allow for `profile_period` flag to be set via the service protocol
e7ade51 Remove unused headers (flutter/engine#7511)
369b4db Roll src/third_party/skia 1374c85fbf53..081e6f375497 (6 commits) (flutter/engine#7510)
366d44e Roll src/third_party/dart 9b5eabdaca..f701e11756 (10 commits) f701e11756 [ VM / Debugger ] Fix issue where a &flutter#39;Step&flutter#39; command issued when there&flutter#39;s no stack caused a crash. c5bfccc6fb Make downloading the LSP spec a flag and commit the version parsed locally dbeec3bbf3 Fix formatting in generated LSP file header bfe15d87d8 Fix LSP exceptions serializing ResponseErrors with Uris 7984dc4fcc Prepare to publish analyzer version 0.34.2. 4b1b2f9176 Switch LSP formatter to not fetch resolved ASTs that aren&flutter#39;t used 5ce5d697da Implement LSP code folding b47524d5b0 Ensure all unhandled exceptions are recorded on the server 8ba2de2344 Sort context for conflicting inherited members 215f6620e7 [Kernel] Signal errors on static fields in constant contexts
1e93a8e Deprecate FlutterProjectArgs.main_path, packages_path (flutter/engine#7497)
b058920 Edit the bundleid so that it conform to UIT specifications. (flutter/engine#7503)
32c9ae6 Roll src/third_party/skia 2c379d8e27e6..1374c85fbf53 (4 commits) (flutter/engine#7508)
96d10b1 Roll src/third_party/dart 492df72739..9b5eabdaca (8 commits) 9b5eabdaca Fix crash in color support a533753bec Remove --fast-startup flag support from testing scripts and status files 5f10aed19c [Kernel] Don&flutter#39;t print static fields in instance constants bdb51e2837 Improve input path handling and remove extra schemas. 0604110806 Reduce expectations on thrown exception 966e007b63 Pass CallStructure on dynamic and static use in ResolutionWorldBuilder 3e7801294e Remove unneeded code in OrderedTypeSet 8a91948c03 [Kernel] Properly signal compilation errors for constants
7709840 Roll src/third_party/skia a8694cc150a1..2c379d8e27e6 (1 commits) (flutter/engine#7506)
046ddc6 Roll src/third_party/skia 47b7cd9a6baf..a8694cc150a1 (1 commits) (flutter/engine#7504)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff ([email protected]), and stop
the roller if necessary.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants