This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[License] Sync analysis_options.yaml from framework #7273
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goderbauer
approved these changes
Dec 20, 2018
tools/licenses/analysis_options.yaml
Outdated
| # which should be kept in sync with this file: | ||
| # | ||
| # - analysis_options.yaml (this file) | ||
| # - packages/flutter/lib/analysis_options_user.yaml |
Member
There was a problem hiding this comment.
This one is in a different repo, right? Maybe change link to URL like below?
Enables a few more lints that (a) seem sensible and (b) don't require any code changes.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 21, 2018
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Dec 21, 2018
flutter/engine@6a90418...54a3577 git log 6a90418..54a3577 --no-merges --oneline 54a3577 Roll src/third_party/skia b03e024a4034..bdfe3a3ee9c3 (14 commits) (flutter/engine#7277) ead76a4 Remove unused native function dumpCopmpilationTrace(). (flutter/engine#7276) eaffc46 [License] Enable avoid_positional_boolean_parameters lint (flutter/engine#7275) b07753b [License] Sync analysis_options.yaml from framework (flutter/engine#7273) 233c100 [License] Enable always_require_non_null_named_parameters f4b348f [License] Enable flutter_style_todos lint 48be433 [License] Enable prefer_is_empty lint bd648ba [License] Enable prefer_const_constructors lint 2b207a5 [License] Enable unnecessary_parenthesis lint 97ae271 [License] Enable prefer_initializing_formals lint c8f83fb [License] Enable prefer_collection_literals lint d120e15 [License] Enable prefer_void_to_null lint e2ab378 [License] Enable directives_ordering lint 5f2e6cd [License] Enable unnecessary_overrides lint bd955d7 [License] Enable avoid_function_literals_in_foreach_calls lint 392df65 [License] Enable prefer_const_declarations lint 06e3591 [License] Enable prefer_final_fields lint 32423ef [License] Enable prefer_asserts_in_initializer_lists lint 4703a7f [License] Enable prefer_equal_for_default_values lint 1d7285b [License] Enable empty_catches lint 68fadca [License] Enable unnecessary_this lint c6f5e67 [License] Enable prefer_single_quotes lint cc51731 Clarify TextAffinity docs (flutter/engine#7238) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff ([email protected]), and stop the roller if necessary.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This syncs in the analysis_options.yaml from the framework but re-enables any lints the framework disables that were enabled in the license tool, or that seem reasonable to add.