Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@cbracken
Copy link
Member

This appears to have been the original intent behind the dead statement.

Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lol

@Hixie
Copy link
Contributor

Hixie commented Dec 20, 2018

heh oops

@cbracken cbracken merged commit 6a90418 into flutter:master Dec 20, 2018
@cbracken cbracken deleted the missing-assert branch December 20, 2018 21:50
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 21, 2018
engine-flutter-autoroll added a commit to flutter/flutter that referenced this pull request Dec 21, 2018
flutter/engine@e859296...6a90418

git log e859296..6a90418 --no-merges --oneline
6a90418 [License] Assert license filename is non-null, non-empty (flutter/engine#7270)
72aa378 [License] Eliminate duplicate case in switch (flutter/engine#7269)
74af442 Mark all unreassigned locals final in license tool (flutter/engine#7267)
0310e91 Roll src/third_party/skia 44539be30ef8..b03e024a4034 (7 commits) (flutter/engine#7268)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff ([email protected]), and stop
the roller if necessary.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants