This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[License] Eliminate duplicate case in switch #7269
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
|
This changes behaviour, but we should treat diffs as binary for the reasons outlined in the comment on the remaining diff case.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 21, 2018
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Dec 21, 2018
flutter/engine@e859296...6a90418 git log e859296..6a90418 --no-merges --oneline 6a90418 [License] Assert license filename is non-null, non-empty (flutter/engine#7270) 72aa378 [License] Eliminate duplicate case in switch (flutter/engine#7269) 74af442 Mark all unreassigned locals final in license tool (flutter/engine#7267) 0310e91 Roll src/third_party/skia 44539be30ef8..b03e024a4034 (7 commits) (flutter/engine#7268) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff ([email protected]), and stop the roller if necessary.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eliminates a duplicate switch case for .diff files. This changes behaviour to now
treat diffs as binary for the reasons outlined in the comment on the remaining .diff
case.