This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Support user-provided font-fallback. #7241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Will require a manual engine roll to support the framework-side changes |
jason-simmons
suggested changes
Dec 18, 2018
GaryQian
force-pushed
the
fontfallback
branch
from
b8b8509 to
8f2f217
Compare
Hixie
reviewed
Dec 19, 2018
Hixie
reviewed
Dec 19, 2018
Hixie
reviewed
Dec 19, 2018
Contributor
|
Is there any reason to pass the fontFamily and the fontFamilyFallback as separate items from the dart to the C++? It seems like we could just pass one list, which is fontFamily + fontFamilyFallback, and the C++ code wouldn't have to know anything about the distinction. |
jason-simmons
approved these changes
Dec 19, 2018
…and will later be used for paragraphStyle too
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 22, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the
fontFamilyFallbackfield to TextStyle and passes it to minikin.