This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Split up paintChildWithPaint into paintChildWithOpacity and paintChildWithColorFilter #711
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dWithColorFilter
The compositor backends we're planning to use can't handle a general-purpose
paint layer and instead need lower-level operations.
Fixes #707
Contributor
|
LGTM |
abarth
added a commit
that referenced
this pull request
Aug 20, 2015
Split up paintChildWithPaint into paintChildWithOpacity and paintChildWithColorFilter
rhencke
pushed a commit
to rhencke/engine
that referenced
this pull request
Dec 20, 2020
Partially addresses flutter#711
rhencke
pushed a commit
to rhencke/engine
that referenced
this pull request
Dec 20, 2020
* Allow hard splits inside string interpolation. Removing *all* splits broken several things. In particular, multiline strings and line comments inside interpolation really do need to maintain their splits. This allows all hard splits to split but not soft splits. It also allows collection literals to split. That's not ideal, but it should be a rare case anyway. If you don't want that to split, don't have a collection literal inside a string interpolation in a line that doesn't fit the page width. Fix flutter#711. * Add another edge case test. * Bump version and update changelog. * Revise README.
aam
added a commit
to aam/engine
that referenced
this pull request
Apr 11, 2023
Changes since last roll: ``` c26173f Revert "[dart] Add ntdll.lib for better exception handling in dart (flutter#709) (flutter#711) ```
itekdev
pushed a commit
to itekdev/flutter-engine0
that referenced
this pull request
May 1, 2023
…lutter#709) (flutter#711) This reverts commit e18c162 as there is no longer a need for the library to be added into flutter since been added to dart vm BUILD.gn in https://dart.googlesource.com/sdk/+/617925e0c5b24d5b11784056ce1b61a686bd18a5 BUG=flutter/flutter#124532
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The compositor backends we're planning to use can't handle a general-purpose
paint layer and instead need lower-level operations.
Fixes #707