This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Rename vestiges of root
#709
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now use the term `renderObject`.
Fixes #708
Contributor
|
LGTM |
rhencke
pushed a commit
to rhencke/engine
that referenced
this pull request
Dec 20, 2020
* Don't split inside string interpolation. When it happens, it's usually a sign that you should split the string yourself to avoid it. But it still looks terrible. And in multi-line strings, you may *want* to have lines longer than the page width, in which case the splitting is really bad. * Reword doc comment.
aam
added a commit
to aam/engine
that referenced
this pull request
Apr 11, 2023
Changes since last roll: ``` c26173f Revert "[dart] Add ntdll.lib for better exception handling in dart (flutter#709) (flutter#711) ```
itekdev
pushed a commit
to itekdev/flutter-engine0
that referenced
this pull request
May 1, 2023
API added in https://dart.googlesource.com/sdk/+/386a87a8905c48342e1bb9dcbe0ff693690468a7 for better exception handling on Windows needs this library.
itekdev
pushed a commit
to itekdev/flutter-engine0
that referenced
this pull request
May 1, 2023
…lutter#709) (flutter#711) This reverts commit e18c162 as there is no longer a need for the library to be added into flutter since been added to dart vm BUILD.gn in https://dart.googlesource.com/sdk/+/617925e0c5b24d5b11784056ce1b61a686bd18a5 BUG=flutter/flutter#124532
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now use the term
renderObject.Fixes #708