This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Support querying display refresh rate in engine #7002
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is more consistent with the `flutter query refresh-rate` command line and it indicates that the "query" might be more costly than a simple "get" (e.g., we have to communicate with Android/Java or iOS/ObjC).
Contributor
Author
|
CC @devoncarew and @kenzieschmoll : as you suggested, the string returned only includes a single number (e.g., "60.0") and the unit (FPS) is embedded in the method name or the key of the key-value pair. |
chinmaygarde
suggested changes
Nov 28, 2018
Member
chinmaygarde
left a comment
chinmaygarde
left a comment
There was a problem hiding this comment.
Please make sure to edit the Wiki page to document this service protocol extension here https://github.com/flutter/flutter/wiki/Engine-specific-Service-Protocol-extensions.
Contributor
sounds great, thanks for the changes |
Member
|
Awesome, thanks Yuqian! |
liyuqian
changed the title
Contributor
Author
|
@chinmaygarde : can you please review the change to see if your comments are addressed? |
chinmaygarde
approved these changes
Dec 12, 2018
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 12, 2018
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 12, 2018
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 13, 2018
goderbauer
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 13, 2018
* 2bd75ae Support querying display refresh rate in engine (flutter/engine#7002) * 793a08b Add .woff file to binary format (flutter/engine#7202) * daf0ede Roll src/third_party/skia 6417060b1c23..340aeda6b3ba (41 commits) (flutter/engine#7205) * 571f474 Update marked text before selection so textInRange is never called with (flutter/engine#6989)
Member
|
@liyuqian when will support for iOS devices be added? |
Contributor
Author
|
This is already added in #11006
…On Tue, Sep 3, 2019 at 9:57 AM Kenzie Schmoll ***@***.***> wrote:
@liyuqian <https://github.com/liyuqian> when will support for iOS devices
be added?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#7002?email_source=notifications&email_token=AFPMGMGFL4UTJS3SXXLQXI3QH2JP7A5CNFSM4GHCNWF2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5Y3QHY#issuecomment-527546399>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFPMGMELY3GOYQRMO4IR2MLQH2JP7ANCNFSM4GHCNWFQ>
.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation only deals with Android devices and we'll add iOS devices support soon.