This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Japanese Clear Text Crash #6989
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinmc
changed the title
Contributor
Author
|
I'm working on a separate test for this in the flutter repo's driver tests. |
Member
|
Thanks for the super-clear PR description!
|
cbracken
approved these changes
Nov 28, 2018
Contributor
Author
|
I had wanted to write a regression test for this in the flutter repo's integration tests, but it seems not possible due to lack of marked text support. I opened an issue for now to point that out: flutter/flutter#24955 |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 13, 2018
goderbauer
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 13, 2018
* 2bd75ae Support querying display refresh rate in engine (flutter/engine#7002) * 793a08b Add .woff file to binary format (flutter/engine#7202) * daf0ede Roll src/third_party/skia 6417060b1c23..340aeda6b3ba (41 commits) (flutter/engine#7205) * 571f474 Update marked text before selection so textInRange is never called with (flutter/engine#6989)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes flutter/flutter#24276
Closes flutter/flutter#24555
This addresses a crash that happens when
TextEditingController.clearis called on a field containing marked text. Marked text is unfinalized text from some input methods like Japanese kana.textInRangewas being called with a nonzero range when the text had already been cleared to an empty string. The problem was thatselectionDidChange, which triggers a bunch of internal calls and eventually calls totextInRange, was being called before the marked range had been updated. This PR moves the marked range update first to avoid the problem.