This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Update Dartdoc for SceneBuilder#addPlatformView #6957
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbracken
reviewed
Nov 27, 2018
lib/ui/compositing.dart
Outdated
| /// for output buffers. Quartz might allocated extra buffers for compositing the Flutter surfaces | ||
| /// and the platform view. | ||
| /// | ||
| /// With a platform view in the scene, Quarts has to composite the 2 Flutter surfaces and the |
cbracken
reviewed
Nov 27, 2018
lib/ui/compositing.dart
Outdated
| /// for output buffers. Quartz might allocated extra buffers for compositing the Flutter surfaces | ||
| /// and the platform view. | ||
| /// | ||
| /// With a platform view in the scene, Quarts has to composite the 2 Flutter surfaces and the |
cbracken
approved these changes
Nov 27, 2018
Member
|
|
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 27, 2018
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Nov 27, 2018
…ne#6957) (#24794) flutter/engine@84e3b13...5bf4deb git log 84e3b13..5bf4deb --no-merges --oneline 5bf4deb Update Dartdoc for SceneBuilder#addPlatformView (flutter/engine#6957) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
goderbauer
added a commit
to flutter/flutter
that referenced
this pull request
Nov 27, 2018
…utter/engine#6957) (#24794)" This reverts commit 9ca129d.
GaryQian
pushed a commit
to GaryQian/engine
that referenced
this pull request
Dec 11, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.