This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Dont attempt to log names of extensions as these change depending on the header used. #6949
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanderso
approved these changes
Nov 26, 2018
GaryQian
approved these changes
Nov 26, 2018
liyuqian
approved these changes
Nov 26, 2018
| return "Unknown Error"; | ||
| } | ||
| return "Unknown Error"; | ||
| return ""; |
Contributor
There was a problem hiding this comment.
LGTM with nits.
I like the old return "Unknown Error"; a little more than the new default: return ...
Can we also use Macro to reduce the duplicate of having every VK_XXX written twice (one in case, one in return)?
Member
Author
There was a problem hiding this comment.
"Unknown Error" is returned in the default case. That line of code is unreachable.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 27, 2018
…ding on the header used. (flutter/engine#6949)
chinmaygarde
added a commit
to chinmaygarde/flutter
that referenced
this pull request
Nov 27, 2018
Picks up changes that unblock the Fuchsia roll flutter/engine#6949.
chinmaygarde
added a commit
to flutter/flutter
that referenced
this pull request
Nov 27, 2018
Picks up changes that unblock the Fuchsia roll flutter/engine#6949.
GaryQian
pushed a commit
to GaryQian/engine
that referenced
this pull request
Dec 11, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method is used for debugging anyway and not bothering with the extensions makes this method more resilient to future updates to the Vulkan headers.