Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@mklim
Copy link
Contributor

@mklim mklim commented Nov 13, 2018

This reverts commit f2a3df9.

Fixes flutter/flutter#24058

@chinmaygarde
Copy link
Member

Can you only disable the cache till we figure out how to address the issues raised instead of getting rid of the infrastructure necessary for the caches?

@chinmaygarde
Copy link
Member

In the PersistentCache, avoid initializing the cache_directory_ variable. Also reopen flutter/flutter#14028 with references to the issues this commit caused. I'll investigate and patch the same if you assign the same to me.

@jason-simmons
Copy link
Member

Do you have any info on how the cache behaves on the Windows emulators where this problem shows up?

e.g. in Skia's GrGLProgramBuilder::finalize, do the results of glGetProgramBinary look correct? And does the program binary data survive the storage and reloading without corruption?

@mklim mklim changed the title Revert "Wire up the Skia persistent GPU related artifacts cache. (#6278)" Disable the persistent cache Nov 14, 2018
@mklim
Copy link
Contributor Author

mklim commented Nov 14, 2018

@chinmaygarde Done.

@jason-simmons I don't have any more detailed info, unfortunately. In general this is a bit of a painful issue to debug since this is windows only and the engine doesn't build on it. I've just been verifying the patches work to fix it by checking to see whether or not apps crash with the stack trace from the bug.

@liyuqian
Copy link
Contributor

liyuqian commented Feb 1, 2019

I tried to reproduce the crash but it seems that Skia has made some changes to fix the crash:

On Windows Android simulators, we only get a Program linking failed. error log from Skia instead of a crash if I revert this patch.

I also tried to set GrGLCaps.fProgramBinarySupport = false to enforce the source cache instead of the binary cache. That will make the error go away completely.

I wonder if we shall: (1) revert this patch as is so Skia will use binary cache when possible and emit an error log on Window simulators, or (2) revert this patch and enforce source cache so we don't get any error anywhere.

CC @chinmaygarde

liyuqian added a commit to liyuqian/engine that referenced this pull request Feb 4, 2019
This reverts commit 093b2fe.

For flutter/flutter#24058, We now only get a
"Program linking failed" error message on Windows Android simulators
without crahsing. Skia seems to have handled the linking failure in
https://skia-review.googlesource.com/c/skia/+/180372 by rebuilding the
program.
liyuqian added a commit that referenced this pull request Feb 5, 2019
This reverts commit 093b2fe.

For flutter/flutter#24058, We now only get a
"Program linking failed" error message on Windows Android simulators
without crahsing. Skia seems to have handled the linking failure in
https://skia-review.googlesource.com/c/skia/+/180372 by rebuilding the
program.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants