This repository was archived by the owner on Feb 25, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6k
Fix the Mac embedder build #6525
Merged
jason-simmons
merged 1 commit into
flutter:master
from
jason-simmons:embedder_proc_resolve_2
Oct 12, 2018
Merged
Fix the Mac embedder build #6525
jason-simmons
merged 1 commit into
flutter:master
from
jason-simmons:embedder_proc_resolve_2
Oct 12, 2018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amirh
approved these changes
Oct 12, 2018
Contributor
amirh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 13, 2018
flutter/engine@50c2e69...75e8752 git log 50c2e69..75e8752 --no-merges --oneline 75e8752 Fix the Mac embedder build (flutter/engine#6525) 436f970 Add version check for dismissable (flutter/engine#6522) 7767c78 Provide a default GL function resolver in the embedder (flutter/engine#6523) 32841dd Case-insensitive matching of family names for custom fonts (flutter/engine#6519) a9076c7 Roll src/third_party/skia 419709dbb167..21bd60daa3f3 (11 commits) (flutter/engine#6520) f2e7441 An API for loading fonts from a buffer provided by the application (flutter/engine#6508) 05aac0f fix ResourceExtractor npe. (flutter/engine#6461) cf5a2a1 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (flutter/engine#6517) 84fe4a9 Re-revert invalid line height tests (flutter/engine#6516) 5f52956 Add support for text shadows (flutter/engine#6385) e44c10c Reland "Share engine layers with the framework" (flutter#6412) (flutter/engine#6468) ba04499 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter/engine#6515) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 13, 2018
flutter/engine@50c2e69...2bb3afa git log 50c2e69..2bb3afa --no-merges --oneline 2bb3afa Roll src/third_party/skia 21bd60daa3f3..d38382d060ca (10 commits) (flutter/engine#6526) 75e8752 Fix the Mac embedder build (flutter/engine#6525) 436f970 Add version check for dismissable (flutter/engine#6522) 7767c78 Provide a default GL function resolver in the embedder (flutter/engine#6523) 32841dd Case-insensitive matching of family names for custom fonts (flutter/engine#6519) a9076c7 Roll src/third_party/skia 419709dbb167..21bd60daa3f3 (11 commits) (flutter/engine#6520) f2e7441 An API for loading fonts from a buffer provided by the application (flutter/engine#6508) 05aac0f fix ResourceExtractor npe. (flutter/engine#6461) cf5a2a1 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (flutter/engine#6517) 84fe4a9 Re-revert invalid line height tests (flutter/engine#6516) 5f52956 Add support for text shadows (flutter/engine#6385) e44c10c Reland "Share engine layers with the framework" (flutter#6412) (flutter/engine#6468) ba04499 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter/engine#6515) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 13, 2018
flutter/engine@50c2e69...a1bbea7 git log 50c2e69..a1bbea7 --no-merges --oneline a1bbea7 Add a no-op platform view layer. (flutter/engine#6505) 2bb3afa Roll src/third_party/skia 21bd60daa3f3..d38382d060ca (10 commits) (flutter/engine#6526) 75e8752 Fix the Mac embedder build (flutter/engine#6525) 436f970 Add version check for dismissable (flutter/engine#6522) 7767c78 Provide a default GL function resolver in the embedder (flutter/engine#6523) 32841dd Case-insensitive matching of family names for custom fonts (flutter/engine#6519) a9076c7 Roll src/third_party/skia 419709dbb167..21bd60daa3f3 (11 commits) (flutter/engine#6520) f2e7441 An API for loading fonts from a buffer provided by the application (flutter/engine#6508) 05aac0f fix ResourceExtractor npe. (flutter/engine#6461) cf5a2a1 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (flutter/engine#6517) 84fe4a9 Re-revert invalid line height tests (flutter/engine#6516) 5f52956 Add support for text shadows (flutter/engine#6385) e44c10c Reland "Share engine layers with the framework" (flutter#6412) (flutter/engine#6468) ba04499 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter/engine#6515) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 13, 2018
flutter/engine@50c2e69...1242f6d git log 50c2e69..1242f6d --no-merges --oneline 1242f6d Roll src/third_party/skia d38382d060ca..7e67041a1428 (2 commits) (flutter/engine#6527) a1bbea7 Add a no-op platform view layer. (flutter/engine#6505) 2bb3afa Roll src/third_party/skia 21bd60daa3f3..d38382d060ca (10 commits) (flutter/engine#6526) 75e8752 Fix the Mac embedder build (flutter/engine#6525) 436f970 Add version check for dismissable (flutter/engine#6522) 7767c78 Provide a default GL function resolver in the embedder (flutter/engine#6523) 32841dd Case-insensitive matching of family names for custom fonts (flutter/engine#6519) a9076c7 Roll src/third_party/skia 419709dbb167..21bd60daa3f3 (11 commits) (flutter/engine#6520) f2e7441 An API for loading fonts from a buffer provided by the application (flutter/engine#6508) 05aac0f fix ResourceExtractor npe. (flutter/engine#6461) cf5a2a1 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (flutter/engine#6517) 84fe4a9 Re-revert invalid line height tests (flutter/engine#6516) 5f52956 Add support for text shadows (flutter/engine#6385) e44c10c Reland "Share engine layers with the framework" (flutter#6412) (flutter/engine#6468) ba04499 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter/engine#6515) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 13, 2018
flutter/engine@50c2e69...e6887a4 git log 50c2e69..e6887a4 --no-merges --oneline e6887a4 Add missing imports for unicode/utf16.h (flutter/engine#6524) 1242f6d Roll src/third_party/skia d38382d060ca..7e67041a1428 (2 commits) (flutter/engine#6527) a1bbea7 Add a no-op platform view layer. (flutter/engine#6505) 2bb3afa Roll src/third_party/skia 21bd60daa3f3..d38382d060ca (10 commits) (flutter/engine#6526) 75e8752 Fix the Mac embedder build (flutter/engine#6525) 436f970 Add version check for dismissable (flutter/engine#6522) 7767c78 Provide a default GL function resolver in the embedder (flutter/engine#6523) 32841dd Case-insensitive matching of family names for custom fonts (flutter/engine#6519) a9076c7 Roll src/third_party/skia 419709dbb167..21bd60daa3f3 (11 commits) (flutter/engine#6520) f2e7441 An API for loading fonts from a buffer provided by the application (flutter/engine#6508) 05aac0f fix ResourceExtractor npe. (flutter/engine#6461) cf5a2a1 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (flutter/engine#6517) 84fe4a9 Re-revert invalid line height tests (flutter/engine#6516) 5f52956 Add support for text shadows (flutter/engine#6385) e44c10c Reland "Share engine layers with the framework" (flutter#6412) (flutter/engine#6468) ba04499 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter/engine#6515) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
This was referenced Oct 13, 2018
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 13, 2018
flutter/engine@50c2e69...9033c39 git log 50c2e69..9033c39 --no-merges --oneline 9033c39 Roll src/third_party/skia 7e67041a1428..b28db529c866 (1 commits) (flutter/engine#6528) e6887a4 Add missing imports for unicode/utf16.h (flutter/engine#6524) 1242f6d Roll src/third_party/skia d38382d060ca..7e67041a1428 (2 commits) (flutter/engine#6527) a1bbea7 Add a no-op platform view layer. (flutter/engine#6505) 2bb3afa Roll src/third_party/skia 21bd60daa3f3..d38382d060ca (10 commits) (flutter/engine#6526) 75e8752 Fix the Mac embedder build (flutter/engine#6525) 436f970 Add version check for dismissable (flutter/engine#6522) 7767c78 Provide a default GL function resolver in the embedder (flutter/engine#6523) 32841dd Case-insensitive matching of family names for custom fonts (flutter/engine#6519) a9076c7 Roll src/third_party/skia 419709dbb167..21bd60daa3f3 (11 commits) (flutter/engine#6520) f2e7441 An API for loading fonts from a buffer provided by the application (flutter/engine#6508) 05aac0f fix ResourceExtractor npe. (flutter/engine#6461) cf5a2a1 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (flutter/engine#6517) 84fe4a9 Re-revert invalid line height tests (flutter/engine#6516) 5f52956 Add support for text shadows (flutter/engine#6385) e44c10c Reland "Share engine layers with the framework" (flutter#6412) (flutter/engine#6468) ba04499 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter/engine#6515) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 13, 2018
flutter/engine@50c2e69...f46b7b9 git log 50c2e69..f46b7b9 --no-merges --oneline f46b7b9 Roll src/third_party/skia b28db529c866..bc7a51e79c5b (1 commits) (flutter/engine#6529) 9033c39 Roll src/third_party/skia 7e67041a1428..b28db529c866 (1 commits) (flutter/engine#6528) e6887a4 Add missing imports for unicode/utf16.h (flutter/engine#6524) 1242f6d Roll src/third_party/skia d38382d060ca..7e67041a1428 (2 commits) (flutter/engine#6527) a1bbea7 Add a no-op platform view layer. (flutter/engine#6505) 2bb3afa Roll src/third_party/skia 21bd60daa3f3..d38382d060ca (10 commits) (flutter/engine#6526) 75e8752 Fix the Mac embedder build (flutter/engine#6525) 436f970 Add version check for dismissable (flutter/engine#6522) 7767c78 Provide a default GL function resolver in the embedder (flutter/engine#6523) 32841dd Case-insensitive matching of family names for custom fonts (flutter/engine#6519) a9076c7 Roll src/third_party/skia 419709dbb167..21bd60daa3f3 (11 commits) (flutter/engine#6520) f2e7441 An API for loading fonts from a buffer provided by the application (flutter/engine#6508) 05aac0f fix ResourceExtractor npe. (flutter/engine#6461) cf5a2a1 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (flutter/engine#6517) 84fe4a9 Re-revert invalid line height tests (flutter/engine#6516) 5f52956 Add support for text shadows (flutter/engine#6385) e44c10c Reland "Share engine layers with the framework" (flutter#6412) (flutter/engine#6468) ba04499 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter/engine#6515) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
This was referenced Oct 13, 2018
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 13, 2018
flutter/engine@50c2e69...ef0b0f6 git log 50c2e69..ef0b0f6 --no-merges --oneline ef0b0f6 Roll src/third_party/skia bc7a51e79c5b..7435f2553f53 (1 commits) (flutter/engine#6530) f46b7b9 Roll src/third_party/skia b28db529c866..bc7a51e79c5b (1 commits) (flutter/engine#6529) 9033c39 Roll src/third_party/skia 7e67041a1428..b28db529c866 (1 commits) (flutter/engine#6528) e6887a4 Add missing imports for unicode/utf16.h (flutter/engine#6524) 1242f6d Roll src/third_party/skia d38382d060ca..7e67041a1428 (2 commits) (flutter/engine#6527) a1bbea7 Add a no-op platform view layer. (flutter/engine#6505) 2bb3afa Roll src/third_party/skia 21bd60daa3f3..d38382d060ca (10 commits) (flutter/engine#6526) 75e8752 Fix the Mac embedder build (flutter/engine#6525) 436f970 Add version check for dismissable (flutter/engine#6522) 7767c78 Provide a default GL function resolver in the embedder (flutter/engine#6523) 32841dd Case-insensitive matching of family names for custom fonts (flutter/engine#6519) a9076c7 Roll src/third_party/skia 419709dbb167..21bd60daa3f3 (11 commits) (flutter/engine#6520) f2e7441 An API for loading fonts from a buffer provided by the application (flutter/engine#6508) 05aac0f fix ResourceExtractor npe. (flutter/engine#6461) cf5a2a1 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (flutter/engine#6517) 84fe4a9 Re-revert invalid line height tests (flutter/engine#6516) 5f52956 Add support for text shadows (flutter/engine#6385) e44c10c Reland "Share engine layers with the framework" (flutter#6412) (flutter/engine#6468) ba04499 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter/engine#6515) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 14, 2018
flutter/engine@50c2e69...116072e git log 50c2e69..116072e --no-merges --oneline 116072e Roll src/third_party/skia 7435f2553f53..23775a2e9736 (1 commits) (flutter/engine#6531) ef0b0f6 Roll src/third_party/skia bc7a51e79c5b..7435f2553f53 (1 commits) (flutter/engine#6530) f46b7b9 Roll src/third_party/skia b28db529c866..bc7a51e79c5b (1 commits) (flutter/engine#6529) 9033c39 Roll src/third_party/skia 7e67041a1428..b28db529c866 (1 commits) (flutter/engine#6528) e6887a4 Add missing imports for unicode/utf16.h (flutter/engine#6524) 1242f6d Roll src/third_party/skia d38382d060ca..7e67041a1428 (2 commits) (flutter/engine#6527) a1bbea7 Add a no-op platform view layer. (flutter/engine#6505) 2bb3afa Roll src/third_party/skia 21bd60daa3f3..d38382d060ca (10 commits) (flutter/engine#6526) 75e8752 Fix the Mac embedder build (flutter/engine#6525) 436f970 Add version check for dismissable (flutter/engine#6522) 7767c78 Provide a default GL function resolver in the embedder (flutter/engine#6523) 32841dd Case-insensitive matching of family names for custom fonts (flutter/engine#6519) a9076c7 Roll src/third_party/skia 419709dbb167..21bd60daa3f3 (11 commits) (flutter/engine#6520) f2e7441 An API for loading fonts from a buffer provided by the application (flutter/engine#6508) 05aac0f fix ResourceExtractor npe. (flutter/engine#6461) cf5a2a1 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (flutter/engine#6517) 84fe4a9 Re-revert invalid line height tests (flutter/engine#6516) 5f52956 Add support for text shadows (flutter/engine#6385) e44c10c Reland "Share engine layers with the framework" (flutter#6412) (flutter/engine#6468) ba04499 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter/engine#6515) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 14, 2018
flutter/engine@50c2e69...a4161c8 git log 50c2e69..a4161c8 --no-merges --oneline a4161c8 Roll src/third_party/skia 23775a2e9736..681692726fc0 (1 commits) (flutter/engine#6532) 116072e Roll src/third_party/skia 7435f2553f53..23775a2e9736 (1 commits) (flutter/engine#6531) ef0b0f6 Roll src/third_party/skia bc7a51e79c5b..7435f2553f53 (1 commits) (flutter/engine#6530) f46b7b9 Roll src/third_party/skia b28db529c866..bc7a51e79c5b (1 commits) (flutter/engine#6529) 9033c39 Roll src/third_party/skia 7e67041a1428..b28db529c866 (1 commits) (flutter/engine#6528) e6887a4 Add missing imports for unicode/utf16.h (flutter/engine#6524) 1242f6d Roll src/third_party/skia d38382d060ca..7e67041a1428 (2 commits) (flutter/engine#6527) a1bbea7 Add a no-op platform view layer. (flutter/engine#6505) 2bb3afa Roll src/third_party/skia 21bd60daa3f3..d38382d060ca (10 commits) (flutter/engine#6526) 75e8752 Fix the Mac embedder build (flutter/engine#6525) 436f970 Add version check for dismissable (flutter/engine#6522) 7767c78 Provide a default GL function resolver in the embedder (flutter/engine#6523) 32841dd Case-insensitive matching of family names for custom fonts (flutter/engine#6519) a9076c7 Roll src/third_party/skia 419709dbb167..21bd60daa3f3 (11 commits) (flutter/engine#6520) f2e7441 An API for loading fonts from a buffer provided by the application (flutter/engine#6508) 05aac0f fix ResourceExtractor npe. (flutter/engine#6461) cf5a2a1 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (flutter/engine#6517) 84fe4a9 Re-revert invalid line height tests (flutter/engine#6516) 5f52956 Add support for text shadows (flutter/engine#6385) e44c10c Reland "Share engine layers with the framework" (flutter#6412) (flutter/engine#6468) ba04499 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter/engine#6515) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
This was referenced Oct 14, 2018
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 15, 2018
flutter/engine@50c2e69...ff93ccf git log 50c2e69..ff93ccf --no-merges --oneline ff93ccf Roll src/third_party/skia 681692726fc0..2b2c00f6ec36 (1 commits) (flutter/engine#6534) a4161c8 Roll src/third_party/skia 23775a2e9736..681692726fc0 (1 commits) (flutter/engine#6532) 116072e Roll src/third_party/skia 7435f2553f53..23775a2e9736 (1 commits) (flutter/engine#6531) ef0b0f6 Roll src/third_party/skia bc7a51e79c5b..7435f2553f53 (1 commits) (flutter/engine#6530) f46b7b9 Roll src/third_party/skia b28db529c866..bc7a51e79c5b (1 commits) (flutter/engine#6529) 9033c39 Roll src/third_party/skia 7e67041a1428..b28db529c866 (1 commits) (flutter/engine#6528) e6887a4 Add missing imports for unicode/utf16.h (flutter/engine#6524) 1242f6d Roll src/third_party/skia d38382d060ca..7e67041a1428 (2 commits) (flutter/engine#6527) a1bbea7 Add a no-op platform view layer. (flutter/engine#6505) 2bb3afa Roll src/third_party/skia 21bd60daa3f3..d38382d060ca (10 commits) (flutter/engine#6526) 75e8752 Fix the Mac embedder build (flutter/engine#6525) 436f970 Add version check for dismissable (flutter/engine#6522) 7767c78 Provide a default GL function resolver in the embedder (flutter/engine#6523) 32841dd Case-insensitive matching of family names for custom fonts (flutter/engine#6519) a9076c7 Roll src/third_party/skia 419709dbb167..21bd60daa3f3 (11 commits) (flutter/engine#6520) f2e7441 An API for loading fonts from a buffer provided by the application (flutter/engine#6508) 05aac0f fix ResourceExtractor npe. (flutter/engine#6461) cf5a2a1 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (flutter/engine#6517) 84fe4a9 Re-revert invalid line height tests (flutter/engine#6516) 5f52956 Add support for text shadows (flutter/engine#6385) e44c10c Reland "Share engine layers with the framework" (flutter#6412) (flutter/engine#6468) ba04499 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter/engine#6515) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 15, 2018
flutter/engine@50c2e69...d4bae4c git log 50c2e69..d4bae4c --no-merges --oneline d4bae4c Roll src/third_party/skia 2b2c00f6ec36..646d917d3c71 (1 commits) (flutter/engine#6535) ff93ccf Roll src/third_party/skia 681692726fc0..2b2c00f6ec36 (1 commits) (flutter/engine#6534) a4161c8 Roll src/third_party/skia 23775a2e9736..681692726fc0 (1 commits) (flutter/engine#6532) 116072e Roll src/third_party/skia 7435f2553f53..23775a2e9736 (1 commits) (flutter/engine#6531) ef0b0f6 Roll src/third_party/skia bc7a51e79c5b..7435f2553f53 (1 commits) (flutter/engine#6530) f46b7b9 Roll src/third_party/skia b28db529c866..bc7a51e79c5b (1 commits) (flutter/engine#6529) 9033c39 Roll src/third_party/skia 7e67041a1428..b28db529c866 (1 commits) (flutter/engine#6528) e6887a4 Add missing imports for unicode/utf16.h (flutter/engine#6524) 1242f6d Roll src/third_party/skia d38382d060ca..7e67041a1428 (2 commits) (flutter/engine#6527) a1bbea7 Add a no-op platform view layer. (flutter/engine#6505) 2bb3afa Roll src/third_party/skia 21bd60daa3f3..d38382d060ca (10 commits) (flutter/engine#6526) 75e8752 Fix the Mac embedder build (flutter/engine#6525) 436f970 Add version check for dismissable (flutter/engine#6522) 7767c78 Provide a default GL function resolver in the embedder (flutter/engine#6523) 32841dd Case-insensitive matching of family names for custom fonts (flutter/engine#6519) a9076c7 Roll src/third_party/skia 419709dbb167..21bd60daa3f3 (11 commits) (flutter/engine#6520) f2e7441 An API for loading fonts from a buffer provided by the application (flutter/engine#6508) 05aac0f fix ResourceExtractor npe. (flutter/engine#6461) cf5a2a1 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (flutter/engine#6517) 84fe4a9 Re-revert invalid line height tests (flutter/engine#6516) 5f52956 Add support for text shadows (flutter/engine#6385) e44c10c Reland "Share engine layers with the framework" (flutter#6412) (flutter/engine#6468) ba04499 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter/engine#6515) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 15, 2018
flutter/engine@50c2e69...964acaf git log 50c2e69..964acaf --no-merges --oneline 964acaf Roll src/third_party/skia 646d917d3c71..c6a17104ad68 (1 commits) (flutter/engine#6536) d4bae4c Roll src/third_party/skia 2b2c00f6ec36..646d917d3c71 (1 commits) (flutter/engine#6535) ff93ccf Roll src/third_party/skia 681692726fc0..2b2c00f6ec36 (1 commits) (flutter/engine#6534) a4161c8 Roll src/third_party/skia 23775a2e9736..681692726fc0 (1 commits) (flutter/engine#6532) 116072e Roll src/third_party/skia 7435f2553f53..23775a2e9736 (1 commits) (flutter/engine#6531) ef0b0f6 Roll src/third_party/skia bc7a51e79c5b..7435f2553f53 (1 commits) (flutter/engine#6530) f46b7b9 Roll src/third_party/skia b28db529c866..bc7a51e79c5b (1 commits) (flutter/engine#6529) 9033c39 Roll src/third_party/skia 7e67041a1428..b28db529c866 (1 commits) (flutter/engine#6528) e6887a4 Add missing imports for unicode/utf16.h (flutter/engine#6524) 1242f6d Roll src/third_party/skia d38382d060ca..7e67041a1428 (2 commits) (flutter/engine#6527) a1bbea7 Add a no-op platform view layer. (flutter/engine#6505) 2bb3afa Roll src/third_party/skia 21bd60daa3f3..d38382d060ca (10 commits) (flutter/engine#6526) 75e8752 Fix the Mac embedder build (flutter/engine#6525) 436f970 Add version check for dismissable (flutter/engine#6522) 7767c78 Provide a default GL function resolver in the embedder (flutter/engine#6523) 32841dd Case-insensitive matching of family names for custom fonts (flutter/engine#6519) a9076c7 Roll src/third_party/skia 419709dbb167..21bd60daa3f3 (11 commits) (flutter/engine#6520) f2e7441 An API for loading fonts from a buffer provided by the application (flutter/engine#6508) 05aac0f fix ResourceExtractor npe. (flutter/engine#6461) cf5a2a1 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (flutter/engine#6517) 84fe4a9 Re-revert invalid line height tests (flutter/engine#6516) 5f52956 Add support for text shadows (flutter/engine#6385) e44c10c Reland "Share engine layers with the framework" (flutter#6412) (flutter/engine#6468) ba04499 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter/engine#6515) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
This was referenced Oct 15, 2018
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 15, 2018
flutter/engine@50c2e69...4ee7725 git log 50c2e69..4ee7725 --no-merges --oneline 4ee7725 Revert "Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter#6515)" (flutter/engine#6537) 964acaf Roll src/third_party/skia 646d917d3c71..c6a17104ad68 (1 commits) (flutter/engine#6536) d4bae4c Roll src/third_party/skia 2b2c00f6ec36..646d917d3c71 (1 commits) (flutter/engine#6535) ff93ccf Roll src/third_party/skia 681692726fc0..2b2c00f6ec36 (1 commits) (flutter/engine#6534) a4161c8 Roll src/third_party/skia 23775a2e9736..681692726fc0 (1 commits) (flutter/engine#6532) 116072e Roll src/third_party/skia 7435f2553f53..23775a2e9736 (1 commits) (flutter/engine#6531) ef0b0f6 Roll src/third_party/skia bc7a51e79c5b..7435f2553f53 (1 commits) (flutter/engine#6530) f46b7b9 Roll src/third_party/skia b28db529c866..bc7a51e79c5b (1 commits) (flutter/engine#6529) 9033c39 Roll src/third_party/skia 7e67041a1428..b28db529c866 (1 commits) (flutter/engine#6528) e6887a4 Add missing imports for unicode/utf16.h (flutter/engine#6524) 1242f6d Roll src/third_party/skia d38382d060ca..7e67041a1428 (2 commits) (flutter/engine#6527) a1bbea7 Add a no-op platform view layer. (flutter/engine#6505) 2bb3afa Roll src/third_party/skia 21bd60daa3f3..d38382d060ca (10 commits) (flutter/engine#6526) 75e8752 Fix the Mac embedder build (flutter/engine#6525) 436f970 Add version check for dismissable (flutter/engine#6522) 7767c78 Provide a default GL function resolver in the embedder (flutter/engine#6523) 32841dd Case-insensitive matching of family names for custom fonts (flutter/engine#6519) a9076c7 Roll src/third_party/skia 419709dbb167..21bd60daa3f3 (11 commits) (flutter/engine#6520) f2e7441 An API for loading fonts from a buffer provided by the application (flutter/engine#6508) 05aac0f fix ResourceExtractor npe. (flutter/engine#6461) cf5a2a1 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (flutter/engine#6517) 84fe4a9 Re-revert invalid line height tests (flutter/engine#6516) 5f52956 Add support for text shadows (flutter/engine#6385) e44c10c Reland "Share engine layers with the framework" (flutter#6412) (flutter/engine#6468) ba04499 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter/engine#6515) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 15, 2018
flutter/engine@50c2e69...32f417d git log 50c2e69..32f417d --no-merges --oneline 32f417d Roll tonic to 077be256142ede39a271385907faadf4fcc62a4d. (flutter/engine#6541) 4ee7725 Revert "Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter#6515)" (flutter/engine#6537) 964acaf Roll src/third_party/skia 646d917d3c71..c6a17104ad68 (1 commits) (flutter/engine#6536) d4bae4c Roll src/third_party/skia 2b2c00f6ec36..646d917d3c71 (1 commits) (flutter/engine#6535) ff93ccf Roll src/third_party/skia 681692726fc0..2b2c00f6ec36 (1 commits) (flutter/engine#6534) a4161c8 Roll src/third_party/skia 23775a2e9736..681692726fc0 (1 commits) (flutter/engine#6532) 116072e Roll src/third_party/skia 7435f2553f53..23775a2e9736 (1 commits) (flutter/engine#6531) ef0b0f6 Roll src/third_party/skia bc7a51e79c5b..7435f2553f53 (1 commits) (flutter/engine#6530) f46b7b9 Roll src/third_party/skia b28db529c866..bc7a51e79c5b (1 commits) (flutter/engine#6529) 9033c39 Roll src/third_party/skia 7e67041a1428..b28db529c866 (1 commits) (flutter/engine#6528) e6887a4 Add missing imports for unicode/utf16.h (flutter/engine#6524) 1242f6d Roll src/third_party/skia d38382d060ca..7e67041a1428 (2 commits) (flutter/engine#6527) a1bbea7 Add a no-op platform view layer. (flutter/engine#6505) 2bb3afa Roll src/third_party/skia 21bd60daa3f3..d38382d060ca (10 commits) (flutter/engine#6526) 75e8752 Fix the Mac embedder build (flutter/engine#6525) 436f970 Add version check for dismissable (flutter/engine#6522) 7767c78 Provide a default GL function resolver in the embedder (flutter/engine#6523) 32841dd Case-insensitive matching of family names for custom fonts (flutter/engine#6519) a9076c7 Roll src/third_party/skia 419709dbb167..21bd60daa3f3 (11 commits) (flutter/engine#6520) f2e7441 An API for loading fonts from a buffer provided by the application (flutter/engine#6508) 05aac0f fix ResourceExtractor npe. (flutter/engine#6461) cf5a2a1 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (flutter/engine#6517) 84fe4a9 Re-revert invalid line height tests (flutter/engine#6516) 5f52956 Add support for text shadows (flutter/engine#6385) e44c10c Reland "Share engine layers with the framework" (flutter#6412) (flutter/engine#6468) ba04499 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter/engine#6515) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 15, 2018
flutter/engine@50c2e69...c645657 git log 50c2e69..c645657 --no-merges --oneline c645657 Roll src/third_party/skia c6a17104ad68..921ec976556c (31 commits) (flutter/engine#6546) 32f417d Roll tonic to 077be256142ede39a271385907faadf4fcc62a4d. (flutter/engine#6541) 4ee7725 Revert "Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter#6515)" (flutter/engine#6537) 964acaf Roll src/third_party/skia 646d917d3c71..c6a17104ad68 (1 commits) (flutter/engine#6536) d4bae4c Roll src/third_party/skia 2b2c00f6ec36..646d917d3c71 (1 commits) (flutter/engine#6535) ff93ccf Roll src/third_party/skia 681692726fc0..2b2c00f6ec36 (1 commits) (flutter/engine#6534) a4161c8 Roll src/third_party/skia 23775a2e9736..681692726fc0 (1 commits) (flutter/engine#6532) 116072e Roll src/third_party/skia 7435f2553f53..23775a2e9736 (1 commits) (flutter/engine#6531) ef0b0f6 Roll src/third_party/skia bc7a51e79c5b..7435f2553f53 (1 commits) (flutter/engine#6530) f46b7b9 Roll src/third_party/skia b28db529c866..bc7a51e79c5b (1 commits) (flutter/engine#6529) 9033c39 Roll src/third_party/skia 7e67041a1428..b28db529c866 (1 commits) (flutter/engine#6528) e6887a4 Add missing imports for unicode/utf16.h (flutter/engine#6524) 1242f6d Roll src/third_party/skia d38382d060ca..7e67041a1428 (2 commits) (flutter/engine#6527) a1bbea7 Add a no-op platform view layer. (flutter/engine#6505) 2bb3afa Roll src/third_party/skia 21bd60daa3f3..d38382d060ca (10 commits) (flutter/engine#6526) 75e8752 Fix the Mac embedder build (flutter/engine#6525) 436f970 Add version check for dismissable (flutter/engine#6522) 7767c78 Provide a default GL function resolver in the embedder (flutter/engine#6523) 32841dd Case-insensitive matching of family names for custom fonts (flutter/engine#6519) a9076c7 Roll src/third_party/skia 419709dbb167..21bd60daa3f3 (11 commits) (flutter/engine#6520) f2e7441 An API for loading fonts from a buffer provided by the application (flutter/engine#6508) 05aac0f fix ResourceExtractor npe. (flutter/engine#6461) cf5a2a1 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (flutter/engine#6517) 84fe4a9 Re-revert invalid line height tests (flutter/engine#6516) 5f52956 Add support for text shadows (flutter/engine#6385) e44c10c Reland "Share engine layers with the framework" (flutter#6412) (flutter/engine#6468) ba04499 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter/engine#6515) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
clarkezone
added a commit
to clarkezone/engine
that referenced
this pull request
Oct 21, 2018
…oduced a bug for embedder scenarios causing the window native library to be incorrectly initialized and thus incapable of correctly resolving GL functions. This change fixes that.
Merged
clarkezone
pushed a commit
to clarkezone/engine
that referenced
this pull request
Oct 21, 2018
…oduced a bug for embedder scenarios causing the window native library to be incorrectly initialized and thus incapable of correctly resolving GL functions. This change fixes that.
clarkezone
pushed a commit
to clarkezone/engine
that referenced
this pull request
Oct 23, 2018
…oduced a bug for embedder scenarios causing the window native library to be incorrectly initialized and thus incapable of correctly resolving GL functions. This change fixes that.
clarkezone
pushed a commit
to clarkezone/engine
that referenced
this pull request
Oct 23, 2018
…oduced a bug for embedder scenarios causing the window native library to be incorrectly initialized and thus incapable of correctly resolving GL functions. This change fixes that.
jason-simmons
pushed a commit
that referenced
this pull request
Oct 23, 2018
…or embedder scenarios causing the window native library to be incorrectly initialized and thus incapable of correctly resolving GL functions. This change fixes that. (#6624)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.