Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Reland "Share engine layers with the framework" (#6412) #6468

Merged
liyuqian merged 3 commits into from
Oct 12, 2018
Merged

Reland "Share engine layers with the framework" (#6412) #6468

liyuqian merged 3 commits into from
Oct 12, 2018

Conversation

@liyuqian
Copy link
Contributor

@liyuqian liyuqian commented Oct 8, 2018

This reverts commit 74662ab.

This should land after #6442

@liyuqian liyuqian requested a review from chinmaygarde October 8, 2018 19:25
@liyuqian liyuqian mentioned this pull request Oct 8, 2018
Closed
@liyuqian
Add pragma vm:entry-point
693fd7c 
Otherwise, an object may be both null and an instance of EnginieLayer at
the same time in Dart.
@liyuqian liyuqian changed the title [wip] Reland "Share engine layers with the framework" (#6412) Reland "Share engine layers with the framework" (#6412) Oct 11, 2018
chinmaygarde
chinmaygarde approved these changes Oct 11, 2018
View reviewed changes
lib/ui/painting.dart
class EngineLayer extends NativeFieldWrapperClass2 {
/// This class is created by the engine, and should not be instantiated
/// or extended directly.
@pragma('vm:entry-point')
Copy link
Member

@chinmaygarde chinmaygarde Oct 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious about how these pragmas work. Can we decorate the class with the same to indicate that all methods of the same are potential entrypoints?

Copy link
Contributor Author

@liyuqian liyuqian Oct 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know since I just followed what @alexmarkov suggested. Alex might know the answer?

Copy link
Contributor

@alexmarkov alexmarkov Oct 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Entry point annotation on class means that its instances can be created from non-Dart code. It does not mark all members as entry points. If C++ code calls particular constructor, then that particular constructor should be marked with pragma.

Also, it makes sense to annotate only those members which are used from non-Dart code, as annotating all members may just increase the size of snapshot and make global analysis less precise.

More about syntax and meaning of entry point pragmas: https://github.com/dart-lang/sdk/blob/master/runtime/vm/compiler/aot/entry_points_pragma.md

@liyuqian liyuqian merged commit e44c10c into flutter:master Oct 12, 2018
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 12, 2018
@engine-flutter-autoroll
Roll engine 3ffa362..e44c10c (5 commits)
985e56c 
flutter/engine@3ffa362...e44c10c

git log 3ffa362..e44c10c --no-merges --oneline
e44c10c Reland "Share engine layers with the framework" (flutter#6412) (flutter/engine#6468)
ba04499 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter/engine#6515)
50c2e69 Roll src/third_party/skia 1b62fad4b188..b27a9cf2f4a8 (1 commits) (flutter/engine#6514)
8757bf2 Roll src/third_party/skia 05caa69a3f5a..1b62fad4b188 (2 commits) (flutter/engine#6513)
c2fd10a Roll src/third_party/skia 2a138544646d..05caa69a3f5a (1 commits) (flutter/engine#6512)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 12, 2018
Closed
@liyuqian liyuqian mentioned this pull request Oct 12, 2018
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 12, 2018
@engine-flutter-autoroll
Roll engine 3ffa362..84fe4a9 (7 commits)
da1b8b1 
flutter/engine@3ffa362...84fe4a9

git log 3ffa362..84fe4a9 --no-merges --oneline
84fe4a9 Re-revert invalid line height tests (flutter/engine#6516)
5f52956 Add support for text shadows (flutter/engine#6385)
e44c10c Reland "Share engine layers with the framework" (flutter#6412) (flutter/engine#6468)
ba04499 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter/engine#6515)
50c2e69 Roll src/third_party/skia 1b62fad4b188..b27a9cf2f4a8 (1 commits) (flutter/engine#6514)
8757bf2 Roll src/third_party/skia 05caa69a3f5a..1b62fad4b188 (2 commits) (flutter/engine#6513)
c2fd10a Roll src/third_party/skia 2a138544646d..05caa69a3f5a (1 commits) (flutter/engine#6512)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 12, 2018
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 12, 2018
@engine-flutter-autoroll
Roll engine 3ffa362..cf5a2a1 (8 commits)
8cbb009 
flutter/engine@3ffa362...cf5a2a1

git log 3ffa362..cf5a2a1 --no-merges --oneline
cf5a2a1 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (flutter/engine#6517)
84fe4a9 Re-revert invalid line height tests (flutter/engine#6516)
5f52956 Add support for text shadows (flutter/engine#6385)
e44c10c Reland "Share engine layers with the framework" (flutter#6412) (flutter/engine#6468)
ba04499 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter/engine#6515)
50c2e69 Roll src/third_party/skia 1b62fad4b188..b27a9cf2f4a8 (1 commits) (flutter/engine#6514)
8757bf2 Roll src/third_party/skia 05caa69a3f5a..1b62fad4b188 (2 commits) (flutter/engine#6513)
c2fd10a Roll src/third_party/skia 2a138544646d..05caa69a3f5a (1 commits) (flutter/engine#6512)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 12, 2018
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 12, 2018
@engine-flutter-autoroll
Roll engine 3ffa362..05aac0f (9 commits)
d8046c4 
flutter/engine@3ffa362...05aac0f

git log 3ffa362..05aac0f --no-merges --oneline
05aac0f fix ResourceExtractor npe. (flutter/engine#6461)
cf5a2a1 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (flutter/engine#6517)
84fe4a9 Re-revert invalid line height tests (flutter/engine#6516)
5f52956 Add support for text shadows (flutter/engine#6385)
e44c10c Reland "Share engine layers with the framework" (flutter#6412) (flutter/engine#6468)
ba04499 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter/engine#6515)
50c2e69 Roll src/third_party/skia 1b62fad4b188..b27a9cf2f4a8 (1 commits) (flutter/engine#6514)
8757bf2 Roll src/third_party/skia 05caa69a3f5a..1b62fad4b188 (2 commits) (flutter/engine#6513)
c2fd10a Roll src/third_party/skia 2a138544646d..05caa69a3f5a (1 commits) (flutter/engine#6512)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 12, 2018
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 12, 2018
@engine-flutter-autoroll
Roll engine 3ffa362..f2e7441 (10 commits)
9566cdb 
flutter/engine@3ffa362...f2e7441

git log 3ffa362..f2e7441 --no-merges --oneline
f2e7441 An API for loading fonts from a buffer provided by the application (flutter/engine#6508)
05aac0f fix ResourceExtractor npe. (flutter/engine#6461)
cf5a2a1 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (flutter/engine#6517)
84fe4a9 Re-revert invalid line height tests (flutter/engine#6516)
5f52956 Add support for text shadows (flutter/engine#6385)
e44c10c Reland "Share engine layers with the framework" (flutter#6412) (flutter/engine#6468)
ba04499 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter/engine#6515)
50c2e69 Roll src/third_party/skia 1b62fad4b188..b27a9cf2f4a8 (1 commits) (flutter/engine#6514)
8757bf2 Roll src/third_party/skia 05caa69a3f5a..1b62fad4b188 (2 commits) (flutter/engine#6513)
c2fd10a Roll src/third_party/skia 2a138544646d..05caa69a3f5a (1 commits) (flutter/engine#6512)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 12, 2018
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 12, 2018
@engine-flutter-autoroll
Roll engine 3ffa362..f2e7441 (10 commits)
2018c94 
flutter/engine@3ffa362...f2e7441

git log 3ffa362..f2e7441 --no-merges --oneline
f2e7441 An API for loading fonts from a buffer provided by the application (flutter/engine#6508)
05aac0f fix ResourceExtractor npe. (flutter/engine#6461)
cf5a2a1 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (flutter/engine#6517)
84fe4a9 Re-revert invalid line height tests (flutter/engine#6516)
5f52956 Add support for text shadows (flutter/engine#6385)
e44c10c Reland "Share engine layers with the framework" (flutter#6412) (flutter/engine#6468)
ba04499 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter/engine#6515)
50c2e69 Roll src/third_party/skia 1b62fad4b188..b27a9cf2f4a8 (1 commits) (flutter/engine#6514)
8757bf2 Roll src/third_party/skia 05caa69a3f5a..1b62fad4b188 (2 commits) (flutter/engine#6513)
c2fd10a Roll src/third_party/skia 2a138544646d..05caa69a3f5a (1 commits) (flutter/engine#6512)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 12, 2018
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 12, 2018
@engine-flutter-autoroll
Roll engine 50c2e69..f2e7441 (7 commits)
0ec249d 
flutter/engine@50c2e69...f2e7441

git log 50c2e69..f2e7441 --no-merges --oneline
f2e7441 An API for loading fonts from a buffer provided by the application (flutter/engine#6508)
05aac0f fix ResourceExtractor npe. (flutter/engine#6461)
cf5a2a1 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (flutter/engine#6517)
84fe4a9 Re-revert invalid line height tests (flutter/engine#6516)
5f52956 Add support for text shadows (flutter/engine#6385)
e44c10c Reland "Share engine layers with the framework" (flutter#6412) (flutter/engine#6468)
ba04499 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter/engine#6515)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 12, 2018
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 12, 2018
@engine-flutter-autoroll
Roll engine 50c2e69..a9076c7 (8 commits)
74c6466 
flutter/engine@50c2e69...a9076c7

git log 50c2e69..a9076c7 --no-merges --oneline
a9076c7 Roll src/third_party/skia 419709dbb167..21bd60daa3f3 (11 commits) (flutter/engine#6520)
f2e7441 An API for loading fonts from a buffer provided by the application (flutter/engine#6508)
05aac0f fix ResourceExtractor npe. (flutter/engine#6461)
cf5a2a1 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (flutter/engine#6517)
84fe4a9 Re-revert invalid line height tests (flutter/engine#6516)
5f52956 Add support for text shadows (flutter/engine#6385)
e44c10c Reland "Share engine layers with the framework" (flutter#6412) (flutter/engine#6468)
ba04499 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter/engine#6515)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 12, 2018
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 12, 2018
@engine-flutter-autoroll
Roll engine 50c2e69..32841dd (9 commits)
1a75c66 
flutter/engine@50c2e69...32841dd

git log 50c2e69..32841dd --no-merges --oneline
32841dd Case-insensitive matching of family names for custom fonts (flutter/engine#6519)
a9076c7 Roll src/third_party/skia 419709dbb167..21bd60daa3f3 (11 commits) (flutter/engine#6520)
f2e7441 An API for loading fonts from a buffer provided by the application (flutter/engine#6508)
05aac0f fix ResourceExtractor npe. (flutter/engine#6461)
cf5a2a1 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (flutter/engine#6517)
84fe4a9 Re-revert invalid line height tests (flutter/engine#6516)
5f52956 Add support for text shadows (flutter/engine#6385)
e44c10c Reland "Share engine layers with the framework" (flutter#6412) (flutter/engine#6468)
ba04499 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter/engine#6515)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 12, 2018
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 13, 2018
@engine-flutter-autoroll
Roll engine 50c2e69..75e8752 (12 commits)
2f6a2ec 
flutter/engine@50c2e69...75e8752

git log 50c2e69..75e8752 --no-merges --oneline
75e8752 Fix the Mac embedder build (flutter/engine#6525)
436f970 Add version check for dismissable (flutter/engine#6522)
7767c78 Provide a default GL function resolver in the embedder (flutter/engine#6523)
32841dd Case-insensitive matching of family names for custom fonts (flutter/engine#6519)
a9076c7 Roll src/third_party/skia 419709dbb167..21bd60daa3f3 (11 commits) (flutter/engine#6520)
f2e7441 An API for loading fonts from a buffer provided by the application (flutter/engine#6508)
05aac0f fix ResourceExtractor npe. (flutter/engine#6461)
cf5a2a1 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (flutter/engine#6517)
84fe4a9 Re-revert invalid line height tests (flutter/engine#6516)
5f52956 Add support for text shadows (flutter/engine#6385)
e44c10c Reland "Share engine layers with the framework" (flutter#6412) (flutter/engine#6468)
ba04499 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter/engine#6515)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 13, 2018
@engine-flutter-autoroll
Roll engine 50c2e69..a1bbea7 (14 commits)
4f39a28 
flutter/engine@50c2e69...a1bbea7

git log 50c2e69..a1bbea7 --no-merges --oneline
a1bbea7 Add a no-op platform view layer. (flutter/engine#6505)
2bb3afa Roll src/third_party/skia 21bd60daa3f3..d38382d060ca (10 commits) (flutter/engine#6526)
75e8752 Fix the Mac embedder build (flutter/engine#6525)
436f970 Add version check for dismissable (flutter/engine#6522)
7767c78 Provide a default GL function resolver in the embedder (flutter/engine#6523)
32841dd Case-insensitive matching of family names for custom fonts (flutter/engine#6519)
a9076c7 Roll src/third_party/skia 419709dbb167..21bd60daa3f3 (11 commits) (flutter/engine#6520)
f2e7441 An API for loading fonts from a buffer provided by the application (flutter/engine#6508)
05aac0f fix ResourceExtractor npe. (flutter/engine#6461)
cf5a2a1 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (flutter/engine#6517)
84fe4a9 Re-revert invalid line height tests (flutter/engine#6516)
5f52956 Add support for text shadows (flutter/engine#6385)
e44c10c Reland "Share engine layers with the framework" (flutter#6412) (flutter/engine#6468)
ba04499 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter/engine#6515)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 13, 2018
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 13, 2018
@engine-flutter-autoroll
Roll engine 50c2e69..1242f6d (15 commits)
efbe465 
flutter/engine@50c2e69...1242f6d

git log 50c2e69..1242f6d --no-merges --oneline
1242f6d Roll src/third_party/skia d38382d060ca..7e67041a1428 (2 commits) (flutter/engine#6527)
a1bbea7 Add a no-op platform view layer. (flutter/engine#6505)
2bb3afa Roll src/third_party/skia 21bd60daa3f3..d38382d060ca (10 commits) (flutter/engine#6526)
75e8752 Fix the Mac embedder build (flutter/engine#6525)
436f970 Add version check for dismissable (flutter/engine#6522)
7767c78 Provide a default GL function resolver in the embedder (flutter/engine#6523)
32841dd Case-insensitive matching of family names for custom fonts (flutter/engine#6519)
a9076c7 Roll src/third_party/skia 419709dbb167..21bd60daa3f3 (11 commits) (flutter/engine#6520)
f2e7441 An API for loading fonts from a buffer provided by the application (flutter/engine#6508)
05aac0f fix ResourceExtractor npe. (flutter/engine#6461)
cf5a2a1 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (flutter/engine#6517)
84fe4a9 Re-revert invalid line height tests (flutter/engine#6516)
5f52956 Add support for text shadows (flutter/engine#6385)
e44c10c Reland "Share engine layers with the framework" (flutter#6412) (flutter/engine#6468)
ba04499 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter/engine#6515)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 13, 2018
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 13, 2018
@engine-flutter-autoroll
Roll engine 50c2e69..e6887a4 (16 commits)
cefc450 
flutter/engine@50c2e69...e6887a4

git log 50c2e69..e6887a4 --no-merges --oneline
e6887a4 Add missing imports for unicode/utf16.h (flutter/engine#6524)
1242f6d Roll src/third_party/skia d38382d060ca..7e67041a1428 (2 commits) (flutter/engine#6527)
a1bbea7 Add a no-op platform view layer. (flutter/engine#6505)
2bb3afa Roll src/third_party/skia 21bd60daa3f3..d38382d060ca (10 commits) (flutter/engine#6526)
75e8752 Fix the Mac embedder build (flutter/engine#6525)
436f970 Add version check for dismissable (flutter/engine#6522)
7767c78 Provide a default GL function resolver in the embedder (flutter/engine#6523)
32841dd Case-insensitive matching of family names for custom fonts (flutter/engine#6519)
a9076c7 Roll src/third_party/skia 419709dbb167..21bd60daa3f3 (11 commits) (flutter/engine#6520)
f2e7441 An API for loading fonts from a buffer provided by the application (flutter/engine#6508)
05aac0f fix ResourceExtractor npe. (flutter/engine#6461)
cf5a2a1 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (flutter/engine#6517)
84fe4a9 Re-revert invalid line height tests (flutter/engine#6516)
5f52956 Add support for text shadows (flutter/engine#6385)
e44c10c Reland "Share engine layers with the framework" (flutter#6412) (flutter/engine#6468)
ba04499 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter/engine#6515)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
This was referenced Oct 13, 2018
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 13, 2018
@engine-flutter-autoroll
Roll engine 50c2e69..9033c39 (17 commits)
aa8c346 
flutter/engine@50c2e69...9033c39

git log 50c2e69..9033c39 --no-merges --oneline
9033c39 Roll src/third_party/skia 7e67041a1428..b28db529c866 (1 commits) (flutter/engine#6528)
e6887a4 Add missing imports for unicode/utf16.h (flutter/engine#6524)
1242f6d Roll src/third_party/skia d38382d060ca..7e67041a1428 (2 commits) (flutter/engine#6527)
a1bbea7 Add a no-op platform view layer. (flutter/engine#6505)
2bb3afa Roll src/third_party/skia 21bd60daa3f3..d38382d060ca (10 commits) (flutter/engine#6526)
75e8752 Fix the Mac embedder build (flutter/engine#6525)
436f970 Add version check for dismissable (flutter/engine#6522)
7767c78 Provide a default GL function resolver in the embedder (flutter/engine#6523)
32841dd Case-insensitive matching of family names for custom fonts (flutter/engine#6519)
a9076c7 Roll src/third_party/skia 419709dbb167..21bd60daa3f3 (11 commits) (flutter/engine#6520)
f2e7441 An API for loading fonts from a buffer provided by the application (flutter/engine#6508)
05aac0f fix ResourceExtractor npe. (flutter/engine#6461)
cf5a2a1 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (flutter/engine#6517)
84fe4a9 Re-revert invalid line height tests (flutter/engine#6516)
5f52956 Add support for text shadows (flutter/engine#6385)
e44c10c Reland "Share engine layers with the framework" (flutter#6412) (flutter/engine#6468)
ba04499 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter/engine#6515)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 13, 2018
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 13, 2018
@engine-flutter-autoroll
Roll engine 50c2e69..f46b7b9 (18 commits)
f2d6ebc 
flutter/engine@50c2e69...f46b7b9

git log 50c2e69..f46b7b9 --no-merges --oneline
f46b7b9 Roll src/third_party/skia b28db529c866..bc7a51e79c5b (1 commits) (flutter/engine#6529)
9033c39 Roll src/third_party/skia 7e67041a1428..b28db529c866 (1 commits) (flutter/engine#6528)
e6887a4 Add missing imports for unicode/utf16.h (flutter/engine#6524)
1242f6d Roll src/third_party/skia d38382d060ca..7e67041a1428 (2 commits) (flutter/engine#6527)
a1bbea7 Add a no-op platform view layer. (flutter/engine#6505)
2bb3afa Roll src/third_party/skia 21bd60daa3f3..d38382d060ca (10 commits) (flutter/engine#6526)
75e8752 Fix the Mac embedder build (flutter/engine#6525)
436f970 Add version check for dismissable (flutter/engine#6522)
7767c78 Provide a default GL function resolver in the embedder (flutter/engine#6523)
32841dd Case-insensitive matching of family names for custom fonts (flutter/engine#6519)
a9076c7 Roll src/third_party/skia 419709dbb167..21bd60daa3f3 (11 commits) (flutter/engine#6520)
f2e7441 An API for loading fonts from a buffer provided by the application (flutter/engine#6508)
05aac0f fix ResourceExtractor npe. (flutter/engine#6461)
cf5a2a1 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (flutter/engine#6517)
84fe4a9 Re-revert invalid line height tests (flutter/engine#6516)
5f52956 Add support for text shadows (flutter/engine#6385)
e44c10c Reland "Share engine layers with the framework" (flutter#6412) (flutter/engine#6468)
ba04499 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter/engine#6515)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 13, 2018
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 13, 2018
@engine-flutter-autoroll
Roll engine 50c2e69..ef0b0f6 (19 commits)
e3080bf 
flutter/engine@50c2e69...ef0b0f6

git log 50c2e69..ef0b0f6 --no-merges --oneline
ef0b0f6 Roll src/third_party/skia bc7a51e79c5b..7435f2553f53 (1 commits) (flutter/engine#6530)
f46b7b9 Roll src/third_party/skia b28db529c866..bc7a51e79c5b (1 commits) (flutter/engine#6529)
9033c39 Roll src/third_party/skia 7e67041a1428..b28db529c866 (1 commits) (flutter/engine#6528)
e6887a4 Add missing imports for unicode/utf16.h (flutter/engine#6524)
1242f6d Roll src/third_party/skia d38382d060ca..7e67041a1428 (2 commits) (flutter/engine#6527)
a1bbea7 Add a no-op platform view layer. (flutter/engine#6505)
2bb3afa Roll src/third_party/skia 21bd60daa3f3..d38382d060ca (10 commits) (flutter/engine#6526)
75e8752 Fix the Mac embedder build (flutter/engine#6525)
436f970 Add version check for dismissable (flutter/engine#6522)
7767c78 Provide a default GL function resolver in the embedder (flutter/engine#6523)
32841dd Case-insensitive matching of family names for custom fonts (flutter/engine#6519)
a9076c7 Roll src/third_party/skia 419709dbb167..21bd60daa3f3 (11 commits) (flutter/engine#6520)
f2e7441 An API for loading fonts from a buffer provided by the application (flutter/engine#6508)
05aac0f fix ResourceExtractor npe. (flutter/engine#6461)
cf5a2a1 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (flutter/engine#6517)
84fe4a9 Re-revert invalid line height tests (flutter/engine#6516)
5f52956 Add support for text shadows (flutter/engine#6385)
e44c10c Reland "Share engine layers with the framework" (flutter#6412) (flutter/engine#6468)
ba04499 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter/engine#6515)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 14, 2018
@engine-flutter-autoroll
Roll engine 50c2e69..116072e (20 commits)
48eb043 
flutter/engine@50c2e69...116072e

git log 50c2e69..116072e --no-merges --oneline
116072e Roll src/third_party/skia 7435f2553f53..23775a2e9736 (1 commits) (flutter/engine#6531)
ef0b0f6 Roll src/third_party/skia bc7a51e79c5b..7435f2553f53 (1 commits) (flutter/engine#6530)
f46b7b9 Roll src/third_party/skia b28db529c866..bc7a51e79c5b (1 commits) (flutter/engine#6529)
9033c39 Roll src/third_party/skia 7e67041a1428..b28db529c866 (1 commits) (flutter/engine#6528)
e6887a4 Add missing imports for unicode/utf16.h (flutter/engine#6524)
1242f6d Roll src/third_party/skia d38382d060ca..7e67041a1428 (2 commits) (flutter/engine#6527)
a1bbea7 Add a no-op platform view layer. (flutter/engine#6505)
2bb3afa Roll src/third_party/skia 21bd60daa3f3..d38382d060ca (10 commits) (flutter/engine#6526)
75e8752 Fix the Mac embedder build (flutter/engine#6525)
436f970 Add version check for dismissable (flutter/engine#6522)
7767c78 Provide a default GL function resolver in the embedder (flutter/engine#6523)
32841dd Case-insensitive matching of family names for custom fonts (flutter/engine#6519)
a9076c7 Roll src/third_party/skia 419709dbb167..21bd60daa3f3 (11 commits) (flutter/engine#6520)
f2e7441 An API for loading fonts from a buffer provided by the application (flutter/engine#6508)
05aac0f fix ResourceExtractor npe. (flutter/engine#6461)
cf5a2a1 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (flutter/engine#6517)
84fe4a9 Re-revert invalid line height tests (flutter/engine#6516)
5f52956 Add support for text shadows (flutter/engine#6385)
e44c10c Reland "Share engine layers with the framework" (flutter#6412) (flutter/engine#6468)
ba04499 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter/engine#6515)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 14, 2018
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 14, 2018
@engine-flutter-autoroll
Roll engine 50c2e69..a4161c8 (21 commits)
532ff5b 
flutter/engine@50c2e69...a4161c8

git log 50c2e69..a4161c8 --no-merges --oneline
a4161c8 Roll src/third_party/skia 23775a2e9736..681692726fc0 (1 commits) (flutter/engine#6532)
116072e Roll src/third_party/skia 7435f2553f53..23775a2e9736 (1 commits) (flutter/engine#6531)
ef0b0f6 Roll src/third_party/skia bc7a51e79c5b..7435f2553f53 (1 commits) (flutter/engine#6530)
f46b7b9 Roll src/third_party/skia b28db529c866..bc7a51e79c5b (1 commits) (flutter/engine#6529)
9033c39 Roll src/third_party/skia 7e67041a1428..b28db529c866 (1 commits) (flutter/engine#6528)
e6887a4 Add missing imports for unicode/utf16.h (flutter/engine#6524)
1242f6d Roll src/third_party/skia d38382d060ca..7e67041a1428 (2 commits) (flutter/engine#6527)
a1bbea7 Add a no-op platform view layer. (flutter/engine#6505)
2bb3afa Roll src/third_party/skia 21bd60daa3f3..d38382d060ca (10 commits) (flutter/engine#6526)
75e8752 Fix the Mac embedder build (flutter/engine#6525)
436f970 Add version check for dismissable (flutter/engine#6522)
7767c78 Provide a default GL function resolver in the embedder (flutter/engine#6523)
32841dd Case-insensitive matching of family names for custom fonts (flutter/engine#6519)
a9076c7 Roll src/third_party/skia 419709dbb167..21bd60daa3f3 (11 commits) (flutter/engine#6520)
f2e7441 An API for loading fonts from a buffer provided by the application (flutter/engine#6508)
05aac0f fix ResourceExtractor npe. (flutter/engine#6461)
cf5a2a1 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (flutter/engine#6517)
84fe4a9 Re-revert invalid line height tests (flutter/engine#6516)
5f52956 Add support for text shadows (flutter/engine#6385)
e44c10c Reland "Share engine layers with the framework" (flutter#6412) (flutter/engine#6468)
ba04499 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter/engine#6515)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
This was referenced Oct 14, 2018
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 15, 2018
@engine-flutter-autoroll
Roll engine 50c2e69..ff93ccf (22 commits)
269b8d4 
flutter/engine@50c2e69...ff93ccf

git log 50c2e69..ff93ccf --no-merges --oneline
ff93ccf Roll src/third_party/skia 681692726fc0..2b2c00f6ec36 (1 commits) (flutter/engine#6534)
a4161c8 Roll src/third_party/skia 23775a2e9736..681692726fc0 (1 commits) (flutter/engine#6532)
116072e Roll src/third_party/skia 7435f2553f53..23775a2e9736 (1 commits) (flutter/engine#6531)
ef0b0f6 Roll src/third_party/skia bc7a51e79c5b..7435f2553f53 (1 commits) (flutter/engine#6530)
f46b7b9 Roll src/third_party/skia b28db529c866..bc7a51e79c5b (1 commits) (flutter/engine#6529)
9033c39 Roll src/third_party/skia 7e67041a1428..b28db529c866 (1 commits) (flutter/engine#6528)
e6887a4 Add missing imports for unicode/utf16.h (flutter/engine#6524)
1242f6d Roll src/third_party/skia d38382d060ca..7e67041a1428 (2 commits) (flutter/engine#6527)
a1bbea7 Add a no-op platform view layer. (flutter/engine#6505)
2bb3afa Roll src/third_party/skia 21bd60daa3f3..d38382d060ca (10 commits) (flutter/engine#6526)
75e8752 Fix the Mac embedder build (flutter/engine#6525)
436f970 Add version check for dismissable (flutter/engine#6522)
7767c78 Provide a default GL function resolver in the embedder (flutter/engine#6523)
32841dd Case-insensitive matching of family names for custom fonts (flutter/engine#6519)
a9076c7 Roll src/third_party/skia 419709dbb167..21bd60daa3f3 (11 commits) (flutter/engine#6520)
f2e7441 An API for loading fonts from a buffer provided by the application (flutter/engine#6508)
05aac0f fix ResourceExtractor npe. (flutter/engine#6461)
cf5a2a1 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (flutter/engine#6517)
84fe4a9 Re-revert invalid line height tests (flutter/engine#6516)
5f52956 Add support for text shadows (flutter/engine#6385)
e44c10c Reland "Share engine layers with the framework" (flutter#6412) (flutter/engine#6468)
ba04499 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter/engine#6515)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 15, 2018
@engine-flutter-autoroll
Roll engine 50c2e69..d4bae4c (23 commits)
5a279a6 
flutter/engine@50c2e69...d4bae4c

git log 50c2e69..d4bae4c --no-merges --oneline
d4bae4c Roll src/third_party/skia 2b2c00f6ec36..646d917d3c71 (1 commits) (flutter/engine#6535)
ff93ccf Roll src/third_party/skia 681692726fc0..2b2c00f6ec36 (1 commits) (flutter/engine#6534)
a4161c8 Roll src/third_party/skia 23775a2e9736..681692726fc0 (1 commits) (flutter/engine#6532)
116072e Roll src/third_party/skia 7435f2553f53..23775a2e9736 (1 commits) (flutter/engine#6531)
ef0b0f6 Roll src/third_party/skia bc7a51e79c5b..7435f2553f53 (1 commits) (flutter/engine#6530)
f46b7b9 Roll src/third_party/skia b28db529c866..bc7a51e79c5b (1 commits) (flutter/engine#6529)
9033c39 Roll src/third_party/skia 7e67041a1428..b28db529c866 (1 commits) (flutter/engine#6528)
e6887a4 Add missing imports for unicode/utf16.h (flutter/engine#6524)
1242f6d Roll src/third_party/skia d38382d060ca..7e67041a1428 (2 commits) (flutter/engine#6527)
a1bbea7 Add a no-op platform view layer. (flutter/engine#6505)
2bb3afa Roll src/third_party/skia 21bd60daa3f3..d38382d060ca (10 commits) (flutter/engine#6526)
75e8752 Fix the Mac embedder build (flutter/engine#6525)
436f970 Add version check for dismissable (flutter/engine#6522)
7767c78 Provide a default GL function resolver in the embedder (flutter/engine#6523)
32841dd Case-insensitive matching of family names for custom fonts (flutter/engine#6519)
a9076c7 Roll src/third_party/skia 419709dbb167..21bd60daa3f3 (11 commits) (flutter/engine#6520)
f2e7441 An API for loading fonts from a buffer provided by the application (flutter/engine#6508)
05aac0f fix ResourceExtractor npe. (flutter/engine#6461)
cf5a2a1 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (flutter/engine#6517)
84fe4a9 Re-revert invalid line height tests (flutter/engine#6516)
5f52956 Add support for text shadows (flutter/engine#6385)
e44c10c Reland "Share engine layers with the framework" (flutter#6412) (flutter/engine#6468)
ba04499 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter/engine#6515)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 15, 2018
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 15, 2018
@engine-flutter-autoroll
Roll engine 50c2e69..964acaf (24 commits)
9e34250 
flutter/engine@50c2e69...964acaf

git log 50c2e69..964acaf --no-merges --oneline
964acaf Roll src/third_party/skia 646d917d3c71..c6a17104ad68 (1 commits) (flutter/engine#6536)
d4bae4c Roll src/third_party/skia 2b2c00f6ec36..646d917d3c71 (1 commits) (flutter/engine#6535)
ff93ccf Roll src/third_party/skia 681692726fc0..2b2c00f6ec36 (1 commits) (flutter/engine#6534)
a4161c8 Roll src/third_party/skia 23775a2e9736..681692726fc0 (1 commits) (flutter/engine#6532)
116072e Roll src/third_party/skia 7435f2553f53..23775a2e9736 (1 commits) (flutter/engine#6531)
ef0b0f6 Roll src/third_party/skia bc7a51e79c5b..7435f2553f53 (1 commits) (flutter/engine#6530)
f46b7b9 Roll src/third_party/skia b28db529c866..bc7a51e79c5b (1 commits) (flutter/engine#6529)
9033c39 Roll src/third_party/skia 7e67041a1428..b28db529c866 (1 commits) (flutter/engine#6528)
e6887a4 Add missing imports for unicode/utf16.h (flutter/engine#6524)
1242f6d Roll src/third_party/skia d38382d060ca..7e67041a1428 (2 commits) (flutter/engine#6527)
a1bbea7 Add a no-op platform view layer. (flutter/engine#6505)
2bb3afa Roll src/third_party/skia 21bd60daa3f3..d38382d060ca (10 commits) (flutter/engine#6526)
75e8752 Fix the Mac embedder build (flutter/engine#6525)
436f970 Add version check for dismissable (flutter/engine#6522)
7767c78 Provide a default GL function resolver in the embedder (flutter/engine#6523)
32841dd Case-insensitive matching of family names for custom fonts (flutter/engine#6519)
a9076c7 Roll src/third_party/skia 419709dbb167..21bd60daa3f3 (11 commits) (flutter/engine#6520)
f2e7441 An API for loading fonts from a buffer provided by the application (flutter/engine#6508)
05aac0f fix ResourceExtractor npe. (flutter/engine#6461)
cf5a2a1 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (flutter/engine#6517)
84fe4a9 Re-revert invalid line height tests (flutter/engine#6516)
5f52956 Add support for text shadows (flutter/engine#6385)
e44c10c Reland "Share engine layers with the framework" (flutter#6412) (flutter/engine#6468)
ba04499 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter/engine#6515)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
This was referenced Oct 15, 2018
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 15, 2018
@engine-flutter-autoroll
Roll engine 50c2e69..4ee7725 (25 commits)
caca832 
flutter/engine@50c2e69...4ee7725

git log 50c2e69..4ee7725 --no-merges --oneline
4ee7725 Revert "Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter#6515)" (flutter/engine#6537)
964acaf Roll src/third_party/skia 646d917d3c71..c6a17104ad68 (1 commits) (flutter/engine#6536)
d4bae4c Roll src/third_party/skia 2b2c00f6ec36..646d917d3c71 (1 commits) (flutter/engine#6535)
ff93ccf Roll src/third_party/skia 681692726fc0..2b2c00f6ec36 (1 commits) (flutter/engine#6534)
a4161c8 Roll src/third_party/skia 23775a2e9736..681692726fc0 (1 commits) (flutter/engine#6532)
116072e Roll src/third_party/skia 7435f2553f53..23775a2e9736 (1 commits) (flutter/engine#6531)
ef0b0f6 Roll src/third_party/skia bc7a51e79c5b..7435f2553f53 (1 commits) (flutter/engine#6530)
f46b7b9 Roll src/third_party/skia b28db529c866..bc7a51e79c5b (1 commits) (flutter/engine#6529)
9033c39 Roll src/third_party/skia 7e67041a1428..b28db529c866 (1 commits) (flutter/engine#6528)
e6887a4 Add missing imports for unicode/utf16.h (flutter/engine#6524)
1242f6d Roll src/third_party/skia d38382d060ca..7e67041a1428 (2 commits) (flutter/engine#6527)
a1bbea7 Add a no-op platform view layer. (flutter/engine#6505)
2bb3afa Roll src/third_party/skia 21bd60daa3f3..d38382d060ca (10 commits) (flutter/engine#6526)
75e8752 Fix the Mac embedder build (flutter/engine#6525)
436f970 Add version check for dismissable (flutter/engine#6522)
7767c78 Provide a default GL function resolver in the embedder (flutter/engine#6523)
32841dd Case-insensitive matching of family names for custom fonts (flutter/engine#6519)
a9076c7 Roll src/third_party/skia 419709dbb167..21bd60daa3f3 (11 commits) (flutter/engine#6520)
f2e7441 An API for loading fonts from a buffer provided by the application (flutter/engine#6508)
05aac0f fix ResourceExtractor npe. (flutter/engine#6461)
cf5a2a1 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (flutter/engine#6517)
84fe4a9 Re-revert invalid line height tests (flutter/engine#6516)
5f52956 Add support for text shadows (flutter/engine#6385)
e44c10c Reland "Share engine layers with the framework" (flutter#6412) (flutter/engine#6468)
ba04499 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter/engine#6515)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 15, 2018
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 15, 2018
@engine-flutter-autoroll
Roll engine 50c2e69..32f417d (26 commits)
2d4d853 
flutter/engine@50c2e69...32f417d

git log 50c2e69..32f417d --no-merges --oneline
32f417d Roll tonic to 077be256142ede39a271385907faadf4fcc62a4d. (flutter/engine#6541)
4ee7725 Revert "Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter#6515)" (flutter/engine#6537)
964acaf Roll src/third_party/skia 646d917d3c71..c6a17104ad68 (1 commits) (flutter/engine#6536)
d4bae4c Roll src/third_party/skia 2b2c00f6ec36..646d917d3c71 (1 commits) (flutter/engine#6535)
ff93ccf Roll src/third_party/skia 681692726fc0..2b2c00f6ec36 (1 commits) (flutter/engine#6534)
a4161c8 Roll src/third_party/skia 23775a2e9736..681692726fc0 (1 commits) (flutter/engine#6532)
116072e Roll src/third_party/skia 7435f2553f53..23775a2e9736 (1 commits) (flutter/engine#6531)
ef0b0f6 Roll src/third_party/skia bc7a51e79c5b..7435f2553f53 (1 commits) (flutter/engine#6530)
f46b7b9 Roll src/third_party/skia b28db529c866..bc7a51e79c5b (1 commits) (flutter/engine#6529)
9033c39 Roll src/third_party/skia 7e67041a1428..b28db529c866 (1 commits) (flutter/engine#6528)
e6887a4 Add missing imports for unicode/utf16.h (flutter/engine#6524)
1242f6d Roll src/third_party/skia d38382d060ca..7e67041a1428 (2 commits) (flutter/engine#6527)
a1bbea7 Add a no-op platform view layer. (flutter/engine#6505)
2bb3afa Roll src/third_party/skia 21bd60daa3f3..d38382d060ca (10 commits) (flutter/engine#6526)
75e8752 Fix the Mac embedder build (flutter/engine#6525)
436f970 Add version check for dismissable (flutter/engine#6522)
7767c78 Provide a default GL function resolver in the embedder (flutter/engine#6523)
32841dd Case-insensitive matching of family names for custom fonts (flutter/engine#6519)
a9076c7 Roll src/third_party/skia 419709dbb167..21bd60daa3f3 (11 commits) (flutter/engine#6520)
f2e7441 An API for loading fonts from a buffer provided by the application (flutter/engine#6508)
05aac0f fix ResourceExtractor npe. (flutter/engine#6461)
cf5a2a1 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (flutter/engine#6517)
84fe4a9 Re-revert invalid line height tests (flutter/engine#6516)
5f52956 Add support for text shadows (flutter/engine#6385)
e44c10c Reland "Share engine layers with the framework" (flutter#6412) (flutter/engine#6468)
ba04499 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter/engine#6515)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 15, 2018
@engine-flutter-autoroll
Roll engine 50c2e69..c645657 (27 commits)
5e26e63 
flutter/engine@50c2e69...c645657

git log 50c2e69..c645657 --no-merges --oneline
c645657 Roll src/third_party/skia c6a17104ad68..921ec976556c (31 commits) (flutter/engine#6546)
32f417d Roll tonic to 077be256142ede39a271385907faadf4fcc62a4d. (flutter/engine#6541)
4ee7725 Revert "Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter#6515)" (flutter/engine#6537)
964acaf Roll src/third_party/skia 646d917d3c71..c6a17104ad68 (1 commits) (flutter/engine#6536)
d4bae4c Roll src/third_party/skia 2b2c00f6ec36..646d917d3c71 (1 commits) (flutter/engine#6535)
ff93ccf Roll src/third_party/skia 681692726fc0..2b2c00f6ec36 (1 commits) (flutter/engine#6534)
a4161c8 Roll src/third_party/skia 23775a2e9736..681692726fc0 (1 commits) (flutter/engine#6532)
116072e Roll src/third_party/skia 7435f2553f53..23775a2e9736 (1 commits) (flutter/engine#6531)
ef0b0f6 Roll src/third_party/skia bc7a51e79c5b..7435f2553f53 (1 commits) (flutter/engine#6530)
f46b7b9 Roll src/third_party/skia b28db529c866..bc7a51e79c5b (1 commits) (flutter/engine#6529)
9033c39 Roll src/third_party/skia 7e67041a1428..b28db529c866 (1 commits) (flutter/engine#6528)
e6887a4 Add missing imports for unicode/utf16.h (flutter/engine#6524)
1242f6d Roll src/third_party/skia d38382d060ca..7e67041a1428 (2 commits) (flutter/engine#6527)
a1bbea7 Add a no-op platform view layer. (flutter/engine#6505)
2bb3afa Roll src/third_party/skia 21bd60daa3f3..d38382d060ca (10 commits) (flutter/engine#6526)
75e8752 Fix the Mac embedder build (flutter/engine#6525)
436f970 Add version check for dismissable (flutter/engine#6522)
7767c78 Provide a default GL function resolver in the embedder (flutter/engine#6523)
32841dd Case-insensitive matching of family names for custom fonts (flutter/engine#6519)
a9076c7 Roll src/third_party/skia 419709dbb167..21bd60daa3f3 (11 commits) (flutter/engine#6520)
f2e7441 An API for loading fonts from a buffer provided by the application (flutter/engine#6508)
05aac0f fix ResourceExtractor npe. (flutter/engine#6461)
cf5a2a1 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (flutter/engine#6517)
84fe4a9 Re-revert invalid line height tests (flutter/engine#6516)
5f52956 Add support for text shadows (flutter/engine#6385)
e44c10c Reland "Share engine layers with the framework" (flutter#6412) (flutter/engine#6468)
ba04499 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter/engine#6515)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 15, 2018
Closed
@liyuqian liyuqian mentioned this pull request Oct 17, 2018
Closed
@liyuqian liyuqian deleted the shared_layers3 branch November 12, 2018 18:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@alexmarkov alexmarkov alexmarkov left review comments

@chinmaygarde chinmaygarde chinmaygarde approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@liyuqian @chinmaygarde @alexmarkov @googlebot