Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

fix ResourceExtractor npe. #6461

Merged
jason-simmons merged 1 commit into from
Oct 12, 2018
Merged

fix ResourceExtractor npe. #6461

jason-simmons merged 1 commit into from
Oct 12, 2018

Conversation

@SupSaiYaJin
Copy link
Contributor

@SupSaiYaJin SupSaiYaJin commented Oct 8, 2018

getExistingTimestamps method will return null once in a while, causes to some crashes online.
Simply add some npe protections for it.

@googlebot
Copy link

googlebot commented Oct 8, 2018

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

1 similar comment
@googlebot
Copy link

googlebot commented Oct 8, 2018

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@googlebot
Copy link

googlebot commented Oct 8, 2018

CLAs look good, thanks!

1 similar comment
@googlebot
Copy link

googlebot commented Oct 8, 2018

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Oct 8, 2018
@jason-simmons jason-simmons merged commit 05aac0f into flutter:master Oct 12, 2018
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 12, 2018
@engine-flutter-autoroll
Roll engine 3ffa362..05aac0f (9 commits)
d8046c4 
flutter/engine@3ffa362...05aac0f

git log 3ffa362..05aac0f --no-merges --oneline
05aac0f fix ResourceExtractor npe. (flutter/engine#6461)
cf5a2a1 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (flutter/engine#6517)
84fe4a9 Re-revert invalid line height tests (flutter/engine#6516)
5f52956 Add support for text shadows (flutter/engine#6385)
e44c10c Reland "Share engine layers with the framework" (flutter#6412) (flutter/engine#6468)
ba04499 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter/engine#6515)
50c2e69 Roll src/third_party/skia 1b62fad4b188..b27a9cf2f4a8 (1 commits) (flutter/engine#6514)
8757bf2 Roll src/third_party/skia 05caa69a3f5a..1b62fad4b188 (2 commits) (flutter/engine#6513)
c2fd10a Roll src/third_party/skia 2a138544646d..05caa69a3f5a (1 commits) (flutter/engine#6512)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 12, 2018
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 12, 2018
@engine-flutter-autoroll
Roll engine 3ffa362..f2e7441 (10 commits)
9566cdb 
flutter/engine@3ffa362...f2e7441

git log 3ffa362..f2e7441 --no-merges --oneline
f2e7441 An API for loading fonts from a buffer provided by the application (flutter/engine#6508)
05aac0f fix ResourceExtractor npe. (flutter/engine#6461)
cf5a2a1 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (flutter/engine#6517)
84fe4a9 Re-revert invalid line height tests (flutter/engine#6516)
5f52956 Add support for text shadows (flutter/engine#6385)
e44c10c Reland "Share engine layers with the framework" (flutter#6412) (flutter/engine#6468)
ba04499 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter/engine#6515)
50c2e69 Roll src/third_party/skia 1b62fad4b188..b27a9cf2f4a8 (1 commits) (flutter/engine#6514)
8757bf2 Roll src/third_party/skia 05caa69a3f5a..1b62fad4b188 (2 commits) (flutter/engine#6513)
c2fd10a Roll src/third_party/skia 2a138544646d..05caa69a3f5a (1 commits) (flutter/engine#6512)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 12, 2018
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 12, 2018
@engine-flutter-autoroll
Roll engine 3ffa362..f2e7441 (10 commits)
2018c94 
flutter/engine@3ffa362...f2e7441

git log 3ffa362..f2e7441 --no-merges --oneline
f2e7441 An API for loading fonts from a buffer provided by the application (flutter/engine#6508)
05aac0f fix ResourceExtractor npe. (flutter/engine#6461)
cf5a2a1 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (flutter/engine#6517)
84fe4a9 Re-revert invalid line height tests (flutter/engine#6516)
5f52956 Add support for text shadows (flutter/engine#6385)
e44c10c Reland "Share engine layers with the framework" (flutter#6412) (flutter/engine#6468)
ba04499 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter/engine#6515)
50c2e69 Roll src/third_party/skia 1b62fad4b188..b27a9cf2f4a8 (1 commits) (flutter/engine#6514)
8757bf2 Roll src/third_party/skia 05caa69a3f5a..1b62fad4b188 (2 commits) (flutter/engine#6513)
c2fd10a Roll src/third_party/skia 2a138544646d..05caa69a3f5a (1 commits) (flutter/engine#6512)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 12, 2018
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 12, 2018
@engine-flutter-autoroll
Roll engine 50c2e69..f2e7441 (7 commits)
0ec249d 
flutter/engine@50c2e69...f2e7441

git log 50c2e69..f2e7441 --no-merges --oneline
f2e7441 An API for loading fonts from a buffer provided by the application (flutter/engine#6508)
05aac0f fix ResourceExtractor npe. (flutter/engine#6461)
cf5a2a1 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (flutter/engine#6517)
84fe4a9 Re-revert invalid line height tests (flutter/engine#6516)
5f52956 Add support for text shadows (flutter/engine#6385)
e44c10c Reland "Share engine layers with the framework" (flutter#6412) (flutter/engine#6468)
ba04499 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter/engine#6515)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 12, 2018
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 12, 2018
@engine-flutter-autoroll
Roll engine 50c2e69..a9076c7 (8 commits)
74c6466 
flutter/engine@50c2e69...a9076c7

git log 50c2e69..a9076c7 --no-merges --oneline
a9076c7 Roll src/third_party/skia 419709dbb167..21bd60daa3f3 (11 commits) (flutter/engine#6520)
f2e7441 An API for loading fonts from a buffer provided by the application (flutter/engine#6508)
05aac0f fix ResourceExtractor npe. (flutter/engine#6461)
cf5a2a1 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (flutter/engine#6517)
84fe4a9 Re-revert invalid line height tests (flutter/engine#6516)
5f52956 Add support for text shadows (flutter/engine#6385)
e44c10c Reland "Share engine layers with the framework" (flutter#6412) (flutter/engine#6468)
ba04499 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter/engine#6515)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 12, 2018
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 12, 2018
@engine-flutter-autoroll
Roll engine 50c2e69..32841dd (9 commits)
1a75c66 
flutter/engine@50c2e69...32841dd

git log 50c2e69..32841dd --no-merges --oneline
32841dd Case-insensitive matching of family names for custom fonts (flutter/engine#6519)
a9076c7 Roll src/third_party/skia 419709dbb167..21bd60daa3f3 (11 commits) (flutter/engine#6520)
f2e7441 An API for loading fonts from a buffer provided by the application (flutter/engine#6508)
05aac0f fix ResourceExtractor npe. (flutter/engine#6461)
cf5a2a1 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (flutter/engine#6517)
84fe4a9 Re-revert invalid line height tests (flutter/engine#6516)
5f52956 Add support for text shadows (flutter/engine#6385)
e44c10c Reland "Share engine layers with the framework" (flutter#6412) (flutter/engine#6468)
ba04499 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter/engine#6515)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 12, 2018
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 13, 2018
@engine-flutter-autoroll
Roll engine 50c2e69..75e8752 (12 commits)
2f6a2ec 
flutter/engine@50c2e69...75e8752

git log 50c2e69..75e8752 --no-merges --oneline
75e8752 Fix the Mac embedder build (flutter/engine#6525)
436f970 Add version check for dismissable (flutter/engine#6522)
7767c78 Provide a default GL function resolver in the embedder (flutter/engine#6523)
32841dd Case-insensitive matching of family names for custom fonts (flutter/engine#6519)
a9076c7 Roll src/third_party/skia 419709dbb167..21bd60daa3f3 (11 commits) (flutter/engine#6520)
f2e7441 An API for loading fonts from a buffer provided by the application (flutter/engine#6508)
05aac0f fix ResourceExtractor npe. (flutter/engine#6461)
cf5a2a1 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (flutter/engine#6517)
84fe4a9 Re-revert invalid line height tests (flutter/engine#6516)
5f52956 Add support for text shadows (flutter/engine#6385)
e44c10c Reland "Share engine layers with the framework" (flutter#6412) (flutter/engine#6468)
ba04499 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter/engine#6515)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 13, 2018
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 13, 2018
@engine-flutter-autoroll
Roll engine 50c2e69..2bb3afa (13 commits)
5d4ada5 
flutter/engine@50c2e69...2bb3afa

git log 50c2e69..2bb3afa --no-merges --oneline
2bb3afa Roll src/third_party/skia 21bd60daa3f3..d38382d060ca (10 commits) (flutter/engine#6526)
75e8752 Fix the Mac embedder build (flutter/engine#6525)
436f970 Add version check for dismissable (flutter/engine#6522)
7767c78 Provide a default GL function resolver in the embedder (flutter/engine#6523)
32841dd Case-insensitive matching of family names for custom fonts (flutter/engine#6519)
a9076c7 Roll src/third_party/skia 419709dbb167..21bd60daa3f3 (11 commits) (flutter/engine#6520)
f2e7441 An API for loading fonts from a buffer provided by the application (flutter/engine#6508)
05aac0f fix ResourceExtractor npe. (flutter/engine#6461)
cf5a2a1 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (flutter/engine#6517)
84fe4a9 Re-revert invalid line height tests (flutter/engine#6516)
5f52956 Add support for text shadows (flutter/engine#6385)
e44c10c Reland "Share engine layers with the framework" (flutter#6412) (flutter/engine#6468)
ba04499 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter/engine#6515)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 13, 2018
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 13, 2018
@engine-flutter-autoroll
Roll engine 50c2e69..a1bbea7 (14 commits)
4f39a28 
flutter/engine@50c2e69...a1bbea7

git log 50c2e69..a1bbea7 --no-merges --oneline
a1bbea7 Add a no-op platform view layer. (flutter/engine#6505)
2bb3afa Roll src/third_party/skia 21bd60daa3f3..d38382d060ca (10 commits) (flutter/engine#6526)
75e8752 Fix the Mac embedder build (flutter/engine#6525)
436f970 Add version check for dismissable (flutter/engine#6522)
7767c78 Provide a default GL function resolver in the embedder (flutter/engine#6523)
32841dd Case-insensitive matching of family names for custom fonts (flutter/engine#6519)
a9076c7 Roll src/third_party/skia 419709dbb167..21bd60daa3f3 (11 commits) (flutter/engine#6520)
f2e7441 An API for loading fonts from a buffer provided by the application (flutter/engine#6508)
05aac0f fix ResourceExtractor npe. (flutter/engine#6461)
cf5a2a1 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (flutter/engine#6517)
84fe4a9 Re-revert invalid line height tests (flutter/engine#6516)
5f52956 Add support for text shadows (flutter/engine#6385)
e44c10c Reland "Share engine layers with the framework" (flutter#6412) (flutter/engine#6468)
ba04499 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter/engine#6515)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 13, 2018
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 13, 2018
@engine-flutter-autoroll
Roll engine 50c2e69..1242f6d (15 commits)
efbe465 
flutter/engine@50c2e69...1242f6d

git log 50c2e69..1242f6d --no-merges --oneline
1242f6d Roll src/third_party/skia d38382d060ca..7e67041a1428 (2 commits) (flutter/engine#6527)
a1bbea7 Add a no-op platform view layer. (flutter/engine#6505)
2bb3afa Roll src/third_party/skia 21bd60daa3f3..d38382d060ca (10 commits) (flutter/engine#6526)
75e8752 Fix the Mac embedder build (flutter/engine#6525)
436f970 Add version check for dismissable (flutter/engine#6522)
7767c78 Provide a default GL function resolver in the embedder (flutter/engine#6523)
32841dd Case-insensitive matching of family names for custom fonts (flutter/engine#6519)
a9076c7 Roll src/third_party/skia 419709dbb167..21bd60daa3f3 (11 commits) (flutter/engine#6520)
f2e7441 An API for loading fonts from a buffer provided by the application (flutter/engine#6508)
05aac0f fix ResourceExtractor npe. (flutter/engine#6461)
cf5a2a1 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (flutter/engine#6517)
84fe4a9 Re-revert invalid line height tests (flutter/engine#6516)
5f52956 Add support for text shadows (flutter/engine#6385)
e44c10c Reland "Share engine layers with the framework" (flutter#6412) (flutter/engine#6468)
ba04499 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter/engine#6515)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 13, 2018
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 13, 2018
@engine-flutter-autoroll
Roll engine 50c2e69..e6887a4 (16 commits)
cefc450 
flutter/engine@50c2e69...e6887a4

git log 50c2e69..e6887a4 --no-merges --oneline
e6887a4 Add missing imports for unicode/utf16.h (flutter/engine#6524)
1242f6d Roll src/third_party/skia d38382d060ca..7e67041a1428 (2 commits) (flutter/engine#6527)
a1bbea7 Add a no-op platform view layer. (flutter/engine#6505)
2bb3afa Roll src/third_party/skia 21bd60daa3f3..d38382d060ca (10 commits) (flutter/engine#6526)
75e8752 Fix the Mac embedder build (flutter/engine#6525)
436f970 Add version check for dismissable (flutter/engine#6522)
7767c78 Provide a default GL function resolver in the embedder (flutter/engine#6523)
32841dd Case-insensitive matching of family names for custom fonts (flutter/engine#6519)
a9076c7 Roll src/third_party/skia 419709dbb167..21bd60daa3f3 (11 commits) (flutter/engine#6520)
f2e7441 An API for loading fonts from a buffer provided by the application (flutter/engine#6508)
05aac0f fix ResourceExtractor npe. (flutter/engine#6461)
cf5a2a1 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (flutter/engine#6517)
84fe4a9 Re-revert invalid line height tests (flutter/engine#6516)
5f52956 Add support for text shadows (flutter/engine#6385)
e44c10c Reland "Share engine layers with the framework" (flutter#6412) (flutter/engine#6468)
ba04499 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter/engine#6515)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
This was referenced Oct 13, 2018
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 13, 2018
@engine-flutter-autoroll
Roll engine 50c2e69..9033c39 (17 commits)
aa8c346 
flutter/engine@50c2e69...9033c39

git log 50c2e69..9033c39 --no-merges --oneline
9033c39 Roll src/third_party/skia 7e67041a1428..b28db529c866 (1 commits) (flutter/engine#6528)
e6887a4 Add missing imports for unicode/utf16.h (flutter/engine#6524)
1242f6d Roll src/third_party/skia d38382d060ca..7e67041a1428 (2 commits) (flutter/engine#6527)
a1bbea7 Add a no-op platform view layer. (flutter/engine#6505)
2bb3afa Roll src/third_party/skia 21bd60daa3f3..d38382d060ca (10 commits) (flutter/engine#6526)
75e8752 Fix the Mac embedder build (flutter/engine#6525)
436f970 Add version check for dismissable (flutter/engine#6522)
7767c78 Provide a default GL function resolver in the embedder (flutter/engine#6523)
32841dd Case-insensitive matching of family names for custom fonts (flutter/engine#6519)
a9076c7 Roll src/third_party/skia 419709dbb167..21bd60daa3f3 (11 commits) (flutter/engine#6520)
f2e7441 An API for loading fonts from a buffer provided by the application (flutter/engine#6508)
05aac0f fix ResourceExtractor npe. (flutter/engine#6461)
cf5a2a1 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (flutter/engine#6517)
84fe4a9 Re-revert invalid line height tests (flutter/engine#6516)
5f52956 Add support for text shadows (flutter/engine#6385)
e44c10c Reland "Share engine layers with the framework" (flutter#6412) (flutter/engine#6468)
ba04499 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter/engine#6515)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 13, 2018
@engine-flutter-autoroll
Roll engine 50c2e69..f46b7b9 (18 commits)
f2d6ebc 
flutter/engine@50c2e69...f46b7b9

git log 50c2e69..f46b7b9 --no-merges --oneline
f46b7b9 Roll src/third_party/skia b28db529c866..bc7a51e79c5b (1 commits) (flutter/engine#6529)
9033c39 Roll src/third_party/skia 7e67041a1428..b28db529c866 (1 commits) (flutter/engine#6528)
e6887a4 Add missing imports for unicode/utf16.h (flutter/engine#6524)
1242f6d Roll src/third_party/skia d38382d060ca..7e67041a1428 (2 commits) (flutter/engine#6527)
a1bbea7 Add a no-op platform view layer. (flutter/engine#6505)
2bb3afa Roll src/third_party/skia 21bd60daa3f3..d38382d060ca (10 commits) (flutter/engine#6526)
75e8752 Fix the Mac embedder build (flutter/engine#6525)
436f970 Add version check for dismissable (flutter/engine#6522)
7767c78 Provide a default GL function resolver in the embedder (flutter/engine#6523)
32841dd Case-insensitive matching of family names for custom fonts (flutter/engine#6519)
a9076c7 Roll src/third_party/skia 419709dbb167..21bd60daa3f3 (11 commits) (flutter/engine#6520)
f2e7441 An API for loading fonts from a buffer provided by the application (flutter/engine#6508)
05aac0f fix ResourceExtractor npe. (flutter/engine#6461)
cf5a2a1 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (flutter/engine#6517)
84fe4a9 Re-revert invalid line height tests (flutter/engine#6516)
5f52956 Add support for text shadows (flutter/engine#6385)
e44c10c Reland "Share engine layers with the framework" (flutter#6412) (flutter/engine#6468)
ba04499 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter/engine#6515)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
This was referenced Oct 13, 2018
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 13, 2018
@engine-flutter-autoroll
Roll engine 50c2e69..ef0b0f6 (19 commits)
e3080bf 
flutter/engine@50c2e69...ef0b0f6

git log 50c2e69..ef0b0f6 --no-merges --oneline
ef0b0f6 Roll src/third_party/skia bc7a51e79c5b..7435f2553f53 (1 commits) (flutter/engine#6530)
f46b7b9 Roll src/third_party/skia b28db529c866..bc7a51e79c5b (1 commits) (flutter/engine#6529)
9033c39 Roll src/third_party/skia 7e67041a1428..b28db529c866 (1 commits) (flutter/engine#6528)
e6887a4 Add missing imports for unicode/utf16.h (flutter/engine#6524)
1242f6d Roll src/third_party/skia d38382d060ca..7e67041a1428 (2 commits) (flutter/engine#6527)
a1bbea7 Add a no-op platform view layer. (flutter/engine#6505)
2bb3afa Roll src/third_party/skia 21bd60daa3f3..d38382d060ca (10 commits) (flutter/engine#6526)
75e8752 Fix the Mac embedder build (flutter/engine#6525)
436f970 Add version check for dismissable (flutter/engine#6522)
7767c78 Provide a default GL function resolver in the embedder (flutter/engine#6523)
32841dd Case-insensitive matching of family names for custom fonts (flutter/engine#6519)
a9076c7 Roll src/third_party/skia 419709dbb167..21bd60daa3f3 (11 commits) (flutter/engine#6520)
f2e7441 An API for loading fonts from a buffer provided by the application (flutter/engine#6508)
05aac0f fix ResourceExtractor npe. (flutter/engine#6461)
cf5a2a1 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (flutter/engine#6517)
84fe4a9 Re-revert invalid line height tests (flutter/engine#6516)
5f52956 Add support for text shadows (flutter/engine#6385)
e44c10c Reland "Share engine layers with the framework" (flutter#6412) (flutter/engine#6468)
ba04499 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter/engine#6515)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 14, 2018
@engine-flutter-autoroll
Roll engine 50c2e69..116072e (20 commits)
48eb043 
flutter/engine@50c2e69...116072e

git log 50c2e69..116072e --no-merges --oneline
116072e Roll src/third_party/skia 7435f2553f53..23775a2e9736 (1 commits) (flutter/engine#6531)
ef0b0f6 Roll src/third_party/skia bc7a51e79c5b..7435f2553f53 (1 commits) (flutter/engine#6530)
f46b7b9 Roll src/third_party/skia b28db529c866..bc7a51e79c5b (1 commits) (flutter/engine#6529)
9033c39 Roll src/third_party/skia 7e67041a1428..b28db529c866 (1 commits) (flutter/engine#6528)
e6887a4 Add missing imports for unicode/utf16.h (flutter/engine#6524)
1242f6d Roll src/third_party/skia d38382d060ca..7e67041a1428 (2 commits) (flutter/engine#6527)
a1bbea7 Add a no-op platform view layer. (flutter/engine#6505)
2bb3afa Roll src/third_party/skia 21bd60daa3f3..d38382d060ca (10 commits) (flutter/engine#6526)
75e8752 Fix the Mac embedder build (flutter/engine#6525)
436f970 Add version check for dismissable (flutter/engine#6522)
7767c78 Provide a default GL function resolver in the embedder (flutter/engine#6523)
32841dd Case-insensitive matching of family names for custom fonts (flutter/engine#6519)
a9076c7 Roll src/third_party/skia 419709dbb167..21bd60daa3f3 (11 commits) (flutter/engine#6520)
f2e7441 An API for loading fonts from a buffer provided by the application (flutter/engine#6508)
05aac0f fix ResourceExtractor npe. (flutter/engine#6461)
cf5a2a1 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (flutter/engine#6517)
84fe4a9 Re-revert invalid line height tests (flutter/engine#6516)
5f52956 Add support for text shadows (flutter/engine#6385)
e44c10c Reland "Share engine layers with the framework" (flutter#6412) (flutter/engine#6468)
ba04499 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter/engine#6515)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 14, 2018
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 14, 2018
@engine-flutter-autoroll
Roll engine 50c2e69..a4161c8 (21 commits)
532ff5b 
flutter/engine@50c2e69...a4161c8

git log 50c2e69..a4161c8 --no-merges --oneline
a4161c8 Roll src/third_party/skia 23775a2e9736..681692726fc0 (1 commits) (flutter/engine#6532)
116072e Roll src/third_party/skia 7435f2553f53..23775a2e9736 (1 commits) (flutter/engine#6531)
ef0b0f6 Roll src/third_party/skia bc7a51e79c5b..7435f2553f53 (1 commits) (flutter/engine#6530)
f46b7b9 Roll src/third_party/skia b28db529c866..bc7a51e79c5b (1 commits) (flutter/engine#6529)
9033c39 Roll src/third_party/skia 7e67041a1428..b28db529c866 (1 commits) (flutter/engine#6528)
e6887a4 Add missing imports for unicode/utf16.h (flutter/engine#6524)
1242f6d Roll src/third_party/skia d38382d060ca..7e67041a1428 (2 commits) (flutter/engine#6527)
a1bbea7 Add a no-op platform view layer. (flutter/engine#6505)
2bb3afa Roll src/third_party/skia 21bd60daa3f3..d38382d060ca (10 commits) (flutter/engine#6526)
75e8752 Fix the Mac embedder build (flutter/engine#6525)
436f970 Add version check for dismissable (flutter/engine#6522)
7767c78 Provide a default GL function resolver in the embedder (flutter/engine#6523)
32841dd Case-insensitive matching of family names for custom fonts (flutter/engine#6519)
a9076c7 Roll src/third_party/skia 419709dbb167..21bd60daa3f3 (11 commits) (flutter/engine#6520)
f2e7441 An API for loading fonts from a buffer provided by the application (flutter/engine#6508)
05aac0f fix ResourceExtractor npe. (flutter/engine#6461)
cf5a2a1 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (flutter/engine#6517)
84fe4a9 Re-revert invalid line height tests (flutter/engine#6516)
5f52956 Add support for text shadows (flutter/engine#6385)
e44c10c Reland "Share engine layers with the framework" (flutter#6412) (flutter/engine#6468)
ba04499 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter/engine#6515)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
This was referenced Oct 14, 2018
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 15, 2018
@engine-flutter-autoroll
Roll engine 50c2e69..ff93ccf (22 commits)
269b8d4 
flutter/engine@50c2e69...ff93ccf

git log 50c2e69..ff93ccf --no-merges --oneline
ff93ccf Roll src/third_party/skia 681692726fc0..2b2c00f6ec36 (1 commits) (flutter/engine#6534)
a4161c8 Roll src/third_party/skia 23775a2e9736..681692726fc0 (1 commits) (flutter/engine#6532)
116072e Roll src/third_party/skia 7435f2553f53..23775a2e9736 (1 commits) (flutter/engine#6531)
ef0b0f6 Roll src/third_party/skia bc7a51e79c5b..7435f2553f53 (1 commits) (flutter/engine#6530)
f46b7b9 Roll src/third_party/skia b28db529c866..bc7a51e79c5b (1 commits) (flutter/engine#6529)
9033c39 Roll src/third_party/skia 7e67041a1428..b28db529c866 (1 commits) (flutter/engine#6528)
e6887a4 Add missing imports for unicode/utf16.h (flutter/engine#6524)
1242f6d Roll src/third_party/skia d38382d060ca..7e67041a1428 (2 commits) (flutter/engine#6527)
a1bbea7 Add a no-op platform view layer. (flutter/engine#6505)
2bb3afa Roll src/third_party/skia 21bd60daa3f3..d38382d060ca (10 commits) (flutter/engine#6526)
75e8752 Fix the Mac embedder build (flutter/engine#6525)
436f970 Add version check for dismissable (flutter/engine#6522)
7767c78 Provide a default GL function resolver in the embedder (flutter/engine#6523)
32841dd Case-insensitive matching of family names for custom fonts (flutter/engine#6519)
a9076c7 Roll src/third_party/skia 419709dbb167..21bd60daa3f3 (11 commits) (flutter/engine#6520)
f2e7441 An API for loading fonts from a buffer provided by the application (flutter/engine#6508)
05aac0f fix ResourceExtractor npe. (flutter/engine#6461)
cf5a2a1 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (flutter/engine#6517)
84fe4a9 Re-revert invalid line height tests (flutter/engine#6516)
5f52956 Add support for text shadows (flutter/engine#6385)
e44c10c Reland "Share engine layers with the framework" (flutter#6412) (flutter/engine#6468)
ba04499 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter/engine#6515)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 15, 2018
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 15, 2018
@engine-flutter-autoroll
Roll engine 50c2e69..d4bae4c (23 commits)
5a279a6 
flutter/engine@50c2e69...d4bae4c

git log 50c2e69..d4bae4c --no-merges --oneline
d4bae4c Roll src/third_party/skia 2b2c00f6ec36..646d917d3c71 (1 commits) (flutter/engine#6535)
ff93ccf Roll src/third_party/skia 681692726fc0..2b2c00f6ec36 (1 commits) (flutter/engine#6534)
a4161c8 Roll src/third_party/skia 23775a2e9736..681692726fc0 (1 commits) (flutter/engine#6532)
116072e Roll src/third_party/skia 7435f2553f53..23775a2e9736 (1 commits) (flutter/engine#6531)
ef0b0f6 Roll src/third_party/skia bc7a51e79c5b..7435f2553f53 (1 commits) (flutter/engine#6530)
f46b7b9 Roll src/third_party/skia b28db529c866..bc7a51e79c5b (1 commits) (flutter/engine#6529)
9033c39 Roll src/third_party/skia 7e67041a1428..b28db529c866 (1 commits) (flutter/engine#6528)
e6887a4 Add missing imports for unicode/utf16.h (flutter/engine#6524)
1242f6d Roll src/third_party/skia d38382d060ca..7e67041a1428 (2 commits) (flutter/engine#6527)
a1bbea7 Add a no-op platform view layer. (flutter/engine#6505)
2bb3afa Roll src/third_party/skia 21bd60daa3f3..d38382d060ca (10 commits) (flutter/engine#6526)
75e8752 Fix the Mac embedder build (flutter/engine#6525)
436f970 Add version check for dismissable (flutter/engine#6522)
7767c78 Provide a default GL function resolver in the embedder (flutter/engine#6523)
32841dd Case-insensitive matching of family names for custom fonts (flutter/engine#6519)
a9076c7 Roll src/third_party/skia 419709dbb167..21bd60daa3f3 (11 commits) (flutter/engine#6520)
f2e7441 An API for loading fonts from a buffer provided by the application (flutter/engine#6508)
05aac0f fix ResourceExtractor npe. (flutter/engine#6461)
cf5a2a1 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (flutter/engine#6517)
84fe4a9 Re-revert invalid line height tests (flutter/engine#6516)
5f52956 Add support for text shadows (flutter/engine#6385)
e44c10c Reland "Share engine layers with the framework" (flutter#6412) (flutter/engine#6468)
ba04499 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter/engine#6515)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 15, 2018
@engine-flutter-autoroll
Roll engine 50c2e69..964acaf (24 commits)
9e34250 
flutter/engine@50c2e69...964acaf

git log 50c2e69..964acaf --no-merges --oneline
964acaf Roll src/third_party/skia 646d917d3c71..c6a17104ad68 (1 commits) (flutter/engine#6536)
d4bae4c Roll src/third_party/skia 2b2c00f6ec36..646d917d3c71 (1 commits) (flutter/engine#6535)
ff93ccf Roll src/third_party/skia 681692726fc0..2b2c00f6ec36 (1 commits) (flutter/engine#6534)
a4161c8 Roll src/third_party/skia 23775a2e9736..681692726fc0 (1 commits) (flutter/engine#6532)
116072e Roll src/third_party/skia 7435f2553f53..23775a2e9736 (1 commits) (flutter/engine#6531)
ef0b0f6 Roll src/third_party/skia bc7a51e79c5b..7435f2553f53 (1 commits) (flutter/engine#6530)
f46b7b9 Roll src/third_party/skia b28db529c866..bc7a51e79c5b (1 commits) (flutter/engine#6529)
9033c39 Roll src/third_party/skia 7e67041a1428..b28db529c866 (1 commits) (flutter/engine#6528)
e6887a4 Add missing imports for unicode/utf16.h (flutter/engine#6524)
1242f6d Roll src/third_party/skia d38382d060ca..7e67041a1428 (2 commits) (flutter/engine#6527)
a1bbea7 Add a no-op platform view layer. (flutter/engine#6505)
2bb3afa Roll src/third_party/skia 21bd60daa3f3..d38382d060ca (10 commits) (flutter/engine#6526)
75e8752 Fix the Mac embedder build (flutter/engine#6525)
436f970 Add version check for dismissable (flutter/engine#6522)
7767c78 Provide a default GL function resolver in the embedder (flutter/engine#6523)
32841dd Case-insensitive matching of family names for custom fonts (flutter/engine#6519)
a9076c7 Roll src/third_party/skia 419709dbb167..21bd60daa3f3 (11 commits) (flutter/engine#6520)
f2e7441 An API for loading fonts from a buffer provided by the application (flutter/engine#6508)
05aac0f fix ResourceExtractor npe. (flutter/engine#6461)
cf5a2a1 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (flutter/engine#6517)
84fe4a9 Re-revert invalid line height tests (flutter/engine#6516)
5f52956 Add support for text shadows (flutter/engine#6385)
e44c10c Reland "Share engine layers with the framework" (flutter#6412) (flutter/engine#6468)
ba04499 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter/engine#6515)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
This was referenced Oct 15, 2018
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 15, 2018
@engine-flutter-autoroll
Roll engine 50c2e69..4ee7725 (25 commits)
caca832 
flutter/engine@50c2e69...4ee7725

git log 50c2e69..4ee7725 --no-merges --oneline
4ee7725 Revert "Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter#6515)" (flutter/engine#6537)
964acaf Roll src/third_party/skia 646d917d3c71..c6a17104ad68 (1 commits) (flutter/engine#6536)
d4bae4c Roll src/third_party/skia 2b2c00f6ec36..646d917d3c71 (1 commits) (flutter/engine#6535)
ff93ccf Roll src/third_party/skia 681692726fc0..2b2c00f6ec36 (1 commits) (flutter/engine#6534)
a4161c8 Roll src/third_party/skia 23775a2e9736..681692726fc0 (1 commits) (flutter/engine#6532)
116072e Roll src/third_party/skia 7435f2553f53..23775a2e9736 (1 commits) (flutter/engine#6531)
ef0b0f6 Roll src/third_party/skia bc7a51e79c5b..7435f2553f53 (1 commits) (flutter/engine#6530)
f46b7b9 Roll src/third_party/skia b28db529c866..bc7a51e79c5b (1 commits) (flutter/engine#6529)
9033c39 Roll src/third_party/skia 7e67041a1428..b28db529c866 (1 commits) (flutter/engine#6528)
e6887a4 Add missing imports for unicode/utf16.h (flutter/engine#6524)
1242f6d Roll src/third_party/skia d38382d060ca..7e67041a1428 (2 commits) (flutter/engine#6527)
a1bbea7 Add a no-op platform view layer. (flutter/engine#6505)
2bb3afa Roll src/third_party/skia 21bd60daa3f3..d38382d060ca (10 commits) (flutter/engine#6526)
75e8752 Fix the Mac embedder build (flutter/engine#6525)
436f970 Add version check for dismissable (flutter/engine#6522)
7767c78 Provide a default GL function resolver in the embedder (flutter/engine#6523)
32841dd Case-insensitive matching of family names for custom fonts (flutter/engine#6519)
a9076c7 Roll src/third_party/skia 419709dbb167..21bd60daa3f3 (11 commits) (flutter/engine#6520)
f2e7441 An API for loading fonts from a buffer provided by the application (flutter/engine#6508)
05aac0f fix ResourceExtractor npe. (flutter/engine#6461)
cf5a2a1 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (flutter/engine#6517)
84fe4a9 Re-revert invalid line height tests (flutter/engine#6516)
5f52956 Add support for text shadows (flutter/engine#6385)
e44c10c Reland "Share engine layers with the framework" (flutter#6412) (flutter/engine#6468)
ba04499 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter/engine#6515)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 15, 2018
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 15, 2018
@engine-flutter-autoroll
Roll engine 50c2e69..32f417d (26 commits)
2d4d853 
flutter/engine@50c2e69...32f417d

git log 50c2e69..32f417d --no-merges --oneline
32f417d Roll tonic to 077be256142ede39a271385907faadf4fcc62a4d. (flutter/engine#6541)
4ee7725 Revert "Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter#6515)" (flutter/engine#6537)
964acaf Roll src/third_party/skia 646d917d3c71..c6a17104ad68 (1 commits) (flutter/engine#6536)
d4bae4c Roll src/third_party/skia 2b2c00f6ec36..646d917d3c71 (1 commits) (flutter/engine#6535)
ff93ccf Roll src/third_party/skia 681692726fc0..2b2c00f6ec36 (1 commits) (flutter/engine#6534)
a4161c8 Roll src/third_party/skia 23775a2e9736..681692726fc0 (1 commits) (flutter/engine#6532)
116072e Roll src/third_party/skia 7435f2553f53..23775a2e9736 (1 commits) (flutter/engine#6531)
ef0b0f6 Roll src/third_party/skia bc7a51e79c5b..7435f2553f53 (1 commits) (flutter/engine#6530)
f46b7b9 Roll src/third_party/skia b28db529c866..bc7a51e79c5b (1 commits) (flutter/engine#6529)
9033c39 Roll src/third_party/skia 7e67041a1428..b28db529c866 (1 commits) (flutter/engine#6528)
e6887a4 Add missing imports for unicode/utf16.h (flutter/engine#6524)
1242f6d Roll src/third_party/skia d38382d060ca..7e67041a1428 (2 commits) (flutter/engine#6527)
a1bbea7 Add a no-op platform view layer. (flutter/engine#6505)
2bb3afa Roll src/third_party/skia 21bd60daa3f3..d38382d060ca (10 commits) (flutter/engine#6526)
75e8752 Fix the Mac embedder build (flutter/engine#6525)
436f970 Add version check for dismissable (flutter/engine#6522)
7767c78 Provide a default GL function resolver in the embedder (flutter/engine#6523)
32841dd Case-insensitive matching of family names for custom fonts (flutter/engine#6519)
a9076c7 Roll src/third_party/skia 419709dbb167..21bd60daa3f3 (11 commits) (flutter/engine#6520)
f2e7441 An API for loading fonts from a buffer provided by the application (flutter/engine#6508)
05aac0f fix ResourceExtractor npe. (flutter/engine#6461)
cf5a2a1 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (flutter/engine#6517)
84fe4a9 Re-revert invalid line height tests (flutter/engine#6516)
5f52956 Add support for text shadows (flutter/engine#6385)
e44c10c Reland "Share engine layers with the framework" (flutter#6412) (flutter/engine#6468)
ba04499 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter/engine#6515)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 15, 2018
@engine-flutter-autoroll
Roll engine 50c2e69..c645657 (27 commits)
5e26e63 
flutter/engine@50c2e69...c645657

git log 50c2e69..c645657 --no-merges --oneline
c645657 Roll src/third_party/skia c6a17104ad68..921ec976556c (31 commits) (flutter/engine#6546)
32f417d Roll tonic to 077be256142ede39a271385907faadf4fcc62a4d. (flutter/engine#6541)
4ee7725 Revert "Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter#6515)" (flutter/engine#6537)
964acaf Roll src/third_party/skia 646d917d3c71..c6a17104ad68 (1 commits) (flutter/engine#6536)
d4bae4c Roll src/third_party/skia 2b2c00f6ec36..646d917d3c71 (1 commits) (flutter/engine#6535)
ff93ccf Roll src/third_party/skia 681692726fc0..2b2c00f6ec36 (1 commits) (flutter/engine#6534)
a4161c8 Roll src/third_party/skia 23775a2e9736..681692726fc0 (1 commits) (flutter/engine#6532)
116072e Roll src/third_party/skia 7435f2553f53..23775a2e9736 (1 commits) (flutter/engine#6531)
ef0b0f6 Roll src/third_party/skia bc7a51e79c5b..7435f2553f53 (1 commits) (flutter/engine#6530)
f46b7b9 Roll src/third_party/skia b28db529c866..bc7a51e79c5b (1 commits) (flutter/engine#6529)
9033c39 Roll src/third_party/skia 7e67041a1428..b28db529c866 (1 commits) (flutter/engine#6528)
e6887a4 Add missing imports for unicode/utf16.h (flutter/engine#6524)
1242f6d Roll src/third_party/skia d38382d060ca..7e67041a1428 (2 commits) (flutter/engine#6527)
a1bbea7 Add a no-op platform view layer. (flutter/engine#6505)
2bb3afa Roll src/third_party/skia 21bd60daa3f3..d38382d060ca (10 commits) (flutter/engine#6526)
75e8752 Fix the Mac embedder build (flutter/engine#6525)
436f970 Add version check for dismissable (flutter/engine#6522)
7767c78 Provide a default GL function resolver in the embedder (flutter/engine#6523)
32841dd Case-insensitive matching of family names for custom fonts (flutter/engine#6519)
a9076c7 Roll src/third_party/skia 419709dbb167..21bd60daa3f3 (11 commits) (flutter/engine#6520)
f2e7441 An API for loading fonts from a buffer provided by the application (flutter/engine#6508)
05aac0f fix ResourceExtractor npe. (flutter/engine#6461)
cf5a2a1 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (flutter/engine#6517)
84fe4a9 Re-revert invalid line height tests (flutter/engine#6516)
5f52956 Add support for text shadows (flutter/engine#6385)
e44c10c Reland "Share engine layers with the framework" (flutter#6412) (flutter/engine#6468)
ba04499 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter/engine#6515)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 15, 2018
Closed
@SupSaiYaJin SupSaiYaJin deleted the fix_resource_extractor_npe branch October 16, 2018 06:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@jason-simmons jason-simmons jason-simmons approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SupSaiYaJin @googlebot @jason-simmons