This repository was archived by the owner on Feb 25, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6k
Dart SDK roll for 2018-10-02 to d2c5a24fd9ead97a7f18d02786e679293cc3709e #6410
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
72d3798 Improved completion support for mixins 097e8d8 Use context severity when calling onProblem 002a3e0 Improve error message on unresolved constructor redirections a074a87 Convert more analyzer tests to use ResourceProviderMixin a1ebe68 Change how compile-time NSM is handled 0b48c4a [gardening] Mark appjit_determinism_test flaky on IA32 ff51edf [infra] Update checked in SDKs to 2.1.0-dev.6.0 b8c8315 Record superInterface and use it for OverrideVerifier. 1582903 Reject diagnostics with missing arguments df32b2a Ignore synthetic tokens when compiling bodies f3047f1 Improve diagnostics with constructor names 1972ad9 Related information (context) may be null 2489541 Consolidate dart2js front-end dependencies 4306245 Address review comments from 63144 and 74640 49e521c [build] Forward load limit from build.py to Ninja. 07a8496 [VM] Allow for Dart_SetVMFlags to be called again after Dart_Cleanup d70b0fa Revert "Test that the result of instantiate-to-bounds is appropriately checked for super-boundedness." 7ca2f56 Stop using and deprecate InheritanceManager.getMembersInheritedFromInterfaces(). 7419667 Test that the result of instantiate-to-bounds is appropriately checked for super-boundedness. 07a2130 [vm] Set translation helper allocation space in kernel loader 2230552 [vm] Disable bump allocation scope in kernel loader f5135c6 Don't recurse into arguments of constant InstanceCreationExpression while verifying. 32af1be Check type arguments against bounds when instantiating a typedef. e90f1f2 Remove unused response codes and deprecate an unimplemented request e98d5d8 [vm] Wait for marker task to finish in BumpAllocateScope bdeb6a3 [dart/fuzzer] Remove use of PATH in env dd2e6af Add test for InheritanceManager2 f7f31ef Disable the reading of a UUID during training 64f0222 Stop using InheritanceManager.getMembersInheritedFromClasses(). 76bfa42 bump to linter 0.1.66 e467134 Fix build mode to convert input paths to absolute and normalized before giving them to Analyzer. 765a78d Fix AST summarizer rules when to store variable initializer. b6368c7 Extract PhysicalResourceProvider watch tests and mark them flaky. 1dfdcf3 [vm] Add bump allocation scope a195123 [vm] Remove name conflict checks from class finalization 2723fcf Remove more dead code from server ce8a5ff Remove remaining definitions of EMPTY_LIST in server 9083b11 InheritanceManager does not produce errors, don't ask it. 645fbc8 Add CompilerOptions.onDiagnostic 6361d9e Update status for flaky product-mode vm test ed6d7e2 Fix build failure introduced in https://dart-review.googlesource.com/c/sdk/+/77013 0461df2 Remove FileState.fileUri. 10f05f4 Remove more dead code from server 5cc9ab0 Switch all refactoring to using ResolveResult instead of raw unit. 215e80e Fix Analysis Server tests on Windows bot. 85fb1f3 Fix Analyzer tests on Windows bot. 1be151d Give LibraryScope to AstRewriteVisitor. e7e8786 Replace MockSDK in analyzer_plugin to fix its tests on Windows. 2420855 Fix analyzer_cli tests on Windows. 5bcf91d Remove some dead code fc130a0 Extract ConstantVerifier. fc96edc Don't use AstRewriteVisitor in resynthesizer, build InstanceCreationExpression as we build expressions. 25c6599 Change ResourceUriResolver to accept any file URI. 6c577f0 Deprecate Element.isVirtual 5db21a7 Tentatively re-enable PhysicalResourceProviderTest. c78f67c [vm/aot] Use TFA to detect dynamic, non-this and tear-off uses 0785253 [ VM ] Additional cleanup in Dart_Initialize and Dart_Cleanup 41a875f Fix (super)mixins issues da3e844 Fix potential cast exceptions 1bceca9 Remove the 'name' constructor parameter from CompilationUnitElementImpl() 4a51268 [gen_snapshot] Restore support for --snapshot_kind=vm-aot-assembly; update docs.
aam
approved these changes
Oct 2, 2018
liyuqian
added a commit
that referenced
this pull request
Oct 2, 2018
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 3, 2018
flutter/engine@f6af1f2...2de87a8 git log f6af1f2..2de87a8 --no-merges --oneline 2de87a8 Roll src/third_party/skia 6719fcc43b1e..deb512045e6a (7 commits) (flutter/engine#6411) 68a42e3 Add nullability annotations to MethodChannel/MethodCall. (flutter/engine#6393) 71ba20a Dart SDK roll for 2018-10-02 to d2c5a24fd9ead97a7f18d02786e679293cc3709e (flutter/engine#6410) 9ccc966 Share engine layers with the framework (flutter/engine#6406) fa719e3 Roll src/third_party/skia cc4dbfcfbd8a..6719fcc43b1e (17 commits) (flutter/engine#6409) dc2634d Force lf-line endings for so that source offsets match across platforms. (flutter/engine#6408) 44a5149 Roll src/third_party/skia 7dae882574d2..cc4dbfcfbd8a (15 commits) (flutter/engine#6405) de32c65 Roll src/third_party/skia 3b8b11e1f912..7dae882574d2 (15 commits) (flutter/engine#6403) 3a9c22a Allow GetRectsForRange to provide more detailed/nuanced metrics through RectStyle enum. (flutter/engine#6335) b59c864 Rename the Android fragment support library JAR (flutter/engine#6400) 4213ac1 Add an Android fragment support library to third_party (flutter/engine#6384) a785b25 do not count Hidden nodes at the beginning of the scrollable (flutter/engine#6381) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 3, 2018
flutter/engine@f6af1f2...74662ab git log f6af1f2..74662ab --no-merges --oneline 74662ab Revert "Share engine layers with the framework" (flutter/engine#6412) 2de87a8 Roll src/third_party/skia 6719fcc43b1e..deb512045e6a (7 commits) (flutter/engine#6411) 68a42e3 Add nullability annotations to MethodChannel/MethodCall. (flutter/engine#6393) 71ba20a Dart SDK roll for 2018-10-02 to d2c5a24fd9ead97a7f18d02786e679293cc3709e (flutter/engine#6410) 9ccc966 Share engine layers with the framework (flutter/engine#6406) fa719e3 Roll src/third_party/skia cc4dbfcfbd8a..6719fcc43b1e (17 commits) (flutter/engine#6409) dc2634d Force lf-line endings for so that source offsets match across platforms. (flutter/engine#6408) 44a5149 Roll src/third_party/skia 7dae882574d2..cc4dbfcfbd8a (15 commits) (flutter/engine#6405) de32c65 Roll src/third_party/skia 3b8b11e1f912..7dae882574d2 (15 commits) (flutter/engine#6403) 3a9c22a Allow GetRectsForRange to provide more detailed/nuanced metrics through RectStyle enum. (flutter/engine#6335) b59c864 Rename the Android fragment support library JAR (flutter/engine#6400) 4213ac1 Add an Android fragment support library to third_party (flutter/engine#6384) a785b25 do not count Hidden nodes at the beginning of the scrollable (flutter/engine#6381) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
dnfield
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 3, 2018
flutter/engine@f6af1f2...74662ab git log f6af1f2..74662ab --no-merges --oneline 74662ab Revert "Share engine layers with the framework" (flutter/engine#6412) 2de87a8 Roll src/third_party/skia 6719fcc43b1e..deb512045e6a (7 commits) (flutter/engine#6411) 68a42e3 Add nullability annotations to MethodChannel/MethodCall. (flutter/engine#6393) 71ba20a Dart SDK roll for 2018-10-02 to d2c5a24fd9ead97a7f18d02786e679293cc3709e (flutter/engine#6410) 9ccc966 Share engine layers with the framework (flutter/engine#6406) fa719e3 Roll src/third_party/skia cc4dbfcfbd8a..6719fcc43b1e (17 commits) (flutter/engine#6409) dc2634d Force lf-line endings for so that source offsets match across platforms. (flutter/engine#6408) 44a5149 Roll src/third_party/skia 7dae882574d2..cc4dbfcfbd8a (15 commits) (flutter/engine#6405) de32c65 Roll src/third_party/skia 3b8b11e1f912..7dae882574d2 (15 commits) (flutter/engine#6403) 3a9c22a Allow GetRectsForRange to provide more detailed/nuanced metrics through RectStyle enum. (flutter/engine#6335) b59c864 Rename the Android fragment support library JAR (flutter/engine#6400) 4213ac1 Add an Android fragment support library to third_party (flutter/engine#6384) a785b25 do not count Hidden nodes at the beginning of the scrollable (flutter/engine#6381) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
d2c5a24 Recognize mixins as subtypes of their superclass constraints in hint generation (issue 34633)
0804245 [vm] Make filtering in Heap::RecordAfterGC consistent with ServiceEvent::ServiceEvent.
72d3798 Improved completion support for mixins
097e8d8 Use context severity when calling onProblem
002a3e0 Improve error message on unresolved constructor redirections
a074a87 Convert more analyzer tests to use ResourceProviderMixin
a1ebe68 Change how compile-time NSM is handled
0b48c4a [gardening] Mark appjit_determinism_test flaky on IA32
ff51edf [infra] Update checked in SDKs to 2.1.0-dev.6.0
b8c8315 Record superInterface and use it for OverrideVerifier.
1582903 Reject diagnostics with missing arguments
df32b2a Ignore synthetic tokens when compiling bodies
f3047f1 Improve diagnostics with constructor names
1972ad9 Related information (context) may be null
2489541 Consolidate dart2js front-end dependencies
4306245 Address review comments from 63144 and 74640
49e521c [build] Forward load limit from build.py to Ninja.
07a8496 [VM] Allow for Dart_SetVMFlags to be called again after Dart_Cleanup
d70b0fa Revert "Test that the result of instantiate-to-bounds is appropriately checked for super-boundedness."
7ca2f56 Stop using and deprecate InheritanceManager.getMembersInheritedFromInterfaces().
7419667 Test that the result of instantiate-to-bounds is appropriately checked for super-boundedness.
07a2130 [vm] Set translation helper allocation space in kernel loader
2230552 [vm] Disable bump allocation scope in kernel loader
f5135c6 Don't recurse into arguments of constant InstanceCreationExpression while verifying.
32af1be Check type arguments against bounds when instantiating a typedef.
e90f1f2 Remove unused response codes and deprecate an unimplemented request
e98d5d8 [vm] Wait for marker task to finish in BumpAllocateScope
bdeb6a3 [dart/fuzzer] Remove use of PATH in env
dd2e6af Add test for InheritanceManager2
f7f31ef Disable the reading of a UUID during training
64f0222 Stop using InheritanceManager.getMembersInheritedFromClasses().
76bfa42 bump to linter 0.1.66
e467134 Fix build mode to convert input paths to absolute and normalized before giving them to Analyzer.
765a78d Fix AST summarizer rules when to store variable initializer.
b6368c7 Extract PhysicalResourceProvider watch tests and mark them flaky.
1dfdcf3 [vm] Add bump allocation scope
a195123 [vm] Remove name conflict checks from class finalization
2723fcf Remove more dead code from server
ce8a5ff Remove remaining definitions of EMPTY_LIST in server
9083b11 InheritanceManager does not produce errors, don't ask it.
645fbc8 Add CompilerOptions.onDiagnostic
6361d9e Update status for flaky product-mode vm test
ed6d7e2 Fix build failure introduced in https://dart-review.googlesource.com/c/sdk/+/77013
0461df2 Remove FileState.fileUri.
10f05f4 Remove more dead code from server
5cc9ab0 Switch all refactoring to using ResolveResult instead of raw unit.
215e80e Fix Analysis Server tests on Windows bot.
85fb1f3 Fix Analyzer tests on Windows bot.
1be151d Give LibraryScope to AstRewriteVisitor.
e7e8786 Replace MockSDK in analyzer_plugin to fix its tests on Windows.
2420855 Fix analyzer_cli tests on Windows.
5bcf91d Remove some dead code
fc130a0 Extract ConstantVerifier.
fc96edc Don't use AstRewriteVisitor in resynthesizer, build InstanceCreationExpression as we build expressions.
25c6599 Change ResourceUriResolver to accept any file URI.
6c577f0 Deprecate Element.isVirtual
5db21a7 Tentatively re-enable PhysicalResourceProviderTest.
c78f67c [vm/aot] Use TFA to detect dynamic, non-this and tear-off uses
0785253 [ VM ] Additional cleanup in Dart_Initialize and Dart_Cleanup
41a875f Fix (super)mixins issues
da3e844 Fix potential cast exceptions
1bceca9 Remove the 'name' constructor parameter from CompilationUnitElementImpl()
4a51268 [gen_snapshot] Restore support for --snapshot_kind=vm-aot-assembly; update docs.