Add support for text shadows #6385

GaryQian · 2018-09-28T21:18:40Z

Fixes/Adds features for flutter/flutter#3402

GaryQian · 2018-09-28T21:19:29Z

See flutter/flutter#22449 for framework-side integration

chinmaygarde · 2018-09-28T21:40:54Z

lgtm. Really appreciate the tests on the native side. We should wire up comparison of snapshots to golden fixtures soon. Care to file a bug for the same? @gspencergoog has some experience with golden tests in the framework and maybe we can get his help on the same for the engine.

@Hixie for review of the Dart code.

Hixie · 2018-09-29T20:44:25Z

lib/ui/text.dart

+/// A single text shadow.
+/// 
+/// Multiple shadows are stacked together in a [TextStyle].
+class TextShadow {


why TextShadow rather than Shadow? (Using Shadow would let BoxShadow inherit from it too.)

This class is the dart:ui equivalent to shadows, and is only used for text. I didn't want the framework Shadow class be dependent on the dart:ui class that really only exists as a bridge from flutter to dart ui.

See shadow.dart and box_shadow.dart on the framework side for the inherited/generic version

I don't really see why we wouldn't want BoxShadow to inherit from the dart:ui class? Can you elaborate on that?

I was thinking that the shadow class in dart:ui would provide things like serialization that would not be useful to the framework as a whole. Such methods would probably just add clutter to the API, as it is very specific to the use case of passing data to LibTxt. Also, I figured the framework itself could use the existence of a simple shadow class alongside the more advanced BoxShadow.

From a user's perspective, I think it makes more sense for them to import the painting package and have a Shadow than importing dart:ui for Shadow.

Overall, I think it keeps the code better encapsulated and doesn't provide niche API that would never be used.

The privates would be private, so the subclasses would be unaffected by them.
The painting package would re-export Shadow, they wouldn't know that it was there.

The problem with having three classes is that it's one third as many classes. It's also confusing that you create a "Shadow" to style text, but at some point it becomes a "TextShadow". Also that "Shadow" is the superclass of "BoxShadow" but not "TextShadow".

As far as I can tell, TextShadow is a strict subset of BoxShadow, so it seems to make sense to me to say that BoxShadow is-a TextShadow (renamed accordingly to Shadow).

Ok, that makes sense. I'll make the changes!

lib/ui/text.dart

Hixie · 2018-09-29T20:45:20Z

lib/ui/text.dart

+    this.color = const Color(0xFF000000),
+    this.offset = Offset.zero,
+    this.blurRadius = 0.0,
+  });


should the constructor assert that these are non-null? (and maybe that the blurRadius is >=0?)

lib/ui/text.dart

googlebot · 2018-10-02T17:24:03Z

CLAs look good, thanks!

googlebot · 2018-10-02T17:24:04Z

CLAs look good, thanks!

flutter/engine@50c2e69...2bb3afa git log 50c2e69..2bb3afa --no-merges --oneline 2bb3afa Roll src/third_party/skia 21bd60daa3f3..d38382d060ca (10 commits) (flutter/engine#6526) 75e8752 Fix the Mac embedder build (flutter/engine#6525) 436f970 Add version check for dismissable (flutter/engine#6522) 7767c78 Provide a default GL function resolver in the embedder (flutter/engine#6523) 32841dd Case-insensitive matching of family names for custom fonts (flutter/engine#6519) a9076c7 Roll src/third_party/skia 419709dbb167..21bd60daa3f3 (11 commits) (flutter/engine#6520) f2e7441 An API for loading fonts from a buffer provided by the application (flutter/engine#6508) 05aac0f fix ResourceExtractor npe. (flutter/engine#6461) cf5a2a1 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (flutter/engine#6517) 84fe4a9 Re-revert invalid line height tests (flutter/engine#6516) 5f52956 Add support for text shadows (flutter/engine#6385) e44c10c Reland "Share engine layers with the framework" (flutter#6412) (flutter/engine#6468) ba04499 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter/engine#6515) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.

flutter/engine@50c2e69...a1bbea7 git log 50c2e69..a1bbea7 --no-merges --oneline a1bbea7 Add a no-op platform view layer. (flutter/engine#6505) 2bb3afa Roll src/third_party/skia 21bd60daa3f3..d38382d060ca (10 commits) (flutter/engine#6526) 75e8752 Fix the Mac embedder build (flutter/engine#6525) 436f970 Add version check for dismissable (flutter/engine#6522) 7767c78 Provide a default GL function resolver in the embedder (flutter/engine#6523) 32841dd Case-insensitive matching of family names for custom fonts (flutter/engine#6519) a9076c7 Roll src/third_party/skia 419709dbb167..21bd60daa3f3 (11 commits) (flutter/engine#6520) f2e7441 An API for loading fonts from a buffer provided by the application (flutter/engine#6508) 05aac0f fix ResourceExtractor npe. (flutter/engine#6461) cf5a2a1 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (flutter/engine#6517) 84fe4a9 Re-revert invalid line height tests (flutter/engine#6516) 5f52956 Add support for text shadows (flutter/engine#6385) e44c10c Reland "Share engine layers with the framework" (flutter#6412) (flutter/engine#6468) ba04499 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter/engine#6515) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.

flutter/engine@50c2e69...1242f6d git log 50c2e69..1242f6d --no-merges --oneline 1242f6d Roll src/third_party/skia d38382d060ca..7e67041a1428 (2 commits) (flutter/engine#6527) a1bbea7 Add a no-op platform view layer. (flutter/engine#6505) 2bb3afa Roll src/third_party/skia 21bd60daa3f3..d38382d060ca (10 commits) (flutter/engine#6526) 75e8752 Fix the Mac embedder build (flutter/engine#6525) 436f970 Add version check for dismissable (flutter/engine#6522) 7767c78 Provide a default GL function resolver in the embedder (flutter/engine#6523) 32841dd Case-insensitive matching of family names for custom fonts (flutter/engine#6519) a9076c7 Roll src/third_party/skia 419709dbb167..21bd60daa3f3 (11 commits) (flutter/engine#6520) f2e7441 An API for loading fonts from a buffer provided by the application (flutter/engine#6508) 05aac0f fix ResourceExtractor npe. (flutter/engine#6461) cf5a2a1 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (flutter/engine#6517) 84fe4a9 Re-revert invalid line height tests (flutter/engine#6516) 5f52956 Add support for text shadows (flutter/engine#6385) e44c10c Reland "Share engine layers with the framework" (flutter#6412) (flutter/engine#6468) ba04499 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter/engine#6515) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.

flutter/engine@50c2e69...e6887a4 git log 50c2e69..e6887a4 --no-merges --oneline e6887a4 Add missing imports for unicode/utf16.h (flutter/engine#6524) 1242f6d Roll src/third_party/skia d38382d060ca..7e67041a1428 (2 commits) (flutter/engine#6527) a1bbea7 Add a no-op platform view layer. (flutter/engine#6505) 2bb3afa Roll src/third_party/skia 21bd60daa3f3..d38382d060ca (10 commits) (flutter/engine#6526) 75e8752 Fix the Mac embedder build (flutter/engine#6525) 436f970 Add version check for dismissable (flutter/engine#6522) 7767c78 Provide a default GL function resolver in the embedder (flutter/engine#6523) 32841dd Case-insensitive matching of family names for custom fonts (flutter/engine#6519) a9076c7 Roll src/third_party/skia 419709dbb167..21bd60daa3f3 (11 commits) (flutter/engine#6520) f2e7441 An API for loading fonts from a buffer provided by the application (flutter/engine#6508) 05aac0f fix ResourceExtractor npe. (flutter/engine#6461) cf5a2a1 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (flutter/engine#6517) 84fe4a9 Re-revert invalid line height tests (flutter/engine#6516) 5f52956 Add support for text shadows (flutter/engine#6385) e44c10c Reland "Share engine layers with the framework" (flutter#6412) (flutter/engine#6468) ba04499 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter/engine#6515) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.

flutter/engine@50c2e69...9033c39 git log 50c2e69..9033c39 --no-merges --oneline 9033c39 Roll src/third_party/skia 7e67041a1428..b28db529c866 (1 commits) (flutter/engine#6528) e6887a4 Add missing imports for unicode/utf16.h (flutter/engine#6524) 1242f6d Roll src/third_party/skia d38382d060ca..7e67041a1428 (2 commits) (flutter/engine#6527) a1bbea7 Add a no-op platform view layer. (flutter/engine#6505) 2bb3afa Roll src/third_party/skia 21bd60daa3f3..d38382d060ca (10 commits) (flutter/engine#6526) 75e8752 Fix the Mac embedder build (flutter/engine#6525) 436f970 Add version check for dismissable (flutter/engine#6522) 7767c78 Provide a default GL function resolver in the embedder (flutter/engine#6523) 32841dd Case-insensitive matching of family names for custom fonts (flutter/engine#6519) a9076c7 Roll src/third_party/skia 419709dbb167..21bd60daa3f3 (11 commits) (flutter/engine#6520) f2e7441 An API for loading fonts from a buffer provided by the application (flutter/engine#6508) 05aac0f fix ResourceExtractor npe. (flutter/engine#6461) cf5a2a1 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (flutter/engine#6517) 84fe4a9 Re-revert invalid line height tests (flutter/engine#6516) 5f52956 Add support for text shadows (flutter/engine#6385) e44c10c Reland "Share engine layers with the framework" (flutter#6412) (flutter/engine#6468) ba04499 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter/engine#6515) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.

flutter/engine@50c2e69...f46b7b9 git log 50c2e69..f46b7b9 --no-merges --oneline f46b7b9 Roll src/third_party/skia b28db529c866..bc7a51e79c5b (1 commits) (flutter/engine#6529) 9033c39 Roll src/third_party/skia 7e67041a1428..b28db529c866 (1 commits) (flutter/engine#6528) e6887a4 Add missing imports for unicode/utf16.h (flutter/engine#6524) 1242f6d Roll src/third_party/skia d38382d060ca..7e67041a1428 (2 commits) (flutter/engine#6527) a1bbea7 Add a no-op platform view layer. (flutter/engine#6505) 2bb3afa Roll src/third_party/skia 21bd60daa3f3..d38382d060ca (10 commits) (flutter/engine#6526) 75e8752 Fix the Mac embedder build (flutter/engine#6525) 436f970 Add version check for dismissable (flutter/engine#6522) 7767c78 Provide a default GL function resolver in the embedder (flutter/engine#6523) 32841dd Case-insensitive matching of family names for custom fonts (flutter/engine#6519) a9076c7 Roll src/third_party/skia 419709dbb167..21bd60daa3f3 (11 commits) (flutter/engine#6520) f2e7441 An API for loading fonts from a buffer provided by the application (flutter/engine#6508) 05aac0f fix ResourceExtractor npe. (flutter/engine#6461) cf5a2a1 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (flutter/engine#6517) 84fe4a9 Re-revert invalid line height tests (flutter/engine#6516) 5f52956 Add support for text shadows (flutter/engine#6385) e44c10c Reland "Share engine layers with the framework" (flutter#6412) (flutter/engine#6468) ba04499 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter/engine#6515) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.

flutter/engine@50c2e69...ef0b0f6 git log 50c2e69..ef0b0f6 --no-merges --oneline ef0b0f6 Roll src/third_party/skia bc7a51e79c5b..7435f2553f53 (1 commits) (flutter/engine#6530) f46b7b9 Roll src/third_party/skia b28db529c866..bc7a51e79c5b (1 commits) (flutter/engine#6529) 9033c39 Roll src/third_party/skia 7e67041a1428..b28db529c866 (1 commits) (flutter/engine#6528) e6887a4 Add missing imports for unicode/utf16.h (flutter/engine#6524) 1242f6d Roll src/third_party/skia d38382d060ca..7e67041a1428 (2 commits) (flutter/engine#6527) a1bbea7 Add a no-op platform view layer. (flutter/engine#6505) 2bb3afa Roll src/third_party/skia 21bd60daa3f3..d38382d060ca (10 commits) (flutter/engine#6526) 75e8752 Fix the Mac embedder build (flutter/engine#6525) 436f970 Add version check for dismissable (flutter/engine#6522) 7767c78 Provide a default GL function resolver in the embedder (flutter/engine#6523) 32841dd Case-insensitive matching of family names for custom fonts (flutter/engine#6519) a9076c7 Roll src/third_party/skia 419709dbb167..21bd60daa3f3 (11 commits) (flutter/engine#6520) f2e7441 An API for loading fonts from a buffer provided by the application (flutter/engine#6508) 05aac0f fix ResourceExtractor npe. (flutter/engine#6461) cf5a2a1 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (flutter/engine#6517) 84fe4a9 Re-revert invalid line height tests (flutter/engine#6516) 5f52956 Add support for text shadows (flutter/engine#6385) e44c10c Reland "Share engine layers with the framework" (flutter#6412) (flutter/engine#6468) ba04499 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter/engine#6515) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.

flutter/engine@50c2e69...116072e git log 50c2e69..116072e --no-merges --oneline 116072e Roll src/third_party/skia 7435f2553f53..23775a2e9736 (1 commits) (flutter/engine#6531) ef0b0f6 Roll src/third_party/skia bc7a51e79c5b..7435f2553f53 (1 commits) (flutter/engine#6530) f46b7b9 Roll src/third_party/skia b28db529c866..bc7a51e79c5b (1 commits) (flutter/engine#6529) 9033c39 Roll src/third_party/skia 7e67041a1428..b28db529c866 (1 commits) (flutter/engine#6528) e6887a4 Add missing imports for unicode/utf16.h (flutter/engine#6524) 1242f6d Roll src/third_party/skia d38382d060ca..7e67041a1428 (2 commits) (flutter/engine#6527) a1bbea7 Add a no-op platform view layer. (flutter/engine#6505) 2bb3afa Roll src/third_party/skia 21bd60daa3f3..d38382d060ca (10 commits) (flutter/engine#6526) 75e8752 Fix the Mac embedder build (flutter/engine#6525) 436f970 Add version check for dismissable (flutter/engine#6522) 7767c78 Provide a default GL function resolver in the embedder (flutter/engine#6523) 32841dd Case-insensitive matching of family names for custom fonts (flutter/engine#6519) a9076c7 Roll src/third_party/skia 419709dbb167..21bd60daa3f3 (11 commits) (flutter/engine#6520) f2e7441 An API for loading fonts from a buffer provided by the application (flutter/engine#6508) 05aac0f fix ResourceExtractor npe. (flutter/engine#6461) cf5a2a1 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (flutter/engine#6517) 84fe4a9 Re-revert invalid line height tests (flutter/engine#6516) 5f52956 Add support for text shadows (flutter/engine#6385) e44c10c Reland "Share engine layers with the framework" (flutter#6412) (flutter/engine#6468) ba04499 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter/engine#6515) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.

flutter/engine@50c2e69...a4161c8 git log 50c2e69..a4161c8 --no-merges --oneline a4161c8 Roll src/third_party/skia 23775a2e9736..681692726fc0 (1 commits) (flutter/engine#6532) 116072e Roll src/third_party/skia 7435f2553f53..23775a2e9736 (1 commits) (flutter/engine#6531) ef0b0f6 Roll src/third_party/skia bc7a51e79c5b..7435f2553f53 (1 commits) (flutter/engine#6530) f46b7b9 Roll src/third_party/skia b28db529c866..bc7a51e79c5b (1 commits) (flutter/engine#6529) 9033c39 Roll src/third_party/skia 7e67041a1428..b28db529c866 (1 commits) (flutter/engine#6528) e6887a4 Add missing imports for unicode/utf16.h (flutter/engine#6524) 1242f6d Roll src/third_party/skia d38382d060ca..7e67041a1428 (2 commits) (flutter/engine#6527) a1bbea7 Add a no-op platform view layer. (flutter/engine#6505) 2bb3afa Roll src/third_party/skia 21bd60daa3f3..d38382d060ca (10 commits) (flutter/engine#6526) 75e8752 Fix the Mac embedder build (flutter/engine#6525) 436f970 Add version check for dismissable (flutter/engine#6522) 7767c78 Provide a default GL function resolver in the embedder (flutter/engine#6523) 32841dd Case-insensitive matching of family names for custom fonts (flutter/engine#6519) a9076c7 Roll src/third_party/skia 419709dbb167..21bd60daa3f3 (11 commits) (flutter/engine#6520) f2e7441 An API for loading fonts from a buffer provided by the application (flutter/engine#6508) 05aac0f fix ResourceExtractor npe. (flutter/engine#6461) cf5a2a1 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (flutter/engine#6517) 84fe4a9 Re-revert invalid line height tests (flutter/engine#6516) 5f52956 Add support for text shadows (flutter/engine#6385) e44c10c Reland "Share engine layers with the framework" (flutter#6412) (flutter/engine#6468) ba04499 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter/engine#6515) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.

flutter/engine@50c2e69...ff93ccf git log 50c2e69..ff93ccf --no-merges --oneline ff93ccf Roll src/third_party/skia 681692726fc0..2b2c00f6ec36 (1 commits) (flutter/engine#6534) a4161c8 Roll src/third_party/skia 23775a2e9736..681692726fc0 (1 commits) (flutter/engine#6532) 116072e Roll src/third_party/skia 7435f2553f53..23775a2e9736 (1 commits) (flutter/engine#6531) ef0b0f6 Roll src/third_party/skia bc7a51e79c5b..7435f2553f53 (1 commits) (flutter/engine#6530) f46b7b9 Roll src/third_party/skia b28db529c866..bc7a51e79c5b (1 commits) (flutter/engine#6529) 9033c39 Roll src/third_party/skia 7e67041a1428..b28db529c866 (1 commits) (flutter/engine#6528) e6887a4 Add missing imports for unicode/utf16.h (flutter/engine#6524) 1242f6d Roll src/third_party/skia d38382d060ca..7e67041a1428 (2 commits) (flutter/engine#6527) a1bbea7 Add a no-op platform view layer. (flutter/engine#6505) 2bb3afa Roll src/third_party/skia 21bd60daa3f3..d38382d060ca (10 commits) (flutter/engine#6526) 75e8752 Fix the Mac embedder build (flutter/engine#6525) 436f970 Add version check for dismissable (flutter/engine#6522) 7767c78 Provide a default GL function resolver in the embedder (flutter/engine#6523) 32841dd Case-insensitive matching of family names for custom fonts (flutter/engine#6519) a9076c7 Roll src/third_party/skia 419709dbb167..21bd60daa3f3 (11 commits) (flutter/engine#6520) f2e7441 An API for loading fonts from a buffer provided by the application (flutter/engine#6508) 05aac0f fix ResourceExtractor npe. (flutter/engine#6461) cf5a2a1 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (flutter/engine#6517) 84fe4a9 Re-revert invalid line height tests (flutter/engine#6516) 5f52956 Add support for text shadows (flutter/engine#6385) e44c10c Reland "Share engine layers with the framework" (flutter#6412) (flutter/engine#6468) ba04499 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter/engine#6515) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.

flutter/engine@50c2e69...d4bae4c git log 50c2e69..d4bae4c --no-merges --oneline d4bae4c Roll src/third_party/skia 2b2c00f6ec36..646d917d3c71 (1 commits) (flutter/engine#6535) ff93ccf Roll src/third_party/skia 681692726fc0..2b2c00f6ec36 (1 commits) (flutter/engine#6534) a4161c8 Roll src/third_party/skia 23775a2e9736..681692726fc0 (1 commits) (flutter/engine#6532) 116072e Roll src/third_party/skia 7435f2553f53..23775a2e9736 (1 commits) (flutter/engine#6531) ef0b0f6 Roll src/third_party/skia bc7a51e79c5b..7435f2553f53 (1 commits) (flutter/engine#6530) f46b7b9 Roll src/third_party/skia b28db529c866..bc7a51e79c5b (1 commits) (flutter/engine#6529) 9033c39 Roll src/third_party/skia 7e67041a1428..b28db529c866 (1 commits) (flutter/engine#6528) e6887a4 Add missing imports for unicode/utf16.h (flutter/engine#6524) 1242f6d Roll src/third_party/skia d38382d060ca..7e67041a1428 (2 commits) (flutter/engine#6527) a1bbea7 Add a no-op platform view layer. (flutter/engine#6505) 2bb3afa Roll src/third_party/skia 21bd60daa3f3..d38382d060ca (10 commits) (flutter/engine#6526) 75e8752 Fix the Mac embedder build (flutter/engine#6525) 436f970 Add version check for dismissable (flutter/engine#6522) 7767c78 Provide a default GL function resolver in the embedder (flutter/engine#6523) 32841dd Case-insensitive matching of family names for custom fonts (flutter/engine#6519) a9076c7 Roll src/third_party/skia 419709dbb167..21bd60daa3f3 (11 commits) (flutter/engine#6520) f2e7441 An API for loading fonts from a buffer provided by the application (flutter/engine#6508) 05aac0f fix ResourceExtractor npe. (flutter/engine#6461) cf5a2a1 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (flutter/engine#6517) 84fe4a9 Re-revert invalid line height tests (flutter/engine#6516) 5f52956 Add support for text shadows (flutter/engine#6385) e44c10c Reland "Share engine layers with the framework" (flutter#6412) (flutter/engine#6468) ba04499 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter/engine#6515) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.

flutter/engine@50c2e69...964acaf git log 50c2e69..964acaf --no-merges --oneline 964acaf Roll src/third_party/skia 646d917d3c71..c6a17104ad68 (1 commits) (flutter/engine#6536) d4bae4c Roll src/third_party/skia 2b2c00f6ec36..646d917d3c71 (1 commits) (flutter/engine#6535) ff93ccf Roll src/third_party/skia 681692726fc0..2b2c00f6ec36 (1 commits) (flutter/engine#6534) a4161c8 Roll src/third_party/skia 23775a2e9736..681692726fc0 (1 commits) (flutter/engine#6532) 116072e Roll src/third_party/skia 7435f2553f53..23775a2e9736 (1 commits) (flutter/engine#6531) ef0b0f6 Roll src/third_party/skia bc7a51e79c5b..7435f2553f53 (1 commits) (flutter/engine#6530) f46b7b9 Roll src/third_party/skia b28db529c866..bc7a51e79c5b (1 commits) (flutter/engine#6529) 9033c39 Roll src/third_party/skia 7e67041a1428..b28db529c866 (1 commits) (flutter/engine#6528) e6887a4 Add missing imports for unicode/utf16.h (flutter/engine#6524) 1242f6d Roll src/third_party/skia d38382d060ca..7e67041a1428 (2 commits) (flutter/engine#6527) a1bbea7 Add a no-op platform view layer. (flutter/engine#6505) 2bb3afa Roll src/third_party/skia 21bd60daa3f3..d38382d060ca (10 commits) (flutter/engine#6526) 75e8752 Fix the Mac embedder build (flutter/engine#6525) 436f970 Add version check for dismissable (flutter/engine#6522) 7767c78 Provide a default GL function resolver in the embedder (flutter/engine#6523) 32841dd Case-insensitive matching of family names for custom fonts (flutter/engine#6519) a9076c7 Roll src/third_party/skia 419709dbb167..21bd60daa3f3 (11 commits) (flutter/engine#6520) f2e7441 An API for loading fonts from a buffer provided by the application (flutter/engine#6508) 05aac0f fix ResourceExtractor npe. (flutter/engine#6461) cf5a2a1 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (flutter/engine#6517) 84fe4a9 Re-revert invalid line height tests (flutter/engine#6516) 5f52956 Add support for text shadows (flutter/engine#6385) e44c10c Reland "Share engine layers with the framework" (flutter#6412) (flutter/engine#6468) ba04499 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter/engine#6515) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.

flutter/engine@50c2e69...4ee7725 git log 50c2e69..4ee7725 --no-merges --oneline 4ee7725 Revert "Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter#6515)" (flutter/engine#6537) 964acaf Roll src/third_party/skia 646d917d3c71..c6a17104ad68 (1 commits) (flutter/engine#6536) d4bae4c Roll src/third_party/skia 2b2c00f6ec36..646d917d3c71 (1 commits) (flutter/engine#6535) ff93ccf Roll src/third_party/skia 681692726fc0..2b2c00f6ec36 (1 commits) (flutter/engine#6534) a4161c8 Roll src/third_party/skia 23775a2e9736..681692726fc0 (1 commits) (flutter/engine#6532) 116072e Roll src/third_party/skia 7435f2553f53..23775a2e9736 (1 commits) (flutter/engine#6531) ef0b0f6 Roll src/third_party/skia bc7a51e79c5b..7435f2553f53 (1 commits) (flutter/engine#6530) f46b7b9 Roll src/third_party/skia b28db529c866..bc7a51e79c5b (1 commits) (flutter/engine#6529) 9033c39 Roll src/third_party/skia 7e67041a1428..b28db529c866 (1 commits) (flutter/engine#6528) e6887a4 Add missing imports for unicode/utf16.h (flutter/engine#6524) 1242f6d Roll src/third_party/skia d38382d060ca..7e67041a1428 (2 commits) (flutter/engine#6527) a1bbea7 Add a no-op platform view layer. (flutter/engine#6505) 2bb3afa Roll src/third_party/skia 21bd60daa3f3..d38382d060ca (10 commits) (flutter/engine#6526) 75e8752 Fix the Mac embedder build (flutter/engine#6525) 436f970 Add version check for dismissable (flutter/engine#6522) 7767c78 Provide a default GL function resolver in the embedder (flutter/engine#6523) 32841dd Case-insensitive matching of family names for custom fonts (flutter/engine#6519) a9076c7 Roll src/third_party/skia 419709dbb167..21bd60daa3f3 (11 commits) (flutter/engine#6520) f2e7441 An API for loading fonts from a buffer provided by the application (flutter/engine#6508) 05aac0f fix ResourceExtractor npe. (flutter/engine#6461) cf5a2a1 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (flutter/engine#6517) 84fe4a9 Re-revert invalid line height tests (flutter/engine#6516) 5f52956 Add support for text shadows (flutter/engine#6385) e44c10c Reland "Share engine layers with the framework" (flutter#6412) (flutter/engine#6468) ba04499 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter/engine#6515) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.

flutter/engine@50c2e69...32f417d git log 50c2e69..32f417d --no-merges --oneline 32f417d Roll tonic to 077be256142ede39a271385907faadf4fcc62a4d. (flutter/engine#6541) 4ee7725 Revert "Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter#6515)" (flutter/engine#6537) 964acaf Roll src/third_party/skia 646d917d3c71..c6a17104ad68 (1 commits) (flutter/engine#6536) d4bae4c Roll src/third_party/skia 2b2c00f6ec36..646d917d3c71 (1 commits) (flutter/engine#6535) ff93ccf Roll src/third_party/skia 681692726fc0..2b2c00f6ec36 (1 commits) (flutter/engine#6534) a4161c8 Roll src/third_party/skia 23775a2e9736..681692726fc0 (1 commits) (flutter/engine#6532) 116072e Roll src/third_party/skia 7435f2553f53..23775a2e9736 (1 commits) (flutter/engine#6531) ef0b0f6 Roll src/third_party/skia bc7a51e79c5b..7435f2553f53 (1 commits) (flutter/engine#6530) f46b7b9 Roll src/third_party/skia b28db529c866..bc7a51e79c5b (1 commits) (flutter/engine#6529) 9033c39 Roll src/third_party/skia 7e67041a1428..b28db529c866 (1 commits) (flutter/engine#6528) e6887a4 Add missing imports for unicode/utf16.h (flutter/engine#6524) 1242f6d Roll src/third_party/skia d38382d060ca..7e67041a1428 (2 commits) (flutter/engine#6527) a1bbea7 Add a no-op platform view layer. (flutter/engine#6505) 2bb3afa Roll src/third_party/skia 21bd60daa3f3..d38382d060ca (10 commits) (flutter/engine#6526) 75e8752 Fix the Mac embedder build (flutter/engine#6525) 436f970 Add version check for dismissable (flutter/engine#6522) 7767c78 Provide a default GL function resolver in the embedder (flutter/engine#6523) 32841dd Case-insensitive matching of family names for custom fonts (flutter/engine#6519) a9076c7 Roll src/third_party/skia 419709dbb167..21bd60daa3f3 (11 commits) (flutter/engine#6520) f2e7441 An API for loading fonts from a buffer provided by the application (flutter/engine#6508) 05aac0f fix ResourceExtractor npe. (flutter/engine#6461) cf5a2a1 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (flutter/engine#6517) 84fe4a9 Re-revert invalid line height tests (flutter/engine#6516) 5f52956 Add support for text shadows (flutter/engine#6385) e44c10c Reland "Share engine layers with the framework" (flutter#6412) (flutter/engine#6468) ba04499 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter/engine#6515) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.

flutter/engine@50c2e69...c645657 git log 50c2e69..c645657 --no-merges --oneline c645657 Roll src/third_party/skia c6a17104ad68..921ec976556c (31 commits) (flutter/engine#6546) 32f417d Roll tonic to 077be256142ede39a271385907faadf4fcc62a4d. (flutter/engine#6541) 4ee7725 Revert "Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter#6515)" (flutter/engine#6537) 964acaf Roll src/third_party/skia 646d917d3c71..c6a17104ad68 (1 commits) (flutter/engine#6536) d4bae4c Roll src/third_party/skia 2b2c00f6ec36..646d917d3c71 (1 commits) (flutter/engine#6535) ff93ccf Roll src/third_party/skia 681692726fc0..2b2c00f6ec36 (1 commits) (flutter/engine#6534) a4161c8 Roll src/third_party/skia 23775a2e9736..681692726fc0 (1 commits) (flutter/engine#6532) 116072e Roll src/third_party/skia 7435f2553f53..23775a2e9736 (1 commits) (flutter/engine#6531) ef0b0f6 Roll src/third_party/skia bc7a51e79c5b..7435f2553f53 (1 commits) (flutter/engine#6530) f46b7b9 Roll src/third_party/skia b28db529c866..bc7a51e79c5b (1 commits) (flutter/engine#6529) 9033c39 Roll src/third_party/skia 7e67041a1428..b28db529c866 (1 commits) (flutter/engine#6528) e6887a4 Add missing imports for unicode/utf16.h (flutter/engine#6524) 1242f6d Roll src/third_party/skia d38382d060ca..7e67041a1428 (2 commits) (flutter/engine#6527) a1bbea7 Add a no-op platform view layer. (flutter/engine#6505) 2bb3afa Roll src/third_party/skia 21bd60daa3f3..d38382d060ca (10 commits) (flutter/engine#6526) 75e8752 Fix the Mac embedder build (flutter/engine#6525) 436f970 Add version check for dismissable (flutter/engine#6522) 7767c78 Provide a default GL function resolver in the embedder (flutter/engine#6523) 32841dd Case-insensitive matching of family names for custom fonts (flutter/engine#6519) a9076c7 Roll src/third_party/skia 419709dbb167..21bd60daa3f3 (11 commits) (flutter/engine#6520) f2e7441 An API for loading fonts from a buffer provided by the application (flutter/engine#6508) 05aac0f fix ResourceExtractor npe. (flutter/engine#6461) cf5a2a1 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (flutter/engine#6517) 84fe4a9 Re-revert invalid line height tests (flutter/engine#6516) 5f52956 Add support for text shadows (flutter/engine#6385) e44c10c Reland "Share engine layers with the framework" (flutter#6412) (flutter/engine#6468) ba04499 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (flutter/engine#6515) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.

GaryQian requested a review from jason-simmons September 28, 2018 21:18

googlebot added cla: yes labels Sep 28, 2018

GaryQian requested a review from Hixie September 28, 2018 21:18

GaryQian mentioned this pull request Sep 28, 2018

Add support for text shadows. flutter/flutter#22449

Merged

GaryQian requested review from cbracken and chinmaygarde September 28, 2018 21:22

GaryQian mentioned this pull request Sep 28, 2018

libtxt: Text shadow flutter/flutter#3402

Closed

Hixie reviewed Sep 29, 2018

View reviewed changes

lib/ui/text.dart Outdated Show resolved Hide resolved

Hixie reviewed Sep 29, 2018

View reviewed changes

lib/ui/text.dart Outdated Show resolved Hide resolved

Hixie reviewed Sep 29, 2018

View reviewed changes

lib/ui/text.dart Outdated Show resolved Hide resolved

Hixie reviewed Sep 29, 2018

View reviewed changes

lib/ui/text.dart Outdated Show resolved Hide resolved

GaryQian force-pushed the textshadow branch 4 times, most recently from 9f3a726 to b444d3e Compare October 1, 2018 21:56

Add support for text shadows

6367857

GaryQian force-pushed the textshadow branch from b444d3e to 6367857 Compare October 2, 2018 00:08

Merge branch 'master' into textshadow

b4e1e0e

GaryQian force-pushed the textshadow branch from cd2d637 to bfe2b33 Compare October 2, 2018 17:14

googlebot added cla: no and removed cla: yes labels Oct 2, 2018

Merge

496a10f

GaryQian force-pushed the textshadow branch from bfe2b33 to 496a10f Compare October 2, 2018 17:24

engine-flutter-autoroll mentioned this pull request Oct 13, 2018

Roll engine 50c2e69daff4..2bb3afad8bf2 (13 commits) flutter/flutter#23037

Closed

engine-flutter-autoroll mentioned this pull request Oct 13, 2018

Roll engine 50c2e69daff4..a1bbea77cf6d (14 commits) flutter/flutter#23041

Closed

engine-flutter-autoroll mentioned this pull request Oct 13, 2018

Roll engine 50c2e69daff4..1242f6dfe11f (15 commits) flutter/flutter#23042

Closed

This was referenced Oct 13, 2018

Roll engine 50c2e69daff4..e6887a4121f7 (16 commits) flutter/flutter#23043

Closed

Roll engine 50c2e69daff4..9033c39021f2 (17 commits) flutter/flutter#23046

Closed

engine-flutter-autoroll mentioned this pull request Oct 13, 2018

Roll engine 50c2e69daff4..f46b7b9713ca (18 commits) flutter/flutter#23048

Closed

engine-flutter-autoroll mentioned this pull request Oct 13, 2018

Roll engine 50c2e69daff4..ef0b0f6e962b (19 commits) flutter/flutter#23059

Closed

engine-flutter-autoroll mentioned this pull request Oct 14, 2018

Roll engine 50c2e69daff4..116072e468c9 (20 commits) flutter/flutter#23065

Closed

This was referenced Oct 14, 2018

Roll engine 50c2e69daff4..a4161c8957fb (21 commits) flutter/flutter#23069

Closed

Roll engine 50c2e69daff4..ff93ccf473f2 (22 commits) flutter/flutter#23083

Closed

engine-flutter-autoroll mentioned this pull request Oct 15, 2018

Roll engine 50c2e69daff4..d4bae4ca4a95 (23 commits) flutter/flutter#23091

Closed

This was referenced Oct 15, 2018

Roll engine 50c2e69daff4..964acafebd32 (24 commits) flutter/flutter#23101

Closed

Roll engine 50c2e69daff4..4ee77256c0ab (25 commits) flutter/flutter#23111

Closed

engine-flutter-autoroll mentioned this pull request Oct 15, 2018

Roll engine 50c2e69daff4..32f417db0d56 (26 commits) flutter/flutter#23113

Closed

engine-flutter-autoroll mentioned this pull request Oct 15, 2018

Roll engine 50c2e69daff4..c6456570ab02 (27 commits) flutter/flutter#23120

Closed

Add support for text shadows #6385

Add support for text shadows #6385

Uh oh!

Conversation

GaryQian commented Sep 28, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

GaryQian commented Sep 28, 2018

Uh oh!

chinmaygarde commented Sep 28, 2018

Uh oh!

Hixie Sep 29, 2018

Choose a reason for hiding this comment

Uh oh!

GaryQian Sep 29, 2018

Choose a reason for hiding this comment

Uh oh!

Hixie Oct 1, 2018

Choose a reason for hiding this comment

Uh oh!

GaryQian Oct 1, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Hixie Oct 2, 2018

Choose a reason for hiding this comment

Uh oh!

GaryQian Oct 2, 2018

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Hixie Sep 29, 2018

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

googlebot commented Oct 2, 2018

Uh oh!

googlebot commented Oct 2, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

GaryQian commented Sep 28, 2018 •

edited

Loading

GaryQian Oct 1, 2018 •

edited

Loading