This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Add pushOffset to SceneBuilder #6349
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yjbanov
approved these changes
Sep 27, 2018
Contributor
|
LGTM if LGT @Hixie |
Contributor
Author
|
I'll merge this PR to trigger the auto-roller. |
Contributor
Author
|
@yjbanov : Oh, I thought your "LGTM if LGT @Hixie" comment was for flutter/flutter#21619 . Is it? |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 27, 2018
flutter/engine@9d4b80a...edf6249 git log 9d4b80a..edf6249 --no-merges --oneline edf6249 Add pushOffset to SceneBuilder (flutter/engine#6349) 3a01f39 Change log level from ERROR to WARNING (flutter/engine#6361) 5ae4708 Roll src/third_party/skia 227d4e10276c..ab3144c3abb9 (11 commits) (flutter/engine#6360) 763627f Do not export libdart symbols (flutter/engine#6337) 3052dbd SystemNavigator.pop can pop w/o UINavigationController (flutter/engine#6341) 0c096f7 Roll src/third_party/skia b3e48afc936d..227d4e10276c (1 commits) (flutter/engine#6359) b8c2a17 Roll src/third_party/skia cfe1264d7465..b3e48afc936d (3 commits) (flutter/engine#6356) c589b31 Expose push/popRoute on FlutterViewController (flutter/engine#6347) 075b3fc Roll src/third_party/skia 5ea41fc89b26..cfe1264d7465 (1 commits) (flutter/engine#6355) 2dd9b99 Roll Dart to version 808ed6238b9262660e31ea826f7aea6cfa3a3493 (flutter/engine#6354) 5b79938 Dont make any binaries specify an X11 dependency. (flutter/engine#6353) 309ac4e V0.8.2 fix compile problem with xcode10 (flutter/engine#6339) 26fdd1e Roll src/third_party/skia 5767fc042834..5ea41fc89b26 (3 commits) (flutter/engine#6351) cc44ca5 Perform persistent cache stores on the IO thread outside the frame workload. (flutter/engine#6350) f2a3df9 Wire up the Skia persistent GPU related artifacts cache. (flutter/engine#6278) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 27, 2018
flutter/engine@9d4b80a...d80c1de git log 9d4b80a..d80c1de --no-merges --oneline d80c1de Roll src/third_party/skia ab3144c3abb9..656cefe65d62 (11 commits) (flutter/engine#6362) edf6249 Add pushOffset to SceneBuilder (flutter/engine#6349) 3a01f39 Change log level from ERROR to WARNING (flutter/engine#6361) 5ae4708 Roll src/third_party/skia 227d4e10276c..ab3144c3abb9 (11 commits) (flutter/engine#6360) 763627f Do not export libdart symbols (flutter/engine#6337) 3052dbd SystemNavigator.pop can pop w/o UINavigationController (flutter/engine#6341) 0c096f7 Roll src/third_party/skia b3e48afc936d..227d4e10276c (1 commits) (flutter/engine#6359) b8c2a17 Roll src/third_party/skia cfe1264d7465..b3e48afc936d (3 commits) (flutter/engine#6356) c589b31 Expose push/popRoute on FlutterViewController (flutter/engine#6347) 075b3fc Roll src/third_party/skia 5ea41fc89b26..cfe1264d7465 (1 commits) (flutter/engine#6355) 2dd9b99 Roll Dart to version 808ed6238b9262660e31ea826f7aea6cfa3a3493 (flutter/engine#6354) 5b79938 Dont make any binaries specify an X11 dependency. (flutter/engine#6353) 309ac4e V0.8.2 fix compile problem with xcode10 (flutter/engine#6339) 26fdd1e Roll src/third_party/skia 5767fc042834..5ea41fc89b26 (3 commits) (flutter/engine#6351) cc44ca5 Perform persistent cache stores on the IO thread outside the frame workload. (flutter/engine#6350) f2a3df9 Wire up the Skia persistent GPU related artifacts cache. (flutter/engine#6278) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
GaryQian
pushed a commit
to GaryQian/engine
that referenced
this pull request
Oct 2, 2018
Contributor
|
I think LGTM on flutter/flutter#21619 implies LGTM on this PR too, since the other one wouldn't compile without this change. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For flutter/flutter#21619 (comment) and flutter/flutter#21756