This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Roll Dart to 4cf2d3990bac1f1df2f524899e1560a3683f3133 #6332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Included CLs: 4cf2d39 [VM runtime] Store Smi instance type in type test cache when using the interpreter. a6b1a99 Make mixins abstract by default ab305f2 Recover from duplicated declarations 4e32a35 Ignore synthetic elements created by the parser fc04f56 [infra] Remove deleted Dart 1 builders (app/precomp) from the test matrix 8477dc2 Update status after 570fd5a 1652850 Compute static types during impact computation b4341f0 Remove unneeded method rti need 570fd5a Error on re-export, export and import of libraries with same name. 4b312b2 Support multiple superclasses in the mixin `on` clause. 8debb4e [fuchsia] Add zx_vmo_replace_as_executable calls d34337a Ignore noSuchMethod() for the purpose of searching concrete member implementations. b6284b4 Revert "[VM] Dart_Initialize no longer crashes after Dart_Cleanup" 94481ad [vm] Only include debugger/profiler slots in RawCode in product mode. 519ee90 [VM] Dart_Initialize no longer crashes after Dart_Cleanup 5349754 [vm] Specialize 'new List()' on kernel AST afd4cc9 [vm/tfa] Infer concrete class of int literals in TFA a4d48f4 [vm/tfa] Infer concrete class of string literals in TFA 9106228 [vm, dwarf] Set default_is_stmt to true for compatability with dsymutil. 6ce0dc0 dartfix stub implementation e4eb243 Look into superclassConstraints while searching for a member in interfaces. 95d37b0 Revert "Implement inheritance/override checks from the spec." 355c73d [VM] Remove support for option --no-preview-dart-2 95b8a19 Mixin declarations don't have supertype, fix isMoreSpecificThan(). e9586a5 [vm] Update workaround for Android Kernel bug (b089d4f). ef7d144 Add regression test for issue 34392. 56f6c52 large_class_declaration_test is slow now. 0ac3b8f [fuchsia] Add missing vm:entry-point annotation 19e844e [dart/fuzzing] Use current directory as SDK top (by default) 58e44c1 Don't use ClassElementImpl for now in override checking. 62d154f [vm/bytecode] Record null-initialized fields in bytecode 70cc34d Custom format errors and exceptions to show traces 9583113 Fix NPE when accessing superclass 836a1d7 Implement inheritance/override checks from the spec. d070397 Remove redundant resolution dba8b37 [vm] Benchmark for reading kernel bytecode
rmacnak-google
approved these changes
Sep 25, 2018
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 25, 2018
flutter/engine@74625ae...38a646e git log 74625ae..38a646e --no-merges --oneline 38a646e [buildroot] Roll buildroot to pick up updated created_updated_flutter_deps.py (flutter/engine#6333) 4b5be9b Roll Dart to 4cf2d3990bac1f1df2f524899e1560a3683f3133 (flutter/engine#6332) 5d19c87 Roll src/third_party/skia e514fa0f1a6c..4ef464cd3c2e (1 commits) (flutter/engine#6329) 5879dae Roll src/third_party/skia a85f3a138cbc..e514fa0f1a6c (1 commits) (flutter/engine#6328) 4974d74 Roll src/third_party/skia 45239cb84d1d..a85f3a138cbc (7 commits) (flutter/engine#6327) 8743bb8 Format for flutter#6324 (flutter/engine#6326) 89516aa Engine::Run returns enum: success, failure, or isolate already running (flutter/engine#6324) 83ec05d Roll src/third_party/skia a9adb6f03525..45239cb84d1d (9 commits) (flutter/engine#6323) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 25, 2018
flutter/engine@74625ae...2ead5c0 git log 74625ae..2ead5c0 --no-merges --oneline 2ead5c0 Roll src/third_party/skia 4ef464cd3c2e..7ffa40cedbc4 (10 commits) (flutter/engine#6334) 38a646e [buildroot] Roll buildroot to pick up updated created_updated_flutter_deps.py (flutter/engine#6333) 4b5be9b Roll Dart to 4cf2d3990bac1f1df2f524899e1560a3683f3133 (flutter/engine#6332) 5d19c87 Roll src/third_party/skia e514fa0f1a6c..4ef464cd3c2e (1 commits) (flutter/engine#6329) 5879dae Roll src/third_party/skia a85f3a138cbc..e514fa0f1a6c (1 commits) (flutter/engine#6328) 4974d74 Roll src/third_party/skia 45239cb84d1d..a85f3a138cbc (7 commits) (flutter/engine#6327) 8743bb8 Format for flutter#6324 (flutter/engine#6326) 89516aa Engine::Run returns enum: success, failure, or isolate already running (flutter/engine#6324) 83ec05d Roll src/third_party/skia a9adb6f03525..45239cb84d1d (9 commits) (flutter/engine#6323) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 25, 2018
flutter/engine@74625ae...8247ce2 git log 74625ae..8247ce2 --no-merges --oneline 8247ce2 Implement restore functions on Android and iOS (flutter/engine#6322) 2ead5c0 Roll src/third_party/skia 4ef464cd3c2e..7ffa40cedbc4 (10 commits) (flutter/engine#6334) 38a646e [buildroot] Roll buildroot to pick up updated created_updated_flutter_deps.py (flutter/engine#6333) 4b5be9b Roll Dart to 4cf2d3990bac1f1df2f524899e1560a3683f3133 (flutter/engine#6332) 5d19c87 Roll src/third_party/skia e514fa0f1a6c..4ef464cd3c2e (1 commits) (flutter/engine#6329) 5879dae Roll src/third_party/skia a85f3a138cbc..e514fa0f1a6c (1 commits) (flutter/engine#6328) 4974d74 Roll src/third_party/skia 45239cb84d1d..a85f3a138cbc (7 commits) (flutter/engine#6327) 8743bb8 Format for flutter#6324 (flutter/engine#6326) 89516aa Engine::Run returns enum: success, failure, or isolate already running (flutter/engine#6324) 83ec05d Roll src/third_party/skia a9adb6f03525..45239cb84d1d (9 commits) (flutter/engine#6323) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Included CLs:
4cf2d39 [VM runtime] Store Smi instance type in type test cache when using the interpreter.
a6b1a99 Make mixins abstract by default
ab305f2 Recover from duplicated declarations
4e32a35 Ignore synthetic elements created by the parser
fc04f56 [infra] Remove deleted Dart 1 builders (app/precomp) from the test matrix
8477dc2 Update status after 570fd5a
1652850 Compute static types during impact computation
b4341f0 Remove unneeded method rti need
570fd5a Error on re-export, export and import of libraries with same name.
4b312b2 Support multiple superclasses in the mixin
onclause.8debb4e [fuchsia] Add zx_vmo_replace_as_executable calls
d34337a Ignore noSuchMethod() for the purpose of searching concrete member implementations.
b6284b4 Revert "[VM] Dart_Initialize no longer crashes after Dart_Cleanup"
94481ad [vm] Only include debugger/profiler slots in RawCode in product mode.
519ee90 [VM] Dart_Initialize no longer crashes after Dart_Cleanup
5349754 [vm] Specialize 'new List()' on kernel AST
afd4cc9 [vm/tfa] Infer concrete class of int literals in TFA
a4d48f4 [vm/tfa] Infer concrete class of string literals in TFA
9106228 [vm, dwarf] Set default_is_stmt to true for compatability with dsymutil.
6ce0dc0 dartfix stub implementation
e4eb243 Look into superclassConstraints while searching for a member in interfaces.
95d37b0 Revert "Implement inheritance/override checks from the spec."
355c73d [VM] Remove support for option --no-preview-dart-2
95b8a19 Mixin declarations don't have supertype, fix isMoreSpecificThan().
e9586a5 [vm] Update workaround for Android Kernel bug (b089d4f).
ef7d144 Add regression test for issue 34392.
56f6c52 large_class_declaration_test is slow now.
0ac3b8f [fuchsia] Add missing vm:entry-point annotation
19e844e [dart/fuzzing] Use current directory as SDK top (by default)
58e44c1 Don't use ClassElementImpl for now in override checking.
62d154f [vm/bytecode] Record null-initialized fields in bytecode
70cc34d Custom format errors and exceptions to show traces
9583113 Fix NPE when accessing superclass
836a1d7 Implement inheritance/override checks from the spec.
d070397 Remove redundant resolution
dba8b37 [vm] Benchmark for reading kernel bytecode