Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

If isolate is already running, return true #6324

Merged
dnfield merged 3 commits into from
Sep 24, 2018
Merged

If isolate is already running, return true #6324

dnfield merged 3 commits into from
Sep 24, 2018

Conversation

@dnfield
Copy link
Contributor

@dnfield dnfield commented Sep 24, 2018

On iOS, viewWillAppear can be called when returning from plugin callbacks that show native controls (e.g. image_picker or open_file). This causes error messages to be printed because the engine sees the isolate is already running.

This change adds a check to see if the isolate is already running when PrepareAndLaunchIsolate is called, and if so just return true.

I'm not 100% certain this is correct, but the error messages are causing people to think things are wrong when they're not (or to think the wrong things are wrong): see flutter/flutter#21221 and related

@dnfield
Copy link
Contributor Author

dnfield commented Sep 24, 2018

Per discussion, I'm going to create a new return type for Engine::Run so callers can get some insight into the acutal result here.

@dnfield
Copy link
Contributor Author

dnfield commented Sep 24, 2018

Updated to use enum, @cbracken @chinmaygarde PTAL

@chinmaygarde
Copy link
Member

chinmaygarde commented Sep 24, 2018

Please modify the commit message before committing. Looks great otherwise. Thanks!

@dnfield dnfield merged commit 89516aa into flutter:master Sep 24, 2018
@dnfield dnfield mentioned this pull request Sep 24, 2018
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 24, 2018
@engine-flutter-autoroll
Roll engine 74625ae..89516aa (2 commits)
b920227 
flutter/engine@74625ae...89516aa

git log 74625ae..89516aa --no-merges --oneline
89516aa Engine::Run returns enum: success, failure, or isolate already running (flutter/engine#6324)
83ec05d Roll src/third_party/skia a9adb6f03525..45239cb84d1d (9 commits) (flutter/engine#6323)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 24, 2018
Closed
dnfield added a commit that referenced this pull request Sep 24, 2018
@dnfield
Format for #6324 (#6326)
8743bb8 
Format code from previous patch
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 24, 2018
@engine-flutter-autoroll
Roll engine 74625ae..4974d74 (4 commits)
6e7aaea 
flutter/engine@74625ae...4974d74

git log 74625ae..4974d74 --no-merges --oneline
4974d74 Roll src/third_party/skia 45239cb84d1d..a85f3a138cbc (7 commits) (flutter/engine#6327)
8743bb8 Format for flutter#6324 (flutter/engine#6326)
89516aa Engine::Run returns enum: success, failure, or isolate already running (flutter/engine#6324)
83ec05d Roll src/third_party/skia a9adb6f03525..45239cb84d1d (9 commits) (flutter/engine#6323)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 24, 2018
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 25, 2018
@engine-flutter-autoroll
Roll engine 74625ae..5879dae (5 commits)
a73e87b 
flutter/engine@74625ae...5879dae

git log 74625ae..5879dae --no-merges --oneline
5879dae Roll src/third_party/skia a85f3a138cbc..e514fa0f1a6c (1 commits) (flutter/engine#6328)
4974d74 Roll src/third_party/skia 45239cb84d1d..a85f3a138cbc (7 commits) (flutter/engine#6327)
8743bb8 Format for flutter#6324 (flutter/engine#6326)
89516aa Engine::Run returns enum: success, failure, or isolate already running (flutter/engine#6324)
83ec05d Roll src/third_party/skia a9adb6f03525..45239cb84d1d (9 commits) (flutter/engine#6323)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 25, 2018
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 25, 2018
@engine-flutter-autoroll
Roll engine 74625ae..5d19c87 (6 commits)
df8b56d 
flutter/engine@74625ae...5d19c87

git log 74625ae..5d19c87 --no-merges --oneline
5d19c87 Roll src/third_party/skia e514fa0f1a6c..4ef464cd3c2e (1 commits) (flutter/engine#6329)
5879dae Roll src/third_party/skia a85f3a138cbc..e514fa0f1a6c (1 commits) (flutter/engine#6328)
4974d74 Roll src/third_party/skia 45239cb84d1d..a85f3a138cbc (7 commits) (flutter/engine#6327)
8743bb8 Format for flutter#6324 (flutter/engine#6326)
89516aa Engine::Run returns enum: success, failure, or isolate already running (flutter/engine#6324)
83ec05d Roll src/third_party/skia a9adb6f03525..45239cb84d1d (9 commits) (flutter/engine#6323)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 25, 2018
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 25, 2018
@engine-flutter-autoroll
Roll engine 74625ae..38a646e (8 commits)
a54f0f8 
flutter/engine@74625ae...38a646e

git log 74625ae..38a646e --no-merges --oneline
38a646e [buildroot] Roll buildroot to pick up updated created_updated_flutter_deps.py (flutter/engine#6333)
4b5be9b Roll Dart to 4cf2d3990bac1f1df2f524899e1560a3683f3133 (flutter/engine#6332)
5d19c87 Roll src/third_party/skia e514fa0f1a6c..4ef464cd3c2e (1 commits) (flutter/engine#6329)
5879dae Roll src/third_party/skia a85f3a138cbc..e514fa0f1a6c (1 commits) (flutter/engine#6328)
4974d74 Roll src/third_party/skia 45239cb84d1d..a85f3a138cbc (7 commits) (flutter/engine#6327)
8743bb8 Format for flutter#6324 (flutter/engine#6326)
89516aa Engine::Run returns enum: success, failure, or isolate already running (flutter/engine#6324)
83ec05d Roll src/third_party/skia a9adb6f03525..45239cb84d1d (9 commits) (flutter/engine#6323)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 25, 2018
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 25, 2018
@engine-flutter-autoroll
Roll engine 74625ae..2ead5c0 (9 commits)
2e1edec 
flutter/engine@74625ae...2ead5c0

git log 74625ae..2ead5c0 --no-merges --oneline
2ead5c0 Roll src/third_party/skia 4ef464cd3c2e..7ffa40cedbc4 (10 commits) (flutter/engine#6334)
38a646e [buildroot] Roll buildroot to pick up updated created_updated_flutter_deps.py (flutter/engine#6333)
4b5be9b Roll Dart to 4cf2d3990bac1f1df2f524899e1560a3683f3133 (flutter/engine#6332)
5d19c87 Roll src/third_party/skia e514fa0f1a6c..4ef464cd3c2e (1 commits) (flutter/engine#6329)
5879dae Roll src/third_party/skia a85f3a138cbc..e514fa0f1a6c (1 commits) (flutter/engine#6328)
4974d74 Roll src/third_party/skia 45239cb84d1d..a85f3a138cbc (7 commits) (flutter/engine#6327)
8743bb8 Format for flutter#6324 (flutter/engine#6326)
89516aa Engine::Run returns enum: success, failure, or isolate already running (flutter/engine#6324)
83ec05d Roll src/third_party/skia a9adb6f03525..45239cb84d1d (9 commits) (flutter/engine#6323)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 25, 2018
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 25, 2018
@engine-flutter-autoroll
Roll engine 74625ae..8247ce2 (10 commits)
903ee72 
flutter/engine@74625ae...8247ce2

git log 74625ae..8247ce2 --no-merges --oneline
8247ce2 Implement restore functions on Android and iOS (flutter/engine#6322)
2ead5c0 Roll src/third_party/skia 4ef464cd3c2e..7ffa40cedbc4 (10 commits) (flutter/engine#6334)
38a646e [buildroot] Roll buildroot to pick up updated created_updated_flutter_deps.py (flutter/engine#6333)
4b5be9b Roll Dart to 4cf2d3990bac1f1df2f524899e1560a3683f3133 (flutter/engine#6332)
5d19c87 Roll src/third_party/skia e514fa0f1a6c..4ef464cd3c2e (1 commits) (flutter/engine#6329)
5879dae Roll src/third_party/skia a85f3a138cbc..e514fa0f1a6c (1 commits) (flutter/engine#6328)
4974d74 Roll src/third_party/skia 45239cb84d1d..a85f3a138cbc (7 commits) (flutter/engine#6327)
8743bb8 Format for flutter#6324 (flutter/engine#6326)
89516aa Engine::Run returns enum: success, failure, or isolate already running (flutter/engine#6324)
83ec05d Roll src/third_party/skia a9adb6f03525..45239cb84d1d (9 commits) (flutter/engine#6323)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 25, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@chinmaygarde chinmaygarde chinmaygarde approved these changes

@cbracken cbracken cbracken approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dnfield @chinmaygarde @cbracken @googlebot