This repository was archived by the owner on Feb 25, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6k
Dart SDK roll for 2018-09-21 #6311
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
654c4ba [vm/bytecode] Fix a couple of assertions when running with bytecode b540626 Change DeclarationResolver to extend RecursiveAstVisitor<void>. 52bec5e Update parser to find token on which to report the error 93dcfaa [vm, gc] Concurrent marking. e06ef81 [vm] Unconditionally generate interpreter stubs 6a04b30 Fix test_mixinInference_noMatchingClass_namedMixinApplication_new_syntax 484405b Fix missing_return hint in _getInferredMixinType 1357778 Issue 34546. Get ClassElementImpl a way that support element handles. 012b705 [VM interpreter] Use a helper to test entry frame pc marker. e22dd19 Create a base class for compile-time error code test cases. 491db89 Upgrade dartdoc to v0.21.1 7cd2570 Fix parsing label between 2 switch cases 33f6c8e More super mixin tests. e9ff597 Optimize gatherMixinSupertypeConstraints for new mixin syntax. 5cf0d9e Replicate existing analyzer supermixin tests using new "mixin" syntax. 20342ce [vm/compiler] added compilation trace tracer c92406f bump to linter 0.1.63 19e2040 [vm] Cleanup the ability to specify entry points via JSON and text files ead158a Fix gatherMixinSupertypeConstraints to handle named mixin applications. 51f2dac Reland: [vm] Adds a benchmark for Dart_LoadLibraryFromKernel 82c784a Revert "[vm] Adds a benchmark for Dart_LoadLibraryFromKernel" 762a14e Update dart2js_dynamic_test to exclude CFE code. 0c60a52 [VM bytecode] Triage failures in interpreted mode. e75a48b Add status entries for dartdevk on new super invocation tests 46e5954 Turn on and fix mixin type inference checks when not in "supermixin" mode. b7f7629 Add tests for more super invocation edge cases 64b6d71 [dartdevc] enable super mixin support in Kernel backend 0ec9945 Fix #33629 boolean negation of void 0b5a7c8 Add support for intermittent filesystems to the analysis server, this PR is a synced version of Devons PR https://dart-review.googlesource.com/c/sdk/+/72980, without the DAS protocol change. fee8efa [vm] Adds a benchmark for Dart_LoadLibraryFromKernel 46ec629 [vm/bytecode] Trigger JIT-compilation from interpreter 9f5aecb Introduce a new flag to the Dart Analysis Server: --ux-experiment-1 which changes analysis roots to the be the current set of priority files. 9f72b09 Convert resolver.dart to triple-slash comment style. ee0a603 Fix checks for absence of concrete implementations of super-invoked members. 3a5b748 Optimize index data structure for search by supertype id. af2fd41 Update more analyzer error codes to be generated from messages.yaml 0bbdd8f [build] Correctly rebase kernel-service output for depfile cbf6067 [vm/fuzzer] Migrated driver from Python to Dart. e95d944 [VM interpreter] Propagate error from invoked compiled function to interpreter caller. 05ba853 Cleanup fasta parser rewriter insert token methods 07a1f23 Improve parser recover to fix more code completion tests ffa99b9 Update analyzer error code generation fa0b38b Fix some constructor initializer code completion situations 2455141 Remove ClassElement.isSuperConstructorAccessible(). 3263550 [vm] Decouple bytecode reading from compilation e3dbea9 Convert declaration_resolver.dart to triple-slash comment style. d32e93d Remove unused import. 4baa3ec Create a base class for non-error resolver test cases. 2e43557 Mark Kernel classes that were Dart mixin declarations
rmacnak-google
approved these changes
Sep 22, 2018
Contributor
rmacnak-google
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 22, 2018
flutter/engine@cc3009c...7648d21 git log cc3009c..7648d21 --no-merges --oneline 7648d21 Dart SDK roll for 2018-09-21 (flutter/engine#6311) 5b8e8c3 Make FlutterStandardCodec handle writing NSData (flutter/engine#6207) 02901b7 Decouple PlatformViewsController from FlutterView. (flutter/engine#6303) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 22, 2018
flutter/engine@cc3009c...19ac3e1 git log cc3009c..19ac3e1 --no-merges --oneline 19ac3e1 Roll src/third_party/skia 358558a4cecc..11f4994b84e1 (2 commits) (flutter/engine#6312) 7648d21 Dart SDK roll for 2018-09-21 (flutter/engine#6311) 5b8e8c3 Make FlutterStandardCodec handle writing NSData (flutter/engine#6207) 02901b7 Decouple PlatformViewsController from FlutterView. (flutter/engine#6303) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 22, 2018
flutter/engine@cc3009c...f3a3d0c git log cc3009c..f3a3d0c --no-merges --oneline f3a3d0c Roll src/third_party/skia 11f4994b84e1..175b587a634d (1 commits) (flutter/engine#6313) 19ac3e1 Roll src/third_party/skia 358558a4cecc..11f4994b84e1 (2 commits) (flutter/engine#6312) 7648d21 Dart SDK roll for 2018-09-21 (flutter/engine#6311) 5b8e8c3 Make FlutterStandardCodec handle writing NSData (flutter/engine#6207) 02901b7 Decouple PlatformViewsController from FlutterView. (flutter/engine#6303) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Sep 22, 2018
flutter/engine@cc3009c...f3a3d0c git log cc3009c..f3a3d0c --no-merges --oneline f3a3d0c Roll src/third_party/skia 11f4994b84e1..175b587a634d (1 commits) (flutter/engine#6313) 19ac3e1 Roll src/third_party/skia 358558a4cecc..11f4994b84e1 (2 commits) (flutter/engine#6312) 7648d21 Dart SDK roll for 2018-09-21 (flutter/engine#6311) 5b8e8c3 Make FlutterStandardCodec handle writing NSData (flutter/engine#6207) 02901b7 Decouple PlatformViewsController from FlutterView. (flutter/engine#6303) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
654c4ba [vm/bytecode] Fix a couple of assertions when running with bytecode
b540626 Change DeclarationResolver to extend RecursiveAstVisitor.
52bec5e Update parser to find token on which to report the error
93dcfaa [vm, gc] Concurrent marking.
e06ef81 [vm] Unconditionally generate interpreter stubs
6a04b30 Fix test_mixinInference_noMatchingClass_namedMixinApplication_new_syntax
484405b Fix missing_return hint in _getInferredMixinType
1357778 Issue 34546. Get ClassElementImpl a way that support element handles.
012b705 [VM interpreter] Use a helper to test entry frame pc marker.
e22dd19 Create a base class for compile-time error code test cases.
491db89 Upgrade dartdoc to v0.21.1
7cd2570 Fix parsing label between 2 switch cases
33f6c8e More super mixin tests.
e9ff597 Optimize gatherMixinSupertypeConstraints for new mixin syntax.
5cf0d9e Replicate existing analyzer supermixin tests using new "mixin" syntax.
20342ce [vm/compiler] added compilation trace tracer
c92406f bump to linter 0.1.63
19e2040 [vm] Cleanup the ability to specify entry points via JSON and text files
ead158a Fix gatherMixinSupertypeConstraints to handle named mixin applications.
51f2dac Reland: [vm] Adds a benchmark for Dart_LoadLibraryFromKernel
82c784a Revert "[vm] Adds a benchmark for Dart_LoadLibraryFromKernel"
762a14e Update dart2js_dynamic_test to exclude CFE code.
0c60a52 [VM bytecode] Triage failures in interpreted mode.
e75a48b Add status entries for dartdevk on new super invocation tests
46e5954 Turn on and fix mixin type inference checks when not in "supermixin" mode.
b7f7629 Add tests for more super invocation edge cases
64b6d71 [dartdevc] enable super mixin support in Kernel backend
0ec9945 Fix #33629 boolean negation of void
0b5a7c8 Add support for intermittent filesystems to the analysis server, this PR is a synced version of Devons PR https://dart-review.googlesource.com/c/sdk/+/72980, without the DAS protocol change.
fee8efa [vm] Adds a benchmark for Dart_LoadLibraryFromKernel
46ec629 [vm/bytecode] Trigger JIT-compilation from interpreter
9f5aecb Introduce a new flag to the Dart Analysis Server: --ux-experiment-1 which changes analysis roots to the be the current set of priority files.
9f72b09 Convert resolver.dart to triple-slash comment style.
ee0a603 Fix checks for absence of concrete implementations of super-invoked members.
3a5b748 Optimize index data structure for search by supertype id.
af2fd41 Update more analyzer error codes to be generated from messages.yaml
0bbdd8f [build] Correctly rebase kernel-service output for depfile
cbf6067 [vm/fuzzer] Migrated driver from Python to Dart.
e95d944 [VM interpreter] Propagate error from invoked compiled function to interpreter caller.
05ba853 Cleanup fasta parser rewriter insert token methods
07a1f23 Improve parser recover to fix more code completion tests
ffa99b9 Update analyzer error code generation
fa0b38b Fix some constructor initializer code completion situations
2455141 Remove ClassElement.isSuperConstructorAccessible().
3263550 [vm] Decouple bytecode reading from compilation
e3dbea9 Convert declaration_resolver.dart to triple-slash comment style.
d32e93d Remove unused import.
4baa3ec Create a base class for non-error resolver test cases.
2e43557 Mark Kernel classes that were Dart mixin declarations