Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@amirh
Copy link
Contributor

@amirh amirh commented Sep 21, 2018

Reverts #6279

@amirh amirh merged commit bbdf7c1 into master Sep 21, 2018
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 21, 2018
flutter/engine@a8890fd...bbdf7c1

git log a8890fd..bbdf7c1 --no-merges --oneline
bbdf7c1 Revert "Fix a compilation problem when using iPhoneOS12.0sdk(Xcode10) && clang version 7.0.0." (flutter/engine#6307)
dea0921 Roll src/third_party/skia c25f440d537e..358558a4cecc (17 commits) (flutter/engine#6308)
d29c7db Add logging if FlutterDartProject fails to load the application kernel snapshot (flutter/engine#6257)
2a1debf Update deprecated subtags from language subtag registry. (flutter/engine#6280)
540cd96 Add Xib splashscreen support (flutter/engine#6289)
05f21e6 Fix a compilation problem when using iPhoneOS12.0sdk(Xcode10) && clang version 7.0.0. (flutter/engine#6279)
ca6f103 Roll src/third_party/skia d842557c0724..c25f440d537e (10 commits) (flutter/engine#6304)
3b46705 Roll src/third_party/skia 38ca6d509d9f..d842557c0724 (5 commits) (flutter/engine#6302)
0c166fe Roll src/third_party/skia 05cf051f0252..38ca6d509d9f (1 commits) (flutter/engine#6301)
cf0fbad Roll src/third_party/skia 44c6167c4125..05cf051f0252 (4 commits) (flutter/engine#6299)
2ec20aa Remove bottom safe-area padding when keyboard up (flutter/engine#6297)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 21, 2018
flutter/engine@a8890fd...cc3009c

git log a8890fd..cc3009c --no-merges --oneline
cc3009c Revert 'Dart SDK roll for 2018/09/20' 8471862 (flutter/engine#6309)
bbdf7c1 Revert "Fix a compilation problem when using iPhoneOS12.0sdk(Xcode10) && clang version 7.0.0." (flutter/engine#6307)
dea0921 Roll src/third_party/skia c25f440d537e..358558a4cecc (17 commits) (flutter/engine#6308)
d29c7db Add logging if FlutterDartProject fails to load the application kernel snapshot (flutter/engine#6257)
2a1debf Update deprecated subtags from language subtag registry. (flutter/engine#6280)
540cd96 Add Xib splashscreen support (flutter/engine#6289)
05f21e6 Fix a compilation problem when using iPhoneOS12.0sdk(Xcode10) && clang version 7.0.0. (flutter/engine#6279)
ca6f103 Roll src/third_party/skia d842557c0724..c25f440d537e (10 commits) (flutter/engine#6304)
3b46705 Roll src/third_party/skia 38ca6d509d9f..d842557c0724 (5 commits) (flutter/engine#6302)
0c166fe Roll src/third_party/skia 05cf051f0252..38ca6d509d9f (1 commits) (flutter/engine#6301)
cf0fbad Roll src/third_party/skia 44c6167c4125..05cf051f0252 (4 commits) (flutter/engine#6299)
2ec20aa Remove bottom safe-area padding when keyboard up (flutter/engine#6297)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 21, 2018
flutter/engine@a8890fd...5b8e8c3

git log a8890fd..5b8e8c3 --no-merges --oneline
5b8e8c3 Make FlutterStandardCodec handle writing NSData (flutter/engine#6207)
02901b7 Decouple PlatformViewsController from FlutterView. (flutter/engine#6303)
cc3009c Revert 'Dart SDK roll for 2018/09/20' 8471862 (flutter/engine#6309)
bbdf7c1 Revert "Fix a compilation problem when using iPhoneOS12.0sdk(Xcode10) && clang version 7.0.0." (flutter/engine#6307)
dea0921 Roll src/third_party/skia c25f440d537e..358558a4cecc (17 commits) (flutter/engine#6308)
d29c7db Add logging if FlutterDartProject fails to load the application kernel snapshot (flutter/engine#6257)
2a1debf Update deprecated subtags from language subtag registry. (flutter/engine#6280)
540cd96 Add Xib splashscreen support (flutter/engine#6289)
05f21e6 Fix a compilation problem when using iPhoneOS12.0sdk(Xcode10) && clang version 7.0.0. (flutter/engine#6279)
ca6f103 Roll src/third_party/skia d842557c0724..c25f440d537e (10 commits) (flutter/engine#6304)
3b46705 Roll src/third_party/skia 38ca6d509d9f..d842557c0724 (5 commits) (flutter/engine#6302)
0c166fe Roll src/third_party/skia 05cf051f0252..38ca6d509d9f (1 commits) (flutter/engine#6301)
cf0fbad Roll src/third_party/skia 44c6167c4125..05cf051f0252 (4 commits) (flutter/engine#6299)
2ec20aa Remove bottom safe-area padding when keyboard up (flutter/engine#6297)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
@cbracken cbracken deleted the revert-6279-v0.8.2_fix_compile_problem_with_xcode10 branch November 26, 2018 20:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants