This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Ensure that objects on stack that close traces have unique variable names. #6298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbracken
approved these changes
Sep 21, 2018
| #define __FML__TOKEN_CAT__2(x, y) __FML__TOKEN_CAT__(x, y) | ||
| #define __FML__AUTO_TRACE_END(name) \ | ||
| ::fml::tracing::ScopedInstantEnd __FML__TOKEN_CAT__2(__trace_end_, \ | ||
| __LINE__)(name); |
Member
There was a problem hiding this comment.
Consider adding a comment explaining the need for concatenation voodoo to deal with the macro expansion for __LINE__.
Member
Author
There was a problem hiding this comment.
The old implementation just didn't work. I actually don't know what to say other than this is how to do concatenation of line numbers. Happy to add more documentation in a subsequent patch.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 22, 2018
flutter/engine@f3a3d0c...57fd394 git log f3a3d0c..57fd394 --no-merges --oneline 57fd394 Ensure that objects on stack that close traces have unique variable names. (flutter/engine#6298) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Sep 22, 2018
flutter/engine@f3a3d0c...57fd394 git log f3a3d0c..57fd394 --no-merges --oneline 57fd394 Ensure that objects on stack that close traces have unique variable names. (flutter/engine#6298) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.