Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Roll src/third_party/skia c9873a5f8b8e..f3ebd312f213 (14 commits) #6290

Merged
skia-flutter-autoroll merged 1 commit into from
Sep 20, 2018
Merged

Roll src/third_party/skia c9873a5f8b8e..f3ebd312f213 (14 commits) #6290

skia-flutter-autoroll merged 1 commit into from
Sep 20, 2018

Conversation

@skia-flutter-autoroll
Copy link
Contributor

@skia-flutter-autoroll skia-flutter-autoroll commented Sep 20, 2018

https://skia.googlesource.com/skia.git/+log/c9873a5f8b8e..f3ebd312f213

Created with:
gclient setdep -r src/third_party/skia@f3ebd312f213

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

@skia-flutter-autoroll
Copy link
Contributor Author

skia-flutter-autoroll commented Sep 20, 2018

@reed : New roll has been created by https://autoroll.skia.org/r/skia-flutter-autoroll

@skia-flutter-autoroll
Copy link
Contributor Author

skia-flutter-autoroll commented Sep 20, 2018

Auto-roller completed checks. About to merge.

@skia-flutter-autoroll skia-flutter-autoroll merged commit 09afb2b into flutter:master Sep 20, 2018
@aam
Copy link
Member

aam commented Sep 20, 2018

This seem to have broken flutter engine buildbot on Windows:

FAILED: obj/third_party/skia/src/core/skia.SkConvertPixels.obj 
ninja -t msvc -e environment.x64 -- ...\goma_cache\client/gomacc.exe "E:\b\depot_tools\win_toolchain\vs_files\9bc7ccbf9f4bd50d4a3bd185e8ca94ff1618de0b\VC\Tools\MSVC\14.11.25503\bin\HostX64\x64/cl.exe" /nologo /showIncludes /FC @obj/third_party/skia/src/core/skia.SkConvertPixels.obj.rsp /c ../../third_party/skia/src/core/SkConvertPixels.cpp /Foobj/third_party/skia/src/core/skia.SkConvertPixels.obj /Fdobj/third_party/skia/skia_cc.pdb
...\windows_engine\build\src\third_party\skia\src\core\skconvertpixels.cpp(63): error C2593: 'operator +' is ambiguous
...\windows_engine\build\src\third_party\skia\src\core\skconvertpixels.cpp(63): note: could be 'built-in C++ operator+(void (__cdecl *)(uint32_t *,const void *,int))'
...\windows_engine\build\src\third_party\skia\src\core\skconvertpixels.cpp(63): note: or       'built-in C++ operator+(void (__vectorcall *)(uint32_t *,const void *,int))'
...\windows_engine\build\src\third_party\skia\src\core\skconvertpixels.cpp(63): note: while trying to match the argument list '(swizzle_and_multiply::<lambda_361bf48cf8be83e040ea9df76eb2d764>)'
...\windows_engine\build\src\third_party\skia\src\core\skconvertpixels.cpp(63): error C2088: '+': illegal for class
...\windows_engine\build\src\third_party\skia\src\core\skconvertpixels.cpp(65): error C2593: 'operator +' is ambiguous
...\windows_engine\build\src\third_party\skia\src\core\skconvertpixels.cpp(65): note: could be 'built-in C++ operator+(void (__cdecl *)(uint32_t *,const void *,int))'
...\windows_engine\build\src\third_party\skia\src\core\skconvertpixels.cpp(65): note: or       'built-in C++ operator+(void (__vectorcall *)(uint32_t *,const void *,int))'
...\windows_engine\build\src\third_party\skia\src\core\skconvertpixels.cpp(65): note: while trying to match the argument list '(swizzle_and_multiply::<lambda_afc9e508deb310c19b5bc57e6884a242>)'
...\windows_engine\build\src\third_party\skia\src\core\skconvertpixels.cpp(65): error C2088: '+': illegal for class

@aam
Copy link
Member

aam commented Sep 20, 2018

cc @jason-simmons

@aam
Copy link
Member

aam commented Sep 20, 2018

cc @reed-at-google @chinmaygarde

aam added a commit to aam/engine that referenced this pull request Sep 20, 2018
@aam
Revert "Roll src/third_party/skia c9873a5..f3ebd31 (14 commits) (flut…
6784bcb 
…ter#6290)" as it broke Windows buildbot.

This reverts commit 09afb2b.
@aam aam mentioned this pull request Sep 20, 2018
Merged
aam added a commit that referenced this pull request Sep 20, 2018
@aam
Revert "Roll src/third_party/skia c9873a5..f3ebd31 (14 commits) (#6290)…
0036a3a 
…" as it broke Windows buildbot. (#6292)

This reverts commit 09afb2b.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 20, 2018
@engine-flutter-autoroll
Roll engine 71457a6..0036a3a (4 commits)
6a614ef 
flutter/engine@71457a6...0036a3a

git log 71457a6..0036a3a --no-merges --oneline
0036a3a Revert &#34;Roll src/third_party/skia c9873a5f8b8e..f3ebd312f213 (14 commits) (flutter#6290)&#34; as it broke Windows buildbot. (flutter/engine#6292)
ff78707 Remove runtime/dart_vm_entry_points.txt (flutter/engine#6291)
09afb2b Roll src/third_party/skia c9873a5f8b8e..f3ebd312f213 (14 commits) (flutter/engine#6290)
2302bea Roll src/third_party/skia 9369031fde2d..c9873a5f8b8e (11 commits) (flutter/engine#6287)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/&#43;/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC&#39;d on the roll, and stop the roller if necessary.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 20, 2018
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 21, 2018
@engine-flutter-autoroll
Roll engine 71457a6..8471862 (5 commits)
4c37729 
flutter/engine@71457a6...8471862

git log 71457a6..8471862 --no-merges --oneline
8471862 Dart SDK roll for 2018/09/20 (flutter/engine#6294)
0036a3a Revert &#34;Roll src/third_party/skia c9873a5f8b8e..f3ebd312f213 (14 commits) (flutter#6290)&#34; as it broke Windows buildbot. (flutter/engine#6292)
ff78707 Remove runtime/dart_vm_entry_points.txt (flutter/engine#6291)
09afb2b Roll src/third_party/skia c9873a5f8b8e..f3ebd312f213 (14 commits) (flutter/engine#6290)
2302bea Roll src/third_party/skia 9369031fde2d..c9873a5f8b8e (11 commits) (flutter/engine#6287)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/&#43;/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC&#39;d on the roll, and stop the roller if necessary.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 21, 2018
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 21, 2018
@engine-flutter-autoroll
Roll engine 71457a6..9ca6668 (6 commits)
31dc027 
flutter/engine@71457a6...9ca6668

git log 71457a6..9ca6668 --no-merges --oneline
9ca6668 Roll src/third_party/skia c9873a5f8b8e..44c6167c4125 (23 commits) (flutter/engine#6295)
8471862 Dart SDK roll for 2018/09/20 (flutter/engine#6294)
0036a3a Revert &#34;Roll src/third_party/skia c9873a5f8b8e..f3ebd312f213 (14 commits) (flutter#6290)&#34; as it broke Windows buildbot. (flutter/engine#6292)
ff78707 Remove runtime/dart_vm_entry_points.txt (flutter/engine#6291)
09afb2b Roll src/third_party/skia c9873a5f8b8e..f3ebd312f213 (14 commits) (flutter/engine#6290)
2302bea Roll src/third_party/skia 9369031fde2d..c9873a5f8b8e (11 commits) (flutter/engine#6287)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/&#43;/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC&#39;d on the roll, and stop the roller if necessary.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 21, 2018
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 21, 2018
@engine-flutter-autoroll
Roll engine 71457a6..a8890fd (7 commits)
4047a7c 
flutter/engine@71457a6...a8890fd

git log 71457a6..a8890fd --no-merges --oneline
a8890fd SkImageFilter needs to be imported in the header (flutter/engine#6296)
9ca6668 Roll src/third_party/skia c9873a5f8b8e..44c6167c4125 (23 commits) (flutter/engine#6295)
8471862 Dart SDK roll for 2018/09/20 (flutter/engine#6294)
0036a3a Revert &#34;Roll src/third_party/skia c9873a5f8b8e..f3ebd312f213 (14 commits) (flutter#6290)&#34; as it broke Windows buildbot. (flutter/engine#6292)
ff78707 Remove runtime/dart_vm_entry_points.txt (flutter/engine#6291)
09afb2b Roll src/third_party/skia c9873a5f8b8e..f3ebd312f213 (14 commits) (flutter/engine#6290)
2302bea Roll src/third_party/skia 9369031fde2d..c9873a5f8b8e (11 commits) (flutter/engine#6287)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/&#43;/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC&#39;d on the roll, and stop the roller if necessary.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 21, 2018
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 21, 2018
@engine-flutter-autoroll
Roll engine 71457a6..2ec20aa (8 commits)
559ea88 
flutter/engine@71457a6...2ec20aa

git log 71457a6..2ec20aa --no-merges --oneline
2ec20aa Remove bottom safe-area padding when keyboard up (flutter/engine#6297)
a8890fd SkImageFilter needs to be imported in the header (flutter/engine#6296)
9ca6668 Roll src/third_party/skia c9873a5f8b8e..44c6167c4125 (23 commits) (flutter/engine#6295)
8471862 Dart SDK roll for 2018/09/20 (flutter/engine#6294)
0036a3a Revert &#34;Roll src/third_party/skia c9873a5f8b8e..f3ebd312f213 (14 commits) (flutter#6290)&#34; as it broke Windows buildbot. (flutter/engine#6292)
ff78707 Remove runtime/dart_vm_entry_points.txt (flutter/engine#6291)
09afb2b Roll src/third_party/skia c9873a5f8b8e..f3ebd312f213 (14 commits) (flutter/engine#6290)
2302bea Roll src/third_party/skia 9369031fde2d..c9873a5f8b8e (11 commits) (flutter/engine#6287)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/&#43;/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC&#39;d on the roll, and stop the roller if necessary.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 21, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

autoroller: commit cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@skia-flutter-autoroll @aam @googlebot