Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Add Xib splashscreen support #6289

Merged
chinmaygarde merged 1 commit into from
Sep 21, 2018
Merged

Add Xib splashscreen support #6289

chinmaygarde merged 1 commit into from
Sep 21, 2018

Conversation

@kzietek
Copy link
Contributor

@kzietek kzietek commented Sep 20, 2018

When a XIB is used as a launch screen (UILaunchStoryboardName), now the splashScreenView property doesn't crash and returns a properly instantiated view.

@googlebot
Copy link

googlebot commented Sep 20, 2018

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers
Corporate signers

1 similar comment
@googlebot
Copy link

googlebot commented Sep 20, 2018

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers
Corporate signers

@kzietek
Copy link
Contributor Author

kzietek commented Sep 20, 2018

I signed it!

@googlebot
Copy link

googlebot commented Sep 20, 2018

CLAs look good, thanks!

1 similar comment
@googlebot
Copy link

googlebot commented Sep 20, 2018

CLAs look good, thanks!

@chinmaygarde chinmaygarde merged commit 540cd96 into flutter:master Sep 21, 2018
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 21, 2018
@engine-flutter-autoroll
Roll engine a8890fd..540cd96 (7 commits)
7118f7e 
flutter/engine@a8890fd...540cd96

git log a8890fd..540cd96 --no-merges --oneline
540cd96 Add Xib splashscreen support (flutter/engine#6289)
05f21e6 Fix a compilation problem when using iPhoneOS12.0sdk(Xcode10) && clang version 7.0.0. (flutter/engine#6279)
ca6f103 Roll src/third_party/skia d842557c0724..c25f440d537e (10 commits) (flutter/engine#6304)
3b46705 Roll src/third_party/skia 38ca6d509d9f..d842557c0724 (5 commits) (flutter/engine#6302)
0c166fe Roll src/third_party/skia 05cf051f0252..38ca6d509d9f (1 commits) (flutter/engine#6301)
cf0fbad Roll src/third_party/skia 44c6167c4125..05cf051f0252 (4 commits) (flutter/engine#6299)
2ec20aa Remove bottom safe-area padding when keyboard up (flutter/engine#6297)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 21, 2018
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 21, 2018
@engine-flutter-autoroll
Roll engine a8890fd..2a1debf (8 commits)
56446d8 
flutter/engine@a8890fd...2a1debf

git log a8890fd..2a1debf --no-merges --oneline
2a1debf Update deprecated subtags from language subtag registry. (flutter/engine#6280)
540cd96 Add Xib splashscreen support (flutter/engine#6289)
05f21e6 Fix a compilation problem when using iPhoneOS12.0sdk(Xcode10) && clang version 7.0.0. (flutter/engine#6279)
ca6f103 Roll src/third_party/skia d842557c0724..c25f440d537e (10 commits) (flutter/engine#6304)
3b46705 Roll src/third_party/skia 38ca6d509d9f..d842557c0724 (5 commits) (flutter/engine#6302)
0c166fe Roll src/third_party/skia 05cf051f0252..38ca6d509d9f (1 commits) (flutter/engine#6301)
cf0fbad Roll src/third_party/skia 44c6167c4125..05cf051f0252 (4 commits) (flutter/engine#6299)
2ec20aa Remove bottom safe-area padding when keyboard up (flutter/engine#6297)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 21, 2018
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 21, 2018
@engine-flutter-autoroll
Roll engine a8890fd..d29c7db (9 commits)
b1f761e 
flutter/engine@a8890fd...d29c7db

git log a8890fd..d29c7db --no-merges --oneline
d29c7db Add logging if FlutterDartProject fails to load the application kernel snapshot (flutter/engine#6257)
2a1debf Update deprecated subtags from language subtag registry. (flutter/engine#6280)
540cd96 Add Xib splashscreen support (flutter/engine#6289)
05f21e6 Fix a compilation problem when using iPhoneOS12.0sdk(Xcode10) && clang version 7.0.0. (flutter/engine#6279)
ca6f103 Roll src/third_party/skia d842557c0724..c25f440d537e (10 commits) (flutter/engine#6304)
3b46705 Roll src/third_party/skia 38ca6d509d9f..d842557c0724 (5 commits) (flutter/engine#6302)
0c166fe Roll src/third_party/skia 05cf051f0252..38ca6d509d9f (1 commits) (flutter/engine#6301)
cf0fbad Roll src/third_party/skia 44c6167c4125..05cf051f0252 (4 commits) (flutter/engine#6299)
2ec20aa Remove bottom safe-area padding when keyboard up (flutter/engine#6297)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 21, 2018
Closed
amirh added a commit that referenced this pull request Sep 21, 2018
@amirh
Revert "Add Xib splashscreen support (#6289)"
eefb28f 
This reverts commit 540cd96.
amirh added a commit that referenced this pull request Sep 21, 2018
@amirh
Revert "Fix a compilation problem when using iPhoneOS12.0sdk(Xcode10)…
bbdf7c1 
… && clang version 7.0.0." (#6307)

* Revert "Add logging if FlutterDartProject fails to load the application kernel snapshot (#6257)"

This reverts commit d29c7db.

* Revert "Update deprecated subtags from language subtag registry. (#6280)"

This reverts commit 2a1debf.

* Revert "Add Xib splashscreen support (#6289)"

This reverts commit 540cd96.

* Revert "Fix a compilation problem when using iPhoneOS12.0sdk(Xcode10) && clang version 7.0.0. (#6279)"

This reverts commit 05f21e6.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 21, 2018
@engine-flutter-autoroll
Roll engine a8890fd..dea0921 (10 commits)
d978784 
flutter/engine@a8890fd...dea0921

git log a8890fd..dea0921 --no-merges --oneline
dea0921 Roll src/third_party/skia c25f440d537e..358558a4cecc (17 commits) (flutter/engine#6308)
d29c7db Add logging if FlutterDartProject fails to load the application kernel snapshot (flutter/engine#6257)
2a1debf Update deprecated subtags from language subtag registry. (flutter/engine#6280)
540cd96 Add Xib splashscreen support (flutter/engine#6289)
05f21e6 Fix a compilation problem when using iPhoneOS12.0sdk(Xcode10) && clang version 7.0.0. (flutter/engine#6279)
ca6f103 Roll src/third_party/skia d842557c0724..c25f440d537e (10 commits) (flutter/engine#6304)
3b46705 Roll src/third_party/skia 38ca6d509d9f..d842557c0724 (5 commits) (flutter/engine#6302)
0c166fe Roll src/third_party/skia 05cf051f0252..38ca6d509d9f (1 commits) (flutter/engine#6301)
cf0fbad Roll src/third_party/skia 44c6167c4125..05cf051f0252 (4 commits) (flutter/engine#6299)
2ec20aa Remove bottom safe-area padding when keyboard up (flutter/engine#6297)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 21, 2018
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 21, 2018
@engine-flutter-autoroll
Roll engine a8890fd..bbdf7c1 (11 commits)
3aca3bd 
flutter/engine@a8890fd...bbdf7c1

git log a8890fd..bbdf7c1 --no-merges --oneline
bbdf7c1 Revert "Fix a compilation problem when using iPhoneOS12.0sdk(Xcode10) && clang version 7.0.0." (flutter/engine#6307)
dea0921 Roll src/third_party/skia c25f440d537e..358558a4cecc (17 commits) (flutter/engine#6308)
d29c7db Add logging if FlutterDartProject fails to load the application kernel snapshot (flutter/engine#6257)
2a1debf Update deprecated subtags from language subtag registry. (flutter/engine#6280)
540cd96 Add Xib splashscreen support (flutter/engine#6289)
05f21e6 Fix a compilation problem when using iPhoneOS12.0sdk(Xcode10) && clang version 7.0.0. (flutter/engine#6279)
ca6f103 Roll src/third_party/skia d842557c0724..c25f440d537e (10 commits) (flutter/engine#6304)
3b46705 Roll src/third_party/skia 38ca6d509d9f..d842557c0724 (5 commits) (flutter/engine#6302)
0c166fe Roll src/third_party/skia 05cf051f0252..38ca6d509d9f (1 commits) (flutter/engine#6301)
cf0fbad Roll src/third_party/skia 44c6167c4125..05cf051f0252 (4 commits) (flutter/engine#6299)
2ec20aa Remove bottom safe-area padding when keyboard up (flutter/engine#6297)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 21, 2018
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 21, 2018
@engine-flutter-autoroll
Roll engine a8890fd..cc3009c (12 commits)
cc1515d 
flutter/engine@a8890fd...cc3009c

git log a8890fd..cc3009c --no-merges --oneline
cc3009c Revert 'Dart SDK roll for 2018/09/20' 8471862 (flutter/engine#6309)
bbdf7c1 Revert "Fix a compilation problem when using iPhoneOS12.0sdk(Xcode10) && clang version 7.0.0." (flutter/engine#6307)
dea0921 Roll src/third_party/skia c25f440d537e..358558a4cecc (17 commits) (flutter/engine#6308)
d29c7db Add logging if FlutterDartProject fails to load the application kernel snapshot (flutter/engine#6257)
2a1debf Update deprecated subtags from language subtag registry. (flutter/engine#6280)
540cd96 Add Xib splashscreen support (flutter/engine#6289)
05f21e6 Fix a compilation problem when using iPhoneOS12.0sdk(Xcode10) && clang version 7.0.0. (flutter/engine#6279)
ca6f103 Roll src/third_party/skia d842557c0724..c25f440d537e (10 commits) (flutter/engine#6304)
3b46705 Roll src/third_party/skia 38ca6d509d9f..d842557c0724 (5 commits) (flutter/engine#6302)
0c166fe Roll src/third_party/skia 05cf051f0252..38ca6d509d9f (1 commits) (flutter/engine#6301)
cf0fbad Roll src/third_party/skia 44c6167c4125..05cf051f0252 (4 commits) (flutter/engine#6299)
2ec20aa Remove bottom safe-area padding when keyboard up (flutter/engine#6297)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 21, 2018
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 21, 2018
@engine-flutter-autoroll
Roll engine a8890fd..5b8e8c3 (14 commits)
124647f 
flutter/engine@a8890fd...5b8e8c3

git log a8890fd..5b8e8c3 --no-merges --oneline
5b8e8c3 Make FlutterStandardCodec handle writing NSData (flutter/engine#6207)
02901b7 Decouple PlatformViewsController from FlutterView. (flutter/engine#6303)
cc3009c Revert 'Dart SDK roll for 2018/09/20' 8471862 (flutter/engine#6309)
bbdf7c1 Revert "Fix a compilation problem when using iPhoneOS12.0sdk(Xcode10) && clang version 7.0.0." (flutter/engine#6307)
dea0921 Roll src/third_party/skia c25f440d537e..358558a4cecc (17 commits) (flutter/engine#6308)
d29c7db Add logging if FlutterDartProject fails to load the application kernel snapshot (flutter/engine#6257)
2a1debf Update deprecated subtags from language subtag registry. (flutter/engine#6280)
540cd96 Add Xib splashscreen support (flutter/engine#6289)
05f21e6 Fix a compilation problem when using iPhoneOS12.0sdk(Xcode10) && clang version 7.0.0. (flutter/engine#6279)
ca6f103 Roll src/third_party/skia d842557c0724..c25f440d537e (10 commits) (flutter/engine#6304)
3b46705 Roll src/third_party/skia 38ca6d509d9f..d842557c0724 (5 commits) (flutter/engine#6302)
0c166fe Roll src/third_party/skia 05cf051f0252..38ca6d509d9f (1 commits) (flutter/engine#6301)
cf0fbad Roll src/third_party/skia 44c6167c4125..05cf051f0252 (4 commits) (flutter/engine#6299)
2ec20aa Remove bottom safe-area padding when keyboard up (flutter/engine#6297)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 21, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@chinmaygarde chinmaygarde chinmaygarde approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kzietek @googlebot @chinmaygarde