Fix a compilation problem when using iPhoneOS12.0sdk(Xcode10) && clang version 7.0.0. #6279

kangwang1988 · 2018-09-19T06:06:21Z

When compiling Flutter engine corresponding to Flutter version0.8.2, using commands below:

./flutter/tools/gn --runtime-mode=debug --target-os=ios --ios --ios-cpu=arm
ninja -C out/ios_debug_arm/

I met up with an error:

KyleWongdeMacBook-Pro:src kylewong$ ninja -C out/ios_debug_arm/
ninja: Entering directory `out/ios_debug_arm/'
[1/31] OBJCXX obj/flutter/shell/platform/darwin/ios/framework/Source/libFlutter.FlutterAppDelegate.o
FAILED: obj/flutter/shell/platform/darwin/ios/framework/Source/libFlutter.FlutterAppDelegate.o 
../../buildtools/mac-x64/clang/bin/clang++ -MMD -MF obj/flutter/shell/platform/darwin/ios/framework/Source/libFlutter.FlutterAppDelegate.o.d -DFLUTTER_FRAMEWORK -DNO_TCMALLOC -DMEMORY_TOOL_REPLACES_ALLOCATOR -DMEMORY_SANITIZER_INITIAL_SIZE -DTOOLCHAIN_VERSION=c1408453246f0475547b6fe634c2f3dad71c6457 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_FORTIFY_SOURCE=2 -D_LIBCPP_ENABLE_THREAD_SAFETY_ANNOTATIONS -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DSK_HAS_JPEG_LIBRARY -DSK_HAS_PNG_LIBRARY -DSK_HAS_WEBP_LIBRARY -DFLUTTER_RUNTIME_MODE_DEBUG=1 -DFLUTTER_RUNTIME_MODE_PROFILE=2 -DFLUTTER_RUNTIME_MODE_RELEASE=3 -DFLUTTER_RUNTIME_MODE_DYNAMIC_PROFILE=4 -DFLUTTER_RUNTIME_MODE_DYNAMIC_RELEASE=5 -DFLUTTER_RUNTIME_MODE=1 -DFLUTTER_AOT=1 -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DU_STATIC_IMPLEMENTATION -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_FILE -DUCHAR_TYPE=uint16_t -DSK_DISABLE_EXPLICIT_GPU_RESOURCE_ALLOCATION -DSK_DISABLE_RENDER_TARGET_SORTING -DSK_SUPPORT_LEGACY_VULKAN_INTERFACE -DSK_LEGACY_SKCODEC_NONE_ENUM -I../.. -Igen -I../.. -I../../flutter/third_party/txt/src -I../../third_party/harfbuzz/src -I../../third_party/icu/source/common -I../../third_party/icu/source/i18n -I../../third_party/skia/include/android -I../../third_party/skia/include/c -I../../third_party/skia/include/codec -I../../third_party/skia/include/config -I../../third_party/skia/include/core -I../../third_party/skia/include/effects -I../../third_party/skia/include/encode -I../../third_party/skia/include/gpu -I../../third_party/skia/include/atlastext -I../../third_party/skia/include/pathops -I../../third_party/skia/include/ports -I../../third_party/skia/include/svg -I../../third_party/skia/include/utils -I../../third_party/skia/include/utils/mac -I../../third_party -I../../third_party/dart/runtime -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS12.0.sdk -miphoneos-version-min=8.0  -flto -fno-strict-aliasing -arch armv7 -fcolor-diagnostics -Wall -Wextra -Wendif-labels -Werror -Wno-missing-field-initializers -Wno-unused-parameter -Wunguarded-availability -fvisibility=hidden -stdlib=libc++ -Wheader-hygiene -Wstring-conversion -Wthread-safety -Os -fno-ident -fdata-sections -ffunction-sections -g2  -fvisibility-inlines-hidden -fobjc-call-cxx-cdtors -std=c++14 -fno-rtti -fno-exceptions -c ../../flutter/shell/platform/darwin/ios/framework/Source/FlutterAppDelegate.mm -o obj/flutter/shell/platform/darwin/ios/framework/Source/libFlutter.FlutterAppDelegate.o
../../flutter/shell/platform/darwin/ios/framework/Source/FlutterAppDelegate.mm:137:46: error: conflicting parameter types in implementation of 'application:continueUserActivity:restorationHandler:': 'void (^ _Nonnull)(NSArray<id<UIUserActivityRestoring>> * _Nullable)' vs 'void (^ _Nonnull)(NSArray *)' [-Werror,-Wmismatched-parameter-types]
      restorationHandler:(void (^)(NSArray*))restorationHandler {
                          ~~~~~~~~~~~~~~~~~~ ^
/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS12.0.sdk/System/Library/Frameworks/UIKit.framework/Headers/UIApplication.h:433:199: note: previous definition is here
- (BOOL)application:(UIApplication *)application continueUserActivity:(NSUserActivity *)userActivity restorationHandler:(void(^)(NSArray<id<UIUserActivityRestoring>> * __nullable restorableObjects))restorationHandler NS_AVAILABLE_IOS(8_0);
                                                                                                                         ~~~~~~                                                                       ^
1 error generated.
[10/31] OBJCXX obj/flutter/shell/platform/darwin/ios/framework/Source/libFlutter.FlutterViewController.o
ninja: build stopped: subcommand failed.

This pr fix the mismatched-parameter-types problem.

Flutter Environment:

[✓] Flutter (Channel unknown, v0.8.2, on Mac OS X 10.14 18A389, locale en-CN)
    • Flutter version 0.8.2 at /Users/kylewong/Codes/fwn_idlefish/flutter
    • Framework revision 5ab9e70727 (11 days ago), 2018-09-07 12:33:05 -0700
    • Engine revision 58a1894a1c
    • Dart version 2.1.0-dev.3.1.flutter-760a9690c2

[✓] Android toolchain - develop for Android devices (Android SDK 28.0.2)
    • Android SDK at /Users/kylewong/Library/Android/sdk
    • Android NDK at /Users/kylewong/Library/Android/sdk/ndk-bundle
    • Platform android-28, build-tools 28.0.2
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1024-b01)
    • All Android licenses accepted.

[!] iOS toolchain - develop for iOS devices (Xcode 10.0)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 10.0, Build version 10A254a
    • ios-deploy 1.9.2
    ! CocoaPods out of date (1.5.0 is recommended).
        CocoaPods is used to retrieve the iOS platform side's plugin code that responds to your plugin usage on the Dart side.
        Without resolving iOS dependencies with CocoaPods, plugins will not work on iOS.
        For more info, see https://flutter.io/platform-plugins
      To upgrade:
        brew upgrade cocoapods
        pod setup

[✓] Android Studio (version 3.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 27.1.1
    • Dart plugin version 173.4700
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1024-b01)

[!] Connected devices
    ! No devices available

googlebot · 2018-09-19T06:06:24Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

googlebot · 2018-09-19T06:06:24Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

kangwang1988 · 2018-09-19T06:07:22Z

As to the cla, we are "Corporate signers".

Previously, I've also filed a pr in flutter repo.

My email is: [email protected] and we have a google group: alibaba-flutter-contributors

kangwang1988 · 2018-09-19T06:07:41Z

I signed it!

googlebot · 2018-09-20T04:26:38Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

googlebot · 2018-09-20T04:26:38Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

jamesderlin

Looks reasonable to me.

flutter/engine@a8890fd...05f21e6 git log a8890fd..05f21e6 --no-merges --oneline 05f21e6 Fix a compilation problem when using iPhoneOS12.0sdk(Xcode10) && clang version 7.0.0. (flutter/engine#6279) ca6f103 Roll src/third_party/skia d842557c0724..c25f440d537e (10 commits) (flutter/engine#6304) 3b46705 Roll src/third_party/skia 38ca6d509d9f..d842557c0724 (5 commits) (flutter/engine#6302) 0c166fe Roll src/third_party/skia 05cf051f0252..38ca6d509d9f (1 commits) (flutter/engine#6301) cf0fbad Roll src/third_party/skia 44c6167c4125..05cf051f0252 (4 commits) (flutter/engine#6299) 2ec20aa Remove bottom safe-area padding when keyboard up (flutter/engine#6297) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.

flutter/engine@a8890fd...540cd96 git log a8890fd..540cd96 --no-merges --oneline 540cd96 Add Xib splashscreen support (flutter/engine#6289) 05f21e6 Fix a compilation problem when using iPhoneOS12.0sdk(Xcode10) && clang version 7.0.0. (flutter/engine#6279) ca6f103 Roll src/third_party/skia d842557c0724..c25f440d537e (10 commits) (flutter/engine#6304) 3b46705 Roll src/third_party/skia 38ca6d509d9f..d842557c0724 (5 commits) (flutter/engine#6302) 0c166fe Roll src/third_party/skia 05cf051f0252..38ca6d509d9f (1 commits) (flutter/engine#6301) cf0fbad Roll src/third_party/skia 44c6167c4125..05cf051f0252 (4 commits) (flutter/engine#6299) 2ec20aa Remove bottom safe-area padding when keyboard up (flutter/engine#6297) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.

flutter/engine@a8890fd...2a1debf git log a8890fd..2a1debf --no-merges --oneline 2a1debf Update deprecated subtags from language subtag registry. (flutter/engine#6280) 540cd96 Add Xib splashscreen support (flutter/engine#6289) 05f21e6 Fix a compilation problem when using iPhoneOS12.0sdk(Xcode10) && clang version 7.0.0. (flutter/engine#6279) ca6f103 Roll src/third_party/skia d842557c0724..c25f440d537e (10 commits) (flutter/engine#6304) 3b46705 Roll src/third_party/skia 38ca6d509d9f..d842557c0724 (5 commits) (flutter/engine#6302) 0c166fe Roll src/third_party/skia 05cf051f0252..38ca6d509d9f (1 commits) (flutter/engine#6301) cf0fbad Roll src/third_party/skia 44c6167c4125..05cf051f0252 (4 commits) (flutter/engine#6299) 2ec20aa Remove bottom safe-area padding when keyboard up (flutter/engine#6297) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.

amirh · 2018-09-21T21:02:59Z

Seems like this broke the mac engine build:

/b/build/slave/goma_cache/client/gomacc ../../buildtools/mac-x64/clang/bin/clang++ -MMD -MF obj/flutter/shell/platform/darwin/ios/framework/Source/libFlutter.FlutterAppDelegate.o.d -DFLUTTER_FRAMEWORK -DNO_TCMALLOC -DMEMORY_TOOL_REPLACES_ALLOCATOR -DMEMORY_SANITIZER_INITIAL_SIZE -DTOOLCHAIN_VERSION=c1408453246f0475547b6fe634c2f3dad71c6457 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_FORTIFY_SOURCE=2 -D_LIBCPP_ENABLE_THREAD_SAFETY_ANNOTATIONS -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DSK_HAS_JPEG_LIBRARY -DSK_HAS_PNG_LIBRARY -DSK_HAS_WEBP_LIBRARY -DFLUTTER_RUNTIME_MODE_DEBUG=1 -DFLUTTER_RUNTIME_MODE_PROFILE=2 -DFLUTTER_RUNTIME_MODE_RELEASE=3 -DFLUTTER_RUNTIME_MODE_DYNAMIC_PROFILE=4 -DFLUTTER_RUNTIME_MODE_DYNAMIC_RELEASE=5 -DFLUTTER_RUNTIME_MODE=1 -DFLUTTER_AOT=1 -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DU_STATIC_IMPLEMENTATION -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_FILE -DUCHAR_TYPE=uint16_t -DSK_DISABLE_EXPLICIT_GPU_RESOURCE_ALLOCATION -DSK_DISABLE_RENDER_TARGET_SORTING -DSK_SUPPORT_LEGACY_VULKAN_INTERFACE -DSK_LEGACY_SKCODEC_NONE_ENUM -I../.. -Igen -I../.. -I../../flutter/third_party/txt/src -I../../third_party/harfbuzz/src -I../../third_party/icu/source/common -I../../third_party/icu/source/i18n -I../../third_party/skia/include/android -I../../third_party/skia/include/c -I../../third_party/skia/include/codec -I../../third_party/skia/include/config -I../../third_party/skia/include/core -I../../third_party/skia/include/docs -I../../third_party/skia/include/effects -I../../third_party/skia/include/encode -I../../third_party/skia/include/gpu -I../../third_party/skia/include/atlastext -I../../third_party/skia/include/pathops -I../../third_party/skia/include/ports -I../../third_party/skia/include/svg -I../../third_party/skia/include/utils -I../../third_party/skia/include/utils/mac -I../../third_party -I../../third_party/dart/runtime -isysroot /Applications/Xcode9.0.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS11.0.sdk -miphoneos-version-min=8.0   -fno-strict-aliasing -arch arm64 -fcolor-diagnostics -Wall -Wextra -Wendif-labels -Werror -Wno-missing-field-initializers -Wno-unused-parameter -Wunguarded-availability -fvisibility=hidden -stdlib=libc++ -Wheader-hygiene -Wstring-conversion -Wthread-safety -Os -fno-ident -fdata-sections -ffunction-sections -g2  -fvisibility-inlines-hidden -fobjc-call-cxx-cdtors -std=c++14 -fno-rtti -fno-exceptions -c ../../flutter/shell/platform/darwin/ios/framework/Source/FlutterAppDelegate.mm -o obj/flutter/shell/platform/darwin/ios/framework/Source/libFlutter.FlutterAppDelegate.o
../../flutter/shell/platform/darwin/ios/framework/Source/FlutterAppDelegate.mm:137:47: error: no type or protocol named 'UIUserActivityRestoring'
      restorationHandler:(void (^)(NSArray<id<UIUserActivityRestoring>>* __nullable
                                              ^
../../flutter/shell/platform/darwin/ios/framework/Source/FlutterAppDelegate.mm:138:59: error: conflicting parameter types in implementation of 'application:continueUserActivity:restorationHandler:': 'void (^ _Nonnull)(NSArray * _Nullable)' vs 'void (^ _Nonnull)(NSArray<id> * _Nullable)' [-Werror,-Wmismatched-parameter-types]
                                       restorableObjects))restorationHandler {
                                       ~~~~~~~~~~~~~~~~~~ ^
/Applications/Xcode9.0.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS11.0.sdk/System/Library/Frameworks/UIKit.framework/Headers/UIApplication.h:429:170: note: previous definition is here
- (BOOL)application:(UIApplication *)application continueUserActivity:(NSUserActivity *)userActivity restorationHandler:(void(^)(NSArray * __nullable restorableObjects))restorationHandler NS_AVAILABLE_IOS(8_0);

https://uberchromegw.corp.google.com/i/client.flutter/builders/Mac%20Engine/builds/3766/steps/build%20ios_debug/logs/stdio

flutter/engine@a8890fd...d29c7db git log a8890fd..d29c7db --no-merges --oneline d29c7db Add logging if FlutterDartProject fails to load the application kernel snapshot (flutter/engine#6257) 2a1debf Update deprecated subtags from language subtag registry. (flutter/engine#6280) 540cd96 Add Xib splashscreen support (flutter/engine#6289) 05f21e6 Fix a compilation problem when using iPhoneOS12.0sdk(Xcode10) && clang version 7.0.0. (flutter/engine#6279) ca6f103 Roll src/third_party/skia d842557c0724..c25f440d537e (10 commits) (flutter/engine#6304) 3b46705 Roll src/third_party/skia 38ca6d509d9f..d842557c0724 (5 commits) (flutter/engine#6302) 0c166fe Roll src/third_party/skia 05cf051f0252..38ca6d509d9f (1 commits) (flutter/engine#6301) cf0fbad Roll src/third_party/skia 44c6167c4125..05cf051f0252 (4 commits) (flutter/engine#6299) 2ec20aa Remove bottom safe-area padding when keyboard up (flutter/engine#6297) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.

amirh · 2018-09-21T21:37:48Z

Reverting as this breaks CI.

… && clang version 7.0.0. (#6279)" This reverts commit 05f21e6.

… && clang version 7.0.0." (#6307) * Revert "Add logging if FlutterDartProject fails to load the application kernel snapshot (#6257)" This reverts commit d29c7db. * Revert "Update deprecated subtags from language subtag registry. (#6280)" This reverts commit 2a1debf. * Revert "Add Xib splashscreen support (#6289)" This reverts commit 540cd96. * Revert "Fix a compilation problem when using iPhoneOS12.0sdk(Xcode10) && clang version 7.0.0. (#6279)" This reverts commit 05f21e6.

flutter/engine@a8890fd...dea0921 git log a8890fd..dea0921 --no-merges --oneline dea0921 Roll src/third_party/skia c25f440d537e..358558a4cecc (17 commits) (flutter/engine#6308) d29c7db Add logging if FlutterDartProject fails to load the application kernel snapshot (flutter/engine#6257) 2a1debf Update deprecated subtags from language subtag registry. (flutter/engine#6280) 540cd96 Add Xib splashscreen support (flutter/engine#6289) 05f21e6 Fix a compilation problem when using iPhoneOS12.0sdk(Xcode10) && clang version 7.0.0. (flutter/engine#6279) ca6f103 Roll src/third_party/skia d842557c0724..c25f440d537e (10 commits) (flutter/engine#6304) 3b46705 Roll src/third_party/skia 38ca6d509d9f..d842557c0724 (5 commits) (flutter/engine#6302) 0c166fe Roll src/third_party/skia 05cf051f0252..38ca6d509d9f (1 commits) (flutter/engine#6301) cf0fbad Roll src/third_party/skia 44c6167c4125..05cf051f0252 (4 commits) (flutter/engine#6299) 2ec20aa Remove bottom safe-area padding when keyboard up (flutter/engine#6297) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.

flutter/engine@a8890fd...bbdf7c1 git log a8890fd..bbdf7c1 --no-merges --oneline bbdf7c1 Revert "Fix a compilation problem when using iPhoneOS12.0sdk(Xcode10) && clang version 7.0.0." (flutter/engine#6307) dea0921 Roll src/third_party/skia c25f440d537e..358558a4cecc (17 commits) (flutter/engine#6308) d29c7db Add logging if FlutterDartProject fails to load the application kernel snapshot (flutter/engine#6257) 2a1debf Update deprecated subtags from language subtag registry. (flutter/engine#6280) 540cd96 Add Xib splashscreen support (flutter/engine#6289) 05f21e6 Fix a compilation problem when using iPhoneOS12.0sdk(Xcode10) && clang version 7.0.0. (flutter/engine#6279) ca6f103 Roll src/third_party/skia d842557c0724..c25f440d537e (10 commits) (flutter/engine#6304) 3b46705 Roll src/third_party/skia 38ca6d509d9f..d842557c0724 (5 commits) (flutter/engine#6302) 0c166fe Roll src/third_party/skia 05cf051f0252..38ca6d509d9f (1 commits) (flutter/engine#6301) cf0fbad Roll src/third_party/skia 44c6167c4125..05cf051f0252 (4 commits) (flutter/engine#6299) 2ec20aa Remove bottom safe-area padding when keyboard up (flutter/engine#6297) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.

flutter/engine@a8890fd...cc3009c git log a8890fd..cc3009c --no-merges --oneline cc3009c Revert 'Dart SDK roll for 2018/09/20' 8471862 (flutter/engine#6309) bbdf7c1 Revert "Fix a compilation problem when using iPhoneOS12.0sdk(Xcode10) && clang version 7.0.0." (flutter/engine#6307) dea0921 Roll src/third_party/skia c25f440d537e..358558a4cecc (17 commits) (flutter/engine#6308) d29c7db Add logging if FlutterDartProject fails to load the application kernel snapshot (flutter/engine#6257) 2a1debf Update deprecated subtags from language subtag registry. (flutter/engine#6280) 540cd96 Add Xib splashscreen support (flutter/engine#6289) 05f21e6 Fix a compilation problem when using iPhoneOS12.0sdk(Xcode10) && clang version 7.0.0. (flutter/engine#6279) ca6f103 Roll src/third_party/skia d842557c0724..c25f440d537e (10 commits) (flutter/engine#6304) 3b46705 Roll src/third_party/skia 38ca6d509d9f..d842557c0724 (5 commits) (flutter/engine#6302) 0c166fe Roll src/third_party/skia 05cf051f0252..38ca6d509d9f (1 commits) (flutter/engine#6301) cf0fbad Roll src/third_party/skia 44c6167c4125..05cf051f0252 (4 commits) (flutter/engine#6299) 2ec20aa Remove bottom safe-area padding when keyboard up (flutter/engine#6297) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.

flutter/engine@a8890fd...5b8e8c3 git log a8890fd..5b8e8c3 --no-merges --oneline 5b8e8c3 Make FlutterStandardCodec handle writing NSData (flutter/engine#6207) 02901b7 Decouple PlatformViewsController from FlutterView. (flutter/engine#6303) cc3009c Revert 'Dart SDK roll for 2018/09/20' 8471862 (flutter/engine#6309) bbdf7c1 Revert "Fix a compilation problem when using iPhoneOS12.0sdk(Xcode10) && clang version 7.0.0." (flutter/engine#6307) dea0921 Roll src/third_party/skia c25f440d537e..358558a4cecc (17 commits) (flutter/engine#6308) d29c7db Add logging if FlutterDartProject fails to load the application kernel snapshot (flutter/engine#6257) 2a1debf Update deprecated subtags from language subtag registry. (flutter/engine#6280) 540cd96 Add Xib splashscreen support (flutter/engine#6289) 05f21e6 Fix a compilation problem when using iPhoneOS12.0sdk(Xcode10) && clang version 7.0.0. (flutter/engine#6279) ca6f103 Roll src/third_party/skia d842557c0724..c25f440d537e (10 commits) (flutter/engine#6304) 3b46705 Roll src/third_party/skia 38ca6d509d9f..d842557c0724 (5 commits) (flutter/engine#6302) 0c166fe Roll src/third_party/skia 05cf051f0252..38ca6d509d9f (1 commits) (flutter/engine#6301) cf0fbad Roll src/third_party/skia 44c6167c4125..05cf051f0252 (4 commits) (flutter/engine#6299) 2ec20aa Remove bottom safe-area padding when keyboard up (flutter/engine#6297) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.

kangwang1988 added 2 commits September 19, 2018 13:23

Fix a compilation problem when using iPhoneOS12.0sdk(Xcode10).

213afc2

Format changed files.

3189d61

googlebot added the cla: no label Sep 19, 2018

jamesderlin added cla: yes and removed cla: no labels Sep 20, 2018

jamesderlin approved these changes Sep 20, 2018

View reviewed changes

chinmaygarde approved these changes Sep 21, 2018

View reviewed changes

chinmaygarde merged commit 05f21e6 into flutter:master Sep 21, 2018

engine-flutter-autoroll mentioned this pull request Sep 21, 2018

Roll engine a8890fdccd66..05f21e63a115 (6 commits) flutter/flutter#22144

Closed

engine-flutter-autoroll mentioned this pull request Sep 21, 2018

Roll engine a8890fdccd66..540cd96262ed (7 commits) flutter/flutter#22145

Closed

engine-flutter-autoroll mentioned this pull request Sep 21, 2018

Roll engine a8890fdccd66..2a1debfccfe2 (8 commits) flutter/flutter#22146

Closed

engine-flutter-autoroll mentioned this pull request Sep 21, 2018

Roll engine a8890fdccd66..d29c7db769d1 (9 commits) flutter/flutter#22150

Closed

amirh added a commit that referenced this pull request Sep 21, 2018

Revert "Fix a compilation problem when using iPhoneOS12.0sdk(Xcode10)…

dbdf986

… && clang version 7.0.0. (#6279)" This reverts commit 05f21e6.

amirh mentioned this pull request Sep 21, 2018

Revert "Fix a compilation problem when using iPhoneOS12.0sdk(Xcode10) && clang version 7.0.0." #6307

Merged

engine-flutter-autoroll mentioned this pull request Sep 21, 2018

Roll engine a8890fdccd66..dea09212cbcc (10 commits) flutter/flutter#22152

Closed

engine-flutter-autoroll mentioned this pull request Sep 21, 2018

Roll engine a8890fdccd66..bbdf7c1581db (11 commits) flutter/flutter#22154

Closed

engine-flutter-autoroll mentioned this pull request Sep 21, 2018

Roll engine a8890fdccd66..cc3009cb4ea9 (12 commits) flutter/flutter#22155

Closed

engine-flutter-autoroll mentioned this pull request Sep 21, 2018

Roll engine a8890fdccd66..5b8e8c328a6c (14 commits) flutter/flutter#22156

Closed

kangwang1988 mentioned this pull request Sep 26, 2018

V0.8.2 fix compile problem with xcode10 #6339

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix a compilation problem when using iPhoneOS12.0sdk(Xcode10) && clang version 7.0.0. #6279

Fix a compilation problem when using iPhoneOS12.0sdk(Xcode10) && clang version 7.0.0. #6279

Uh oh!

kangwang1988 commented Sep 19, 2018

Uh oh!

googlebot commented Sep 19, 2018

Uh oh!

googlebot commented Sep 19, 2018

Uh oh!

kangwang1988 commented Sep 19, 2018

Uh oh!

kangwang1988 commented Sep 19, 2018

Uh oh!

googlebot commented Sep 20, 2018

Uh oh!

googlebot commented Sep 20, 2018

Uh oh!

jamesderlin left a comment

Uh oh!

amirh commented Sep 21, 2018

Uh oh!

amirh commented Sep 21, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Fix a compilation problem when using iPhoneOS12.0sdk(Xcode10) && clang version 7.0.0. #6279

Fix a compilation problem when using iPhoneOS12.0sdk(Xcode10) && clang version 7.0.0. #6279

Uh oh!

Conversation

kangwang1988 commented Sep 19, 2018

Uh oh!

googlebot commented Sep 19, 2018

What to do if you already signed the CLA

Individual signers

Corporate signers

Uh oh!

googlebot commented Sep 19, 2018

What to do if you already signed the CLA

Individual signers

Corporate signers

Uh oh!

kangwang1988 commented Sep 19, 2018

Uh oh!

kangwang1988 commented Sep 19, 2018

Uh oh!

googlebot commented Sep 20, 2018

Uh oh!

googlebot commented Sep 20, 2018

Uh oh!

jamesderlin left a comment

Choose a reason for hiding this comment

Uh oh!

amirh commented Sep 21, 2018

Uh oh!

amirh commented Sep 21, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants