This repository was archived by the owner on Feb 25, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6k
[fuchsia] Fixes for the Fuchsia build #6273
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmacnak-google
approved these changes
Sep 17, 2018
Contributor
rmacnak-google
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Snapshot LGTM
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 17, 2018
flutter/engine@b0b19d6...dbfa827 git log b0b19d6..dbfa827 --no-merges --oneline dbfa827 [fuchsia] Fixes for the Fuchsia build (flutter/engine#6273) dcbc8a8 Roll Dart to 050561fd82be5e775316223c9d2d9e7e5e596c8e (flutter/engine#6271) ba77529 Ensure that Layer::AutoSaveLayer objects are not immediately destructed (flutter/engine#6264) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 18, 2018
flutter/engine@b0b19d6...cdbe214 git log b0b19d6..cdbe214 --no-merges --oneline cdbe214 Update test .gitignore (flutter/engine#6272) dbfa827 [fuchsia] Fixes for the Fuchsia build (flutter/engine#6273) dcbc8a8 Roll Dart to 050561fd82be5e775316223c9d2d9e7e5e596c8e (flutter/engine#6271) ba77529 Ensure that Layer::AutoSaveLayer objects are not immediately destructed (flutter/engine#6264) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 18, 2018
flutter/engine@dcbc8a8...9e315e6 git log dcbc8a8..9e315e6 --no-merges --oneline 9e315e6 Remove entries from dart_vm_entry_points.txt and use annotations (flutter/engine#6226) cdbe214 Update test .gitignore (flutter/engine#6272) dbfa827 [fuchsia] Fixes for the Fuchsia build (flutter/engine#6273) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Sep 18, 2018
flutter/engine@dcbc8a8...9e315e6 git log dcbc8a8..9e315e6 --no-merges --oneline 9e315e6 Remove entries from dart_vm_entry_points.txt and use annotations (flutter/engine#6226) cdbe214 Update test .gitignore (flutter/engine#6272) dbfa827 [fuchsia] Fixes for the Fuchsia build (flutter/engine#6273) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
amirh
pushed a commit
to amirh/engine
that referenced
this pull request
Sep 21, 2018
amirh
pushed a commit
to amirh/engine
that referenced
this pull request
Sep 21, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.